bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Only suggest if span is not erroneous

Browse source
This commit is contained in:
Michael Goulet 2022-07-15 17:32:15 +00:00
parent b71a09fda0
commit 2902b92769
3 changed files with 12 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

19
compiler/rustc_lint/src/context.rs
View file

@ -858,15 +858,16 @@ pub trait LintContext: Sized {
},
BuiltinLintDiagnostics::NamedArgumentUsedPositionally(positional_arg, named_arg, name) => {
db.span_label(named_arg, "this named argument is only referred to by position in formatting string");
let msg = format!("this formatting argument uses named argument `{}` by position", name);
db.span_label(positional_arg, msg);
db.span_suggestion_verbose(
positional_arg,
"use the named argument by name to avoid ambiguity",
format!("{{{}}}", name),
Applicability::MaybeIncorrect,
);
if let Some(positional_arg) = positional_arg {
let msg = format!("this formatting argument uses named argument `{}` by position", name);
db.span_label(positional_arg, msg);
db.span_suggestion_verbose(
positional_arg,
"use the named argument by name to avoid ambiguity",
format!("{{{}}}", name),
Applicability::MaybeIncorrect,
);
}
}
}
// Rewrap `db`, and pass control to the user.