Replace parse_[sth]_expr with parse_expr_[sth] function names
This resolves an inconsistency in naming style for functions on the parser, between functions parsing specific kinds of items and those for expressions, favoring the parse_item_[sth] style used by functions for items. There are multiple advantages of that style: * functions of both categories are collected in the same place in the rustdoc output. * it helps with autocompletion, as you can narrow down your search for a function to those about expressions. * it mirrors rust's path syntax where less specific things come first, then it gets more specific, i.e. std::collections::hash_map::Entry The disadvantage is that it doesn't "read like a sentence" any more, but I think the advantages weigh more greatly. This change was mostly application of this command: sed -i -E 's/(fn |\.)parse_([[:alnum:]_]+)_expr/\1parse_expr_\2/' compiler/rustc_parse/src/parser/*.rs Plus very minor fixes outside of rustc_parse, and an invocation of x fmt.
This commit is contained in:
parent
07c993eba8
commit
2850116636
7 changed files with 131 additions and 131 deletions
|
@ -1331,7 +1331,7 @@ impl<'a> Parser<'a> {
|
|||
};
|
||||
|
||||
let disr_expr =
|
||||
if this.eat(&token::Eq) { Some(this.parse_anon_const_expr()?) } else { None };
|
||||
if this.eat(&token::Eq) { Some(this.parse_expr_anon_const()?) } else { None };
|
||||
|
||||
let vr = ast::Variant {
|
||||
ident,
|
||||
|
@ -1722,7 +1722,7 @@ impl<'a> Parser<'a> {
|
|||
}
|
||||
if self.token.kind == token::Eq {
|
||||
self.bump();
|
||||
let const_expr = self.parse_anon_const_expr()?;
|
||||
let const_expr = self.parse_expr_anon_const()?;
|
||||
let sp = ty.span.shrink_to_hi().to(const_expr.value.span);
|
||||
self.struct_span_err(sp, "default values on `struct` fields aren't supported")
|
||||
.span_suggestion(
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue