bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

rustc_codegen_llvm: don't treat i1 as signed, even for #[repr(i8)] enums.

Browse source
This commit is contained in:
Eduard-Mihai Burtescu 2018-06-16 14:19:05 +03:00
parent 68cee8bb36
commit 25c47a4885
3 changed files with 37 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/librustc_codegen_llvm/mir/rvalue.rs
View file

@ -298,7 +298,11 @@ impl<'a, 'tcx> FunctionCx<'a, 'tcx> {
let mut signed = false;
if let layout::Abi::Scalar(ref scalar) = operand.layout.abi {
if let layout::Int(_, s) = scalar.value {
signed = s;
// We use `i1` for bytes that are always `0` or `1`,
// e.g. `#[repr(i8)] enum E { A, B }`, but we can't
// let LLVM interpret the `i1` as signed, because
// then `i1 1` (i.e. E::B) is effectively `i8 -1`.
signed = !scalar.is_bool() && s;
if scalar.valid_range.end() > scalar.valid_range.start() {
// We want `table[e as usize]` to not