bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Improve error when an .rlib can't be parsed

Browse source 
This usually describes either an error in the compiler itself or some
sort of IO error. Either way, we should report it to the user rather
than just saying "crate not found".

This only gives an error if the crate couldn't be loaded at all - if the
compiler finds another .rlib or .rmeta file which was valid, it will
continue to compile the crate.

Example output:
```
error[E0785]: found invalid metadata files for crate `foo`
 --> bar.rs:3:24
  |
3 |         println!("{}", foo::FOO_11_49[0]);
  |                        ^^^
  |
  = warning: failed to parse rlib '/home/joshua/test-rustdoc/libfoo.rlib': Invalid archive extended name offset
```
This commit is contained in:
Joshua Nelson 2021-08-26 18:37:44 +00:00
parent 90a273b785
commit 257ac1b498
9 changed files with 118 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

1
compiler/rustc_error_codes/src/error_codes.rs
View file

@ -484,6 +484,7 @@ E0782: include_str!("./error_codes/E0782.md"),
E0783: include_str!("./error_codes/E0783.md"),
E0784: include_str!("./error_codes/E0784.md"),
E0785: include_str!("./error_codes/E0785.md"),
E0786: include_str!("./error_codes/E0786.md"),
;
// E0006, // merged with E0005
// E0008, // cannot bind by-move into a pattern guard

14
compiler/rustc_error_codes/src/error_codes/E0786.md Normal file
View file

@ -0,0 +1,14 @@
A metadata file was invalid.
Erroneous code example:
```ignore (needs extern files)
use ::foo; // error: found invalid metadata files for crate `foo`
```
When loading crates, each crate must have a valid metadata file.
Invalid files could be caused by filesystem corruption,
an IO error while reading the file, or (rarely) a bug in the compiler itself.
Consider deleting the file and recreating it,
or reporting a bug against the compiler.