bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Add explanatory note to async block type mismatch error

Browse source
This commit is contained in:
Gurinder Singh 2024-06-10 17:14:49 +05:30
parent 16e8803579
commit 251d2d0d4d
2 changed files with 13 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
compiler/rustc_infer/src/infer/error_reporting/note_and_explain.rs
View file

@ -32,6 +32,15 @@ impl<'tcx> TypeErrCtxt<'_, 'tcx> {
diag.note("no two closures, even if identical, have the same type"); diag.note("no two closures, even if identical, have the same type");
diag.help("consider boxing your closure and/or using it as a trait object"); diag.help("consider boxing your closure and/or using it as a trait object");
} }
(ty::Coroutine(def_id1, ..), ty::Coroutine(def_id2, ..))
if self.tcx.coroutine_is_async(def_id1)
&& self.tcx.coroutine_is_async(def_id2) =>
{
diag.note("no two async blocks, even if identical, have the same type");
diag.help(
"consider pinning your async block and casting it to a trait object",
);
}
(ty::Alias(ty::Opaque, ..), ty::Alias(ty::Opaque, ..)) => { (ty::Alias(ty::Opaque, ..), ty::Alias(ty::Opaque, ..)) => {
// Issue #63167 // Issue #63167
diag.note("distinct uses of `impl Trait` result in different opaque types"); diag.note("distinct uses of `impl Trait` result in different opaque types");

4
tests/ui/async-await/coroutine-desc.stderr
View file

@ -10,6 +10,8 @@ LL | fun(async {}, async {});
| |
= note: expected `async` block `{async block@$DIR/coroutine-desc.rs:10:9: 10:17}` = note: expected `async` block `{async block@$DIR/coroutine-desc.rs:10:9: 10:17}`
found `async` block `{async block@$DIR/coroutine-desc.rs:10:19: 10:27}` found `async` block `{async block@$DIR/coroutine-desc.rs:10:19: 10:27}`
= note: no two async blocks, even if identical, have the same type
= help: consider pinning your async block and casting it to a trait object
note: function defined here note: function defined here
--> $DIR/coroutine-desc.rs:8:4 --> $DIR/coroutine-desc.rs:8:4
| |
@ -51,6 +53,8 @@ LL | fun((async || {})(), (async || {})());
| |
= note: expected `async` closure body `{async closure body@$DIR/coroutine-desc.rs:14:19: 14:21}` = note: expected `async` closure body `{async closure body@$DIR/coroutine-desc.rs:14:19: 14:21}`
found `async` closure body `{async closure body@$DIR/coroutine-desc.rs:14:36: 14:38}` found `async` closure body `{async closure body@$DIR/coroutine-desc.rs:14:36: 14:38}`
= note: no two async blocks, even if identical, have the same type
= help: consider pinning your async block and casting it to a trait object
note: function defined here note: function defined here
--> $DIR/coroutine-desc.rs:8:4 --> $DIR/coroutine-desc.rs:8:4
| |