bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

translations(rustc_session): remove lint allow rule to the methods marked with rustc_lint_diagnostic

Browse source 
This commit removes the allows rules for the SessionDiagnostic lint
that were being used in the session.rs file.

Thanks to the PR #101230 we do not need to annotate the methods with
the allow rule as they are part of the diagnostic machinery.
This commit is contained in:
Luis Cardoso 2022-09-05 07:58:05 +02:00
parent 0f06320c24
commit 24de9435e2
5 changed files with 12 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

15
compiler/rustc_session/src/errors.rs
View file

@ -1,9 +1,8 @@
use std::num::NonZeroU32;
use crate::cgu_reuse_tracker::CguReuse;
use crate::parse::ParseSess;
use crate::{self as rustc_session};
use rustc_errors::{fluent, MultiSpan};
use crate::{self as rustc_session, SessionDiagnostic};
use rustc_errors::{fluent, DiagnosticBuilder, Handler, MultiSpan};
use rustc_macros::SessionDiagnostic;
use rustc_span::{Span, Symbol};
use rustc_target::abi::TargetDataLayoutErrors;
@ -46,14 +45,10 @@ pub struct FeatureDiagnosticHelp {
pub feature: Symbol,
}
pub struct TargetDataLayoutParseError<'a> {
pub err: TargetDataLayoutErrors<'a>,
}
impl crate::SessionDiagnostic<'_, !> for TargetDataLayoutParseError<'_> {
fn into_diagnostic(self, sess: &ParseSess) -> rustc_errors::DiagnosticBuilder<'_, !> {
impl SessionDiagnostic<'_, !> for TargetDataLayoutErrors<'_> {
fn into_diagnostic(self, sess: &Handler) -> DiagnosticBuilder<'_, !> {
let mut diag;
match self.err {
match self {
TargetDataLayoutErrors::InvalidAddressSpace { addr_space, err, cause } => {
diag = sess.struct_fatal(fluent::session::target_invalid_address_space);
diag.set_arg("addr_space", addr_space);