bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #91818 - camelid:unused-result-type, r=jackh726

Browse source 
Show the unused type for `unused_results` lint

I think it's helpful to know what type was unused when looking at these
warnings. The type will likely determine whether the result *should* be
used, or whether it should just be ignored.

Including the type also matches the behavior of the `must_use` lint:
unused `SomeType` that must be used.
This commit is contained in:
Matthias Krüger 2021-12-18 08:16:27 +01:00 • committed by GitHub
commit 24b75e7113
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_lint/src/unused.rs
View file

@ -169,7 +169,9 @@ impl<'tcx> LateLintPass<'tcx> for UnusedResults {
}
if !(type_permits_lack_of_use || fn_warned || op_warned) {
cx.struct_span_lint(UNUSED_RESULTS, s.span, |lint| lint.build("unused result").emit());
cx.struct_span_lint(UNUSED_RESULTS, s.span, |lint| {
lint.build(&format!("unused result of type `{}`", ty)).emit()
});
}
// Returns whether an error has been emitted (and thus another does not need to be later).