bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Add method-toggle to <details> for methods.

Browse source 
The makes the code for handling "auto-hide" settings more consistent.
This commit is contained in:
Jacob Hoffman-Andrews 2021-05-10 16:41:41 -07:00
parent 491cf5561e
commit 24480ded58
2 changed files with 10 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/librustdoc/html/render/mod.rs
View file

@ -1352,8 +1352,11 @@ fn render_impl(
} }
let w = if short_documented && trait_.is_some() { interesting } else { boring }; let w = if short_documented && trait_.is_some() { interesting } else { boring };
if !doc_buffer.is_empty() { let toggled = !doc_buffer.is_empty();
w.write_str("<details class=\"rustdoc-toggle\" open><summary>"); if toggled {
let method_toggle_class =
if item_type == ItemType::Method { " method-toggle" } else { "" };
write!(w, "<details class=\"rustdoc-toggle{}\" open><summary>", method_toggle_class);
} }
match *item.kind { match *item.kind {
clean::MethodItem(..) | clean::TyMethodItem(_) => { clean::MethodItem(..) | clean::TyMethodItem(_) => {
@ -1453,7 +1456,7 @@ fn render_impl(
} }
w.push_buffer(info_buffer); w.push_buffer(info_buffer);
if !doc_buffer.is_empty() { if toggled {
w.write_str("</summary>"); w.write_str("</summary>");
w.push_buffer(doc_buffer); w.push_buffer(doc_buffer);
w.push_str("</details>"); w.push_str("</details>");

16
src/librustdoc/html/static/main.js
View file

@ -924,24 +924,16 @@ function hideThemeButtonState() {
}); });
} }
if (hideMethodDocs) {
onEachLazy(document.getElementsByClassName("method"), function(e) {
var toggle = e.parentNode;
if (toggle) {
toggle = toggle.parentNode;
}
if (toggle && toggle.tagName === "DETAILS") {
toggle.open = false;
}
});
}
onEachLazy(document.getElementsByTagName("details"), function (e) { onEachLazy(document.getElementsByTagName("details"), function (e) {
var showLargeItem = !hideLargeItemContents && hasClass(e, "type-contents-toggle"); var showLargeItem = !hideLargeItemContents && hasClass(e, "type-contents-toggle");
var showImplementor = !hideImplementors && hasClass(e, "implementors-toggle"); var showImplementor = !hideImplementors && hasClass(e, "implementors-toggle");
if (showLargeItem || showImplementor) { if (showLargeItem || showImplementor) {
e.open = true; e.open = true;
} }
if (hideMethodDocs && hasClass(e, "method-toggle")) {
e.open = false;
}
}); });
var currentType = document.getElementsByClassName("type-decl")[0]; var currentType = document.getElementsByClassName("type-decl")[0];