bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

for_loop_over_fallibles: fix suggestion for "remove .next()" case

Browse source 
if the iterator is used after the loop, we need to use `.by_ref()`
This commit is contained in:
Maybe Waffle 2022-07-25 00:58:04 +04:00
parent 7308564423
commit 23a7674e3e
2 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_lint/src/for_loop_over_fallibles.rs
View file

@ -82,7 +82,7 @@ impl<'tcx> LateLintPass<'tcx> for ForLoopOverFallibles {
warn.span_suggestion( warn.span_suggestion(
recv.span.between(arg.span.shrink_to_hi()), recv.span.between(arg.span.shrink_to_hi()),
format!("to iterate over `{recv_snip}` remove the call to `next`"), format!("to iterate over `{recv_snip}` remove the call to `next`"),
"", ".by_ref()",
Applicability::MaybeIncorrect Applicability::MaybeIncorrect
); );
} else { } else {

5
src/test/ui/lint/for_loop_over_fallibles.stderr
View file

@ -37,9 +37,8 @@ LL | for _ in [0; 0].iter().next() {}
| |
help: to iterate over `[0; 0].iter()` remove the call to `next` help: to iterate over `[0; 0].iter()` remove the call to `next`
| |
LL - for _ in [0; 0].iter().next() {} LL | for _ in [0; 0].iter().by_ref() {}
LL + for _ in [0; 0].iter() {} | ~~~~~~~~~
|
help: consider using `if let` to clear intent help: consider using `if let` to clear intent
| |
LL | if let Some(_) = [0; 0].iter().next() {} LL | if let Some(_) = [0; 0].iter().next() {}