bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

url: encode small bytes correctly.

Browse source 
Previously, bytes less than 16 would be encoded as %X, rather than %XX,
since the output width was left to be automatic.
This commit is contained in:
Huon Wilson 2014-06-07 00:49:19 +10:00 • committed by Alex Crichton
parent b662aa5ec0
commit 1f4d8f924e
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/liburl/lib.rs
View file

@ -161,10 +161,10 @@ fn encode_inner(s: &str, full_url: bool) -> String {
out.push_char(ch); out.push_char(ch);
} }
_ => out.push_str(format!("%{:X}", ch as uint).as_slice()) _ => out.push_str(format!("%{:02X}", ch as uint).as_slice())
} }
} else { } else {
out.push_str(format!("%{:X}", ch as uint).as_slice()); out.push_str(format!("%{:02X}", ch as uint).as_slice());
} }
} }
} }
@ -1178,6 +1178,8 @@ mod tests {
assert_eq!(encode("@"), "@".to_string()); assert_eq!(encode("@"), "@".to_string());
assert_eq!(encode("["), "[".to_string()); assert_eq!(encode("["), "[".to_string());
assert_eq!(encode("]"), "]".to_string()); assert_eq!(encode("]"), "]".to_string());
assert_eq!(encode("\0"), "%00".to_string());
assert_eq!(encode("\n"), "%0A".to_string());
} }
#[test] #[test]
@ -1207,6 +1209,8 @@ mod tests {
assert_eq!(encode_component("@"), "%40".to_string()); assert_eq!(encode_component("@"), "%40".to_string());
assert_eq!(encode_component("["), "%5B".to_string()); assert_eq!(encode_component("["), "%5B".to_string());
assert_eq!(encode_component("]"), "%5D".to_string()); assert_eq!(encode_component("]"), "%5D".to_string());
assert_eq!(encode_component("\0"), "%00".to_string());
assert_eq!(encode_component("\n"), "%0A".to_string());
} }
#[test] #[test]