1
Fork 0

Remove inner function in bind, connect and send_to

This commit is contained in:
LinkTed 2020-08-25 19:33:33 +02:00
parent 4c929a00ee
commit 1f3195a5df
3 changed files with 31 additions and 47 deletions

View file

@ -85,18 +85,15 @@ impl UnixDatagram {
/// ```
#[stable(feature = "unix_socket", since = "1.10.0")]
pub fn bind<P: AsRef<Path>>(path: P) -> io::Result<UnixDatagram> {
fn inner(path: &Path) -> io::Result<UnixDatagram> {
unsafe {
let socket = UnixDatagram::unbound()?;
let (addr, len) = sockaddr_un(path)?;
let (addr, len) = sockaddr_un(path.as_ref())?;
cvt(libc::bind(*socket.0.as_inner(), &addr as *const _ as *const _, len as _))?;
Ok(socket)
}
}
inner(path.as_ref())
}
/// Creates a Unix Datagram socket which is not bound to any address.
///
@ -170,17 +167,13 @@ impl UnixDatagram {
/// ```
#[stable(feature = "unix_socket", since = "1.10.0")]
pub fn connect<P: AsRef<Path>>(&self, path: P) -> io::Result<()> {
fn inner(d: &UnixDatagram, path: &Path) -> io::Result<()> {
unsafe {
let (addr, len) = sockaddr_un(path)?;
cvt(libc::connect(*d.0.as_inner(), &addr as *const _ as *const _, len))?;
let (addr, len) = sockaddr_un(path.as_ref())?;
cvt(libc::connect(*self.0.as_inner(), &addr as *const _ as *const _, len))?;
}
Ok(())
}
}
inner(self, path.as_ref())
}
/// Creates a new independently owned handle to the underlying socket.
///
@ -430,12 +423,11 @@ impl UnixDatagram {
/// ```
#[stable(feature = "unix_socket", since = "1.10.0")]
pub fn send_to<P: AsRef<Path>>(&self, buf: &[u8], path: P) -> io::Result<usize> {
fn inner(d: &UnixDatagram, buf: &[u8], path: &Path) -> io::Result<usize> {
unsafe {
let (addr, len) = sockaddr_un(path)?;
let (addr, len) = sockaddr_un(path.as_ref())?;
let count = cvt(libc::sendto(
*d.0.as_inner(),
*self.0.as_inner(),
buf.as_ptr() as *const _,
buf.len(),
MSG_NOSIGNAL,
@ -445,8 +437,6 @@ impl UnixDatagram {
Ok(count as usize)
}
}
inner(self, buf, path.as_ref())
}
/// Sends data on the socket to the socket's peer.
///

View file

@ -71,10 +71,9 @@ impl UnixListener {
/// ```
#[stable(feature = "unix_socket", since = "1.10.0")]
pub fn bind<P: AsRef<Path>>(path: P) -> io::Result<UnixListener> {
fn inner(path: &Path) -> io::Result<UnixListener> {
unsafe {
let inner = Socket::new_raw(libc::AF_UNIX, libc::SOCK_STREAM)?;
let (addr, len) = sockaddr_un(path)?;
let (addr, len) = sockaddr_un(path.as_ref())?;
cvt(libc::bind(*inner.as_inner(), &addr as *const _ as *const _, len as _))?;
cvt(libc::listen(*inner.as_inner(), 128))?;
@ -82,8 +81,6 @@ impl UnixListener {
Ok(UnixListener(inner))
}
}
inner(path.as_ref())
}
/// Accepts a new incoming connection to this listener.
///

View file

@ -87,17 +87,14 @@ impl UnixStream {
/// ```
#[stable(feature = "unix_socket", since = "1.10.0")]
pub fn connect<P: AsRef<Path>>(path: P) -> io::Result<UnixStream> {
fn inner(path: &Path) -> io::Result<UnixStream> {
unsafe {
let inner = Socket::new_raw(libc::AF_UNIX, libc::SOCK_STREAM)?;
let (addr, len) = sockaddr_un(path)?;
let (addr, len) = sockaddr_un(path.as_ref())?;
cvt(libc::connect(*inner.as_inner(), &addr as *const _ as *const _, len))?;
Ok(UnixStream(inner))
}
}
inner(path.as_ref())
}
/// Creates an unnamed pair of connected sockets.
///