bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Smaller span for unnessary mut suggestion

Browse source
This commit is contained in:
Esteban Küber 2023-11-06 19:47:38 +00:00
parent ae20897b30
commit 1c6bd0b12b
6 changed files with 12 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

3
compiler/rustc_parse/src/errors.rs
View file

@ -2278,9 +2278,8 @@ pub(crate) enum InvalidMutInPattern {
#[note(parse_note_mut_pattern_usage)]
NonIdent {
#[primary_span]
#[suggestion(code = "{pat}", applicability = "machine-applicable")]
#[suggestion(code = "", applicability = "machine-applicable")]
span: Span,
pat: String,
},
}

10
compiler/rustc_parse/src/parser/pat.rs
View file

@ -638,13 +638,13 @@ impl<'a> Parser<'a> {
/// Error on `mut $pat` where `$pat` is not an ident.
fn ban_mut_general_pat(&self, lo: Span, pat: &Pat, changed_any_binding: bool) {
let span = lo.to(pat.span);
let pat = pprust::pat_to_string(&pat);
self.sess.emit_err(if changed_any_binding {
InvalidMutInPattern::NestedIdent { span, pat }
InvalidMutInPattern::NestedIdent {
span: lo.to(pat.span),
pat: pprust::pat_to_string(&pat),
}
} else {
InvalidMutInPattern::NonIdent { span, pat }
InvalidMutInPattern::NonIdent { span: lo.until(pat.span) }
});
}