bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Get allow(unused_mut) to work on let bindings

Browse source 
fixes #40491
This commit is contained in:
Oliver Schneider 2017-09-15 10:36:14 +02:00
parent d86a7f7a78
commit 1b571a0cfc
No known key found for this signature in database
GPG key ID: A69F8D225B3AD7D9
2 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/librustc_lint/unused.rs
View file

@ -85,20 +85,12 @@ impl LintPass for UnusedMut {
}
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UnusedMut {
fn check_expr(&mut self, cx: &LateContext, e: &hir::Expr) {
if let hir::ExprMatch(_, ref arms, _) = e.node {
for a in arms {
self.check_unused_mut_pat(cx, &a.pats)
}
}
fn check_arm(&mut self, cx: &LateContext, a: &hir::Arm) {
self.check_unused_mut_pat(cx, &a.pats)
}
fn check_stmt(&mut self, cx: &LateContext, s: &hir::Stmt) {
if let hir::StmtDecl(ref d, _) = s.node {
if let hir::DeclLocal(ref l) = d.node {
self.check_unused_mut_pat(cx, slice::ref_slice(&l.pat));
}
}
fn check_local(&mut self, cx: &LateContext, l: &hir::Local) {
self.check_unused_mut_pat(cx, slice::ref_slice(&l.pat));
}
fn check_fn(&mut self,

8
src/test/compile-fail/lint-unused-mut-variables.rs
View file

@ -110,3 +110,11 @@ fn foo(mut a: isize) {
let mut a = 3;
let mut b = vec![2];
}
// make sure the lint attribute can be turned off on let statements
#[deny(unused_mut)]
fn bar() {
#[allow(unused_mut)]
let mut a = 3;
let mut b = vec![2]; //~ ERROR: variable does not need to be mutable
}