Add coercions from *mut to *const and from &mut to *const.
This commit is contained in:
parent
872ba2ccd3
commit
19eb4bf0b2
3 changed files with 64 additions and 4 deletions
|
@ -549,17 +549,18 @@ impl<'f, 'tcx> Coerce<'f, 'tcx> {
|
||||||
b.repr(self.get_ref().infcx.tcx));
|
b.repr(self.get_ref().infcx.tcx));
|
||||||
|
|
||||||
let mt_a = match *sty_a {
|
let mt_a = match *sty_a {
|
||||||
ty::ty_rptr(_, mt) => mt,
|
ty::ty_rptr(_, mt) | ty::ty_ptr(mt) => mt,
|
||||||
_ => {
|
_ => {
|
||||||
return self.subtype(a, b);
|
return self.subtype(a, b);
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
// Check that the types which they point at are compatible.
|
// Check that the types which they point at are compatible.
|
||||||
// Note that we don't adjust the mutability here. We cannot change
|
let a_unsafe = ty::mk_ptr(self.get_ref().infcx.tcx, ty::mt{ mutbl: mutbl_b, ty: mt_a.ty });
|
||||||
// the mutability and the kind of pointer in a single coercion.
|
|
||||||
let a_unsafe = ty::mk_ptr(self.get_ref().infcx.tcx, mt_a);
|
|
||||||
try!(self.subtype(a_unsafe, b));
|
try!(self.subtype(a_unsafe, b));
|
||||||
|
if !can_coerce_mutbls(mt_a.mutbl, mutbl_b) {
|
||||||
|
return Err(ty::terr_mutability);
|
||||||
|
}
|
||||||
|
|
||||||
// Although references and unsafe ptrs have the same
|
// Although references and unsafe ptrs have the same
|
||||||
// representation, we still register an AutoDerefRef so that
|
// representation, we still register an AutoDerefRef so that
|
||||||
|
|
24
src/test/compile-fail/ptr-coercion.rs
Normal file
24
src/test/compile-fail/ptr-coercion.rs
Normal file
|
@ -0,0 +1,24 @@
|
||||||
|
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
|
||||||
|
// file at the top-level directory of this distribution and at
|
||||||
|
// http://rust-lang.org/COPYRIGHT.
|
||||||
|
//
|
||||||
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
||||||
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
||||||
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
||||||
|
// option. This file may not be copied, modified, or distributed
|
||||||
|
// except according to those terms.
|
||||||
|
|
||||||
|
// Test coercions between pointers which don't do anything fancy like unsizing.
|
||||||
|
// These are testing that we don't lose mutability when converting to raw pointers.
|
||||||
|
|
||||||
|
pub fn main() {
|
||||||
|
// *const -> *mut
|
||||||
|
let x: *const int = &42i;
|
||||||
|
let x: *mut int = x; //~ERROR values differ in mutability
|
||||||
|
|
||||||
|
// & -> *mut
|
||||||
|
let x: *mut int = &42; //~ERROR values differ in mutability
|
||||||
|
|
||||||
|
let x: *const int = &42;
|
||||||
|
let x: *mut int = x; //~ERROR values differ in mutability
|
||||||
|
}
|
35
src/test/run-pass/ptr-coercion.rs
Normal file
35
src/test/run-pass/ptr-coercion.rs
Normal file
|
@ -0,0 +1,35 @@
|
||||||
|
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
|
||||||
|
// file at the top-level directory of this distribution and at
|
||||||
|
// http://rust-lang.org/COPYRIGHT.
|
||||||
|
//
|
||||||
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
||||||
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
||||||
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
||||||
|
// option. This file may not be copied, modified, or distributed
|
||||||
|
// except according to those terms.
|
||||||
|
|
||||||
|
// Test coercions between pointers which don't do anything fancy like unsizing.
|
||||||
|
|
||||||
|
pub fn main() {
|
||||||
|
// &mut -> &
|
||||||
|
let x: &mut int = &mut 42i;
|
||||||
|
let x: &int = x;
|
||||||
|
|
||||||
|
let x: &int = &mut 42i;
|
||||||
|
|
||||||
|
// & -> *const
|
||||||
|
let x: &int = &42i;
|
||||||
|
let x: *const int = x;
|
||||||
|
|
||||||
|
let x: *const int = &42i;
|
||||||
|
|
||||||
|
// &mut -> *const
|
||||||
|
let x: &mut int = &mut 42i;
|
||||||
|
let x: *const int = x;
|
||||||
|
|
||||||
|
let x: *const int = &mut 42i;
|
||||||
|
|
||||||
|
// *mut -> *const
|
||||||
|
let x: *mut int = &mut 42i;
|
||||||
|
let x: *const int = x;
|
||||||
|
}
|
Loading…
Add table
Add a link
Reference in a new issue