bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

rustc: Further tweak linkage in ThinLTO

Browse source 
In #46382 the logic around linkage preservation with ThinLTO ws tweaked but the
loop that registered all otherwise exported GUID values as "don't internalize
me please" was erroneously too conservative and only asking "external" linkage
items to not be internalized. Instead we actually want the inversion of that
condition, everything *without* "local" linkage to be internalized.

This commit updates the condition there, adds a test, and...

Closes #46543
This commit is contained in:
Alex Crichton 2017-12-06 17:59:33 -08:00
parent 833785b090
commit 17fb43bdc6
2 changed files with 38 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/rustllvm/PassWrapper.cpp
View file

@ -970,7 +970,7 @@ LLVMRustCreateThinLTOData(LLVMRustThinLTOModule *modules,
std::set<GlobalValue::GUID> ExportedGUIDs;
for (auto &List : Ret->Index) {
for (auto &GVS: List.second) {
if (!GlobalValue::isExternalLinkage(GVS->linkage()))
if (GlobalValue::isLocalLinkage(GVS->linkage()))
continue;
auto GUID = GVS->getOriginalName();
if (!DeadSymbols.count(GUID))