bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #123841 - Kohei316:remove_qualifier_sugg, r=wesleywiser

Browse source 
Improve diagnostic by suggesting to remove visibility qualifier

Resolves #123529
This PR improve diagnostic by suggesting to remove visibility qualifier.
This commit is contained in:
Matthias Krüger 2024-04-12 17:41:35 +02:00 • committed by GitHub
commit 15a8b490ea
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
19 changed files with 77 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

6
compiler/rustc_ast_passes/src/ast_validation.rs
View file

@ -266,7 +266,11 @@ impl<'a> AstValidator<'a> {
return;
}
self.dcx().emit_err(errors::VisibilityNotPermitted { span: vis.span, note });
self.dcx().emit_err(errors::VisibilityNotPermitted {
span: vis.span,
note,
remove_qualifier_sugg: vis.span,
});
}
fn check_decl_no_pat(decl: &FnDecl, mut report_err: impl FnMut(Span, Option<Ident>, bool)) {

6
compiler/rustc_ast_passes/src/errors.rs
View file

@ -31,6 +31,12 @@ pub struct VisibilityNotPermitted {
pub span: Span,
#[subdiagnostic]
pub note: VisibilityNotPermittedNote,
#[suggestion(
ast_passes_remove_qualifier_sugg,
code = "",
applicability = "machine-applicable"
)]
pub remove_qualifier_sugg: Span,
}
#[derive(Subdiagnostic)]