bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Deprecate the after_crate_root_parsing callback

Browse source 
Several custom drivers are incorrectly calling queries.global_ctxt()
from inside of it, which causes some driver code to be skipped. As such
I would like to either remove it in the future or if custom drivers
still need it, change it to accept an &rustc_ast::Crate instead.
This commit is contained in:
bjorn3 2024-10-31 16:34:16 +00:00
parent 3b02a3309e
commit 159ba4ceab
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_driver_impl/src/lib.rs
View file

@ -159,6 +159,9 @@ pub trait Callbacks {
/// Called after parsing the crate root. Submodules are not yet parsed when /// Called after parsing the crate root. Submodules are not yet parsed when
/// this callback is called. Return value instructs the compiler whether to /// this callback is called. Return value instructs the compiler whether to
/// continue the compilation afterwards (defaults to `Compilation::Continue`) /// continue the compilation afterwards (defaults to `Compilation::Continue`)
#[deprecated = "This callback will likely be removed or stop giving access \
to the TyCtxt in the future. Use either the after_expansion \
or the after_analysis callback instead."]
fn after_crate_root_parsing<'tcx>( fn after_crate_root_parsing<'tcx>(
&mut self, &mut self,
_compiler: &interface::Compiler, _compiler: &interface::Compiler,
@ -409,6 +412,7 @@ fn run_compiler(
return early_exit(); return early_exit();
} }
#[allow(deprecated)]
if callbacks.after_crate_root_parsing(compiler, queries) == Compilation::Stop { if callbacks.after_crate_root_parsing(compiler, queries) == Compilation::Stop {
return early_exit(); return early_exit();
} }