bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

rustdoc: make notable traits popover behavior consistent with Help and Settings

Browse source
This commit is contained in:
Michael Howell 2022-11-08 17:59:03 -07:00
parent 89ba71649f
commit 155750dc33
2 changed files with 37 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/librustdoc/html/static/js/main.js
View file

@ -897,7 +897,15 @@ function loadCss(cssUrl) {
!elemIsInParent(document.activeElement, window.CURRENT_NOTABLE_ELEMENT.NOTABLE_BASE) &&
!elemIsInParent(event.relatedTarget, window.CURRENT_NOTABLE_ELEMENT.NOTABLE_BASE)
) {
hideNotable();
// Work around a difference in the focus behaviour between Firefox, Chrome, and Safari.
// When I click the button on an already-opened notable trait popover, Safari
// hides the popover and then immediately shows it again, while everyone else hides it
// and it stays hidden.
//
// To work around this, make sure the click finishes being dispatched before
// hiding the popover. Since `hideNotable()` is idempotent, this makes Safari behave
// consistently with the other two.
setTimeout(hideNotable, 0);
}
}