bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

rustdoc: change aliases attribute to data-aliases

Browse source 
The "aliases" attribute is not listed [on MDN], so it sounds like
it's rustdoc-specific. We don't want to conflict with any attributes
that are added to the spec in the future.

[on MDN]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements
This commit is contained in:
Michael Howell 2021-04-27 15:47:49 -07:00
parent 20040fa332
commit 153eb72d65
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/librustdoc/html/render/mod.rs
View file

@ -1546,7 +1546,7 @@ fn render_impl(
let aliases = if aliases.is_empty() { let aliases = if aliases.is_empty() {
String::new() String::new()
} else { } else {
format!(" aliases=\"{}\"", aliases.join(",")) format!(" data-aliases=\"{}\"", aliases.join(","))
}; };
if let Some(use_absolute) = use_absolute { if let Some(use_absolute) = use_absolute {
write!( write!(

2
src/librustdoc/html/static/main.js
View file

@ -834,7 +834,7 @@ function hideThemeButtonState() {
// (like "Send" and "Sync"). // (like "Send" and "Sync").
var inlined_types = new Set(); var inlined_types = new Set();
onEachLazy(synthetic_implementors.getElementsByClassName("impl"), function(el) { onEachLazy(synthetic_implementors.getElementsByClassName("impl"), function(el) {
var aliases = el.getAttribute("aliases"); var aliases = el.getAttribute("data-aliases");
if (!aliases) { if (!aliases) {
return; return;
} }