bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Un-unsafe the StableOrd trait

Browse source 
Whilst incorrect implementations of this trait can cause miscompilation,
they cannot cause memory unsafety in rustc.
This commit is contained in:
Alan Egerton 2024-06-12 13:01:22 +01:00
parent 02c7a5921e
commit 114dd2061e
No known key found for this signature in database
GPG key ID: 7D4C2F6C22122532
6 changed files with 26 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_query_system/src/dep_graph/dep_node.rs
View file

@ -301,7 +301,7 @@ impl<HCX> ToStableHashKey<HCX> for WorkProductId {
self.hash
}
}
unsafe impl StableOrd for WorkProductId {
impl StableOrd for WorkProductId {
// Fingerprint can use unstable (just a tuple of `u64`s), so WorkProductId can as well
const CAN_USE_UNSTABLE_SORT: bool = true;
}