bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Un-unsafe the StableOrd trait

Browse source 
Whilst incorrect implementations of this trait can cause miscompilation,
they cannot cause memory unsafety in rustc.
This commit is contained in:
Alan Egerton 2024-06-12 13:01:22 +01:00
parent 02c7a5921e
commit 114dd2061e
No known key found for this signature in database
GPG key ID: 7D4C2F6C22122532
6 changed files with 26 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_hir/src/hir_id.rs
View file

@ -165,9 +165,9 @@ impl ItemLocalId {
pub const INVALID: ItemLocalId = ItemLocalId::MAX;
}
// Safety: Ord is implement as just comparing the ItemLocalId's numerical
// Ord is implement as just comparing the ItemLocalId's numerical
// values and these are not changed by (de-)serialization.
unsafe impl StableOrd for ItemLocalId {
impl StableOrd for ItemLocalId {
const CAN_USE_UNSTABLE_SORT: bool = true;
}