bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Support pub on macro_rules

Browse source
This commit is contained in:
Vadim Petrochenkov 2020-10-21 00:46:29 +03:00 • committed by Santiago Pastorino
parent 25a2c13e9d
commit 0fddc2f780
No known key found for this signature in database
GPG key ID: 8131A24E0C79EFAF
14 changed files with 183 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

9
compiler/rustc_resolve/src/build_reduced_graph.rs
View file

@ -1230,13 +1230,13 @@ impl<'a, 'b> BuildReducedGraphVisitor<'a, 'b> {
};
let res = Res::Def(DefKind::Macro(ext.macro_kind()), def_id.to_def_id());
let is_macro_export = self.r.session.contains_name(&item.attrs, sym::macro_export);
self.r.macro_map.insert(def_id.to_def_id(), ext);
self.r.local_macro_def_scopes.insert(def_id, parent_scope.module);
if macro_rules {
if macro_rules && matches!(item.vis.kind, ast::VisibilityKind::Inherited) {
let ident = ident.normalize_to_macros_2_0();
self.r.macro_names.insert(ident);
let is_macro_export = self.r.session.contains_name(&item.attrs, sym::macro_export);
let vis = if is_macro_export {
ty::Visibility::Public
} else {
@ -1261,6 +1261,11 @@ impl<'a, 'b> BuildReducedGraphVisitor<'a, 'b> {
}),
))
} else {
if is_macro_export {
let what = if macro_rules { "`macro_rules` with `pub`" } else { "`macro` items" };
let msg = format!("`#[macro_export]` cannot be used on {what}");
self.r.session.span_err(item.span, &msg);
}
let module = parent_scope.module;
let vis = match item.kind {
// Visibilities must not be resolved non-speculatively twice