bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Remove E0551.

Browse source 
Because it's the same as E0539.

Fixes #51489.
This commit is contained in:
Nicholas Nethercote 2023-10-04 17:20:15 +11:00
parent 81136cb391
commit 0ece171c2f
4 changed files with 9 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_attr/src/builtin.rs
View file

@ -846,7 +846,7 @@ pub fn find_deprecation(
), ),
); );
} else { } else {
sess.emit_err(session_diagnostics::IncorrectMetaItem2 { sess.emit_err(session_diagnostics::IncorrectMetaItem {
span: meta.span, span: meta.span,
}); });
} }

9
compiler/rustc_attr/src/session_diagnostics.rs
View file

@ -165,15 +165,6 @@ pub(crate) struct MissingIssue {
pub span: Span, pub span: Span,
} }
// FIXME: This diagnostic is identical to `IncorrectMetaItem`, barring the error code. Consider
// changing this to `IncorrectMetaItem`. See #51489.
#[derive(Diagnostic)]
#[diag(attr_incorrect_meta_item, code = "E0551")]
pub(crate) struct IncorrectMetaItem2 {
#[primary_span]
pub span: Span,
}
// FIXME: Why is this the same error code as `InvalidReprHintNoParen` and `InvalidReprHintNoValue`? // FIXME: Why is this the same error code as `InvalidReprHintNoParen` and `InvalidReprHintNoValue`?
// It is more similar to `IncorrectReprFormatGeneric`. // It is more similar to `IncorrectReprFormatGeneric`.
#[derive(Diagnostic)] #[derive(Diagnostic)]

4
compiler/rustc_error_codes/src/error_codes/E0551.md
View file

@ -1,8 +1,10 @@
#### Note: this error code is no longer emitted by the compiler
An invalid meta-item was used inside an attribute. An invalid meta-item was used inside an attribute.
Erroneous code example: Erroneous code example:
```compile_fail,E0551 ```compile_fail,E0539
#[deprecated(note)] // error! #[deprecated(note)] // error!
fn i_am_deprecated() {} fn i_am_deprecated() {}
``` ```

10
tests/ui/deprecation/deprecation-sanity.stderr
View file

@ -16,25 +16,25 @@ error[E0541]: unknown meta item 'reason'
LL | #[deprecated(since = "a", note = "a", reason)] LL | #[deprecated(since = "a", note = "a", reason)]
| ^^^^^^ expected one of `since`, `note` | ^^^^^^ expected one of `since`, `note`
error[E0551]: incorrect meta item error[E0539]: incorrect meta item
--> $DIR/deprecation-sanity.rs:7:31 --> $DIR/deprecation-sanity.rs:7:31
| |
LL | #[deprecated(since = "a", note)] LL | #[deprecated(since = "a", note)]
| ^^^^ | ^^^^
error[E0551]: incorrect meta item error[E0539]: incorrect meta item
--> $DIR/deprecation-sanity.rs:10:18 --> $DIR/deprecation-sanity.rs:10:18
| |
LL | #[deprecated(since, note = "a")] LL | #[deprecated(since, note = "a")]
| ^^^^^ | ^^^^^
error[E0551]: incorrect meta item error[E0539]: incorrect meta item
--> $DIR/deprecation-sanity.rs:13:31 --> $DIR/deprecation-sanity.rs:13:31
| |
LL | #[deprecated(since = "a", note(b))] LL | #[deprecated(since = "a", note(b))]
| ^^^^^^^ | ^^^^^^^
error[E0551]: incorrect meta item error[E0539]: incorrect meta item
--> $DIR/deprecation-sanity.rs:16:18 --> $DIR/deprecation-sanity.rs:16:18
| |
LL | #[deprecated(since(b), note = "a")] LL | #[deprecated(since(b), note = "a")]
@ -70,5 +70,5 @@ LL | #[deprecated = "hello"]
error: aborting due to 10 previous errors error: aborting due to 10 previous errors
Some errors have detailed explanations: E0538, E0541, E0551, E0565. Some errors have detailed explanations: E0538, E0539, E0541, E0565.
For more information about an error, try `rustc --explain E0538`. For more information about an error, try `rustc --explain E0538`.