bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Ensure careful consideration is given by impls

Browse source 
Added an associated `const THIS_IMPLEMENTATION_HAS_BEEN_TRIPLE_CHECKED`
to the `StableOrd` trait to ensure that implementors carefully consider
whether the trait's contract is upheld, as incorrect implementations can
cause miscompilations.
This commit is contained in:
Alan Egerton 2024-06-22 07:11:42 +01:00
parent 114dd2061e
commit 0e73e7095a
No known key found for this signature in database
GPG key ID: 7D4C2F6C22122532
6 changed files with 60 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

6
compiler/rustc_abi/src/lib.rs
View file

@ -425,11 +425,13 @@ pub struct Size {
raw: u64,
}
// Ord is implement as just comparing numerical values and numerical values
// are not changed by (de-)serialization.
#[cfg(feature = "nightly")]
impl StableOrd for Size {
const CAN_USE_UNSTABLE_SORT: bool = true;
// `Ord` is implemented as just comparing numerical values and numerical values
// are not changed by (de-)serialization.
const THIS_IMPLEMENTATION_HAS_BEEN_TRIPLE_CHECKED: () = ();
}
// This is debug-printed a lot in larger structs, don't waste too much space there