bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Prevent #[doc(alias = "...")] at crate level

Browse source
This commit is contained in:
Guillaume Gomez 2020-09-04 17:12:53 +02:00
parent 738d4a7a36
commit 0e68e1ba5c
2 changed files with 19 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_hir/src/target.rs
View file

@ -9,13 +9,13 @@ use crate::{Item, ItemKind, TraitItem, TraitItemKind};
use std::fmt::{self, Display}; use std::fmt::{self, Display};
#[derive(Copy, Clone, PartialEq)] #[derive(Copy, Clone, PartialEq, Debug)]
pub enum MethodKind { pub enum MethodKind {
Trait { body: bool }, Trait { body: bool },
Inherent, Inherent,
} }
#[derive(Copy, Clone, PartialEq)] #[derive(Copy, Clone, PartialEq, Debug)]
pub enum Target { pub enum Target {
ExternCrate, ExternCrate,
Use, Use,

18
compiler/rustc_passes/src/check_attr.rs
View file

@ -13,7 +13,7 @@ use rustc_errors::{pluralize, struct_span_err};
use rustc_hir as hir; use rustc_hir as hir;
use rustc_hir::def_id::LocalDefId; use rustc_hir::def_id::LocalDefId;
use rustc_hir::intravisit::{self, NestedVisitorMap, Visitor}; use rustc_hir::intravisit::{self, NestedVisitorMap, Visitor};
use rustc_hir::{self, FnSig, ForeignItem, ForeignItemKind, HirId, Item, ItemKind, TraitItem}; use rustc_hir::{self, FnSig, ForeignItem, ForeignItemKind, HirId, Item, ItemKind, TraitItem, CRATE_HIR_ID};
use rustc_hir::{MethodKind, Target}; use rustc_hir::{MethodKind, Target};
use rustc_session::lint::builtin::{CONFLICTING_REPR_HINTS, UNUSED_ATTRIBUTES}; use rustc_session::lint::builtin::{CONFLICTING_REPR_HINTS, UNUSED_ATTRIBUTES};
use rustc_session::parse::feature_err; use rustc_session::parse::feature_err;
@ -333,6 +333,17 @@ impl CheckAttrVisitor<'tcx> {
.emit(); .emit();
return false; return false;
} }
if CRATE_HIR_ID == hir_id {
self.tcx
.sess
.struct_span_err(
meta.span(),
"`#![doc(alias = \"...\")]` isn't allowed as a crate \
level attribute",
)
.emit();
return false;
}
} }
} }
} }
@ -811,6 +822,11 @@ fn is_c_like_enum(item: &Item<'_>) -> bool {
fn check_mod_attrs(tcx: TyCtxt<'_>, module_def_id: LocalDefId) { fn check_mod_attrs(tcx: TyCtxt<'_>, module_def_id: LocalDefId) {
tcx.hir() tcx.hir()
.visit_item_likes_in_module(module_def_id, &mut CheckAttrVisitor { tcx }.as_deep_visitor()); .visit_item_likes_in_module(module_def_id, &mut CheckAttrVisitor { tcx }.as_deep_visitor());
if module_def_id.is_top_level_module() {
for attr in tcx.hir().krate_attrs() {
CheckAttrVisitor { tcx }.check_doc_alias(attr, CRATE_HIR_ID, Target::Mod);
}
}
} }
pub(crate) fn provide(providers: &mut Providers) { pub(crate) fn provide(providers: &mut Providers) {