bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Deny #[deprecated] on trait impl blocks.

Browse source 
They have no effect there, but were silently accepted.
This commit is contained in:
Mara Bos 2020-10-31 15:34:10 +01:00
parent b202532608
commit 0e2337a5d6
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
compiler/rustc_passes/src/stability.rs
View file

@ -31,6 +31,8 @@ enum AnnotationKind {
Required, Required,
// Annotation is useless, reject it // Annotation is useless, reject it
Prohibited, Prohibited,
// Deprecation annotation is useless, reject it. (Stability attribute is still required.)
DeprecationProhibited,
// Annotation itself is useless, but it can be propagated to children // Annotation itself is useless, but it can be propagated to children
Container, Container,
} }
@ -89,7 +91,7 @@ impl<'a, 'tcx> Annotator<'a, 'tcx> {
if let Some(depr) = &depr { if let Some(depr) = &depr {
is_deprecated = true; is_deprecated = true;
if kind == AnnotationKind::Prohibited { if kind == AnnotationKind::Prohibited || kind == AnnotationKind::DeprecationProhibited {
self.tcx.sess.span_err(item_sp, "This deprecation annotation is useless"); self.tcx.sess.span_err(item_sp, "This deprecation annotation is useless");
} }
@ -322,6 +324,7 @@ impl<'a, 'tcx> Visitor<'tcx> for Annotator<'a, 'tcx> {
} }
hir::ItemKind::Impl { of_trait: Some(_), .. } => { hir::ItemKind::Impl { of_trait: Some(_), .. } => {
self.in_trait_impl = true; self.in_trait_impl = true;
kind = AnnotationKind::DeprecationProhibited;
} }
hir::ItemKind::Struct(ref sd, _) => { hir::ItemKind::Struct(ref sd, _) => {
if let Some(ctor_hir_id) = sd.ctor_hir_id() { if let Some(ctor_hir_id) = sd.ctor_hir_id() {