bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Check for use of mutable/extern statics in THIR unsafeck

Browse source
This commit is contained in:
LeSeulArtichaut 2021-05-17 00:29:54 +02:00
parent 6b327aaa08
commit 0e1afc4501
26 changed files with 238 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

16
compiler/rustc_mir_build/src/check_unsafety.rs
View file

@ -169,14 +169,20 @@ impl<'a, 'tcx> Visitor<'a, 'tcx> for UnsafetyVisitor<'a, 'tcx> {
}
}
}
ExprKind::InlineAsm { .. } | ExprKind::LlvmInlineAsm { .. } => {
self.requires_unsafe(expr.span, UseOfInlineAssembly);
}
ExprKind::Deref { arg } => {
if self.thir[arg].ty.is_unsafe_ptr() {
if let ExprKind::StaticRef { def_id, .. } = self.thir[arg].kind {
if self.tcx.is_mutable_static(def_id) {
self.requires_unsafe(expr.span, UseOfMutableStatic);
} else if self.tcx.is_foreign_item(def_id) {
self.requires_unsafe(expr.span, UseOfExternStatic);
}
} else if self.thir[arg].ty.is_unsafe_ptr() {
self.requires_unsafe(expr.span, DerefOfRawPointer);
}
}
ExprKind::InlineAsm { .. } | ExprKind::LlvmInlineAsm { .. } => {
self.requires_unsafe(expr.span, UseOfInlineAssembly);
}
ExprKind::Adt {
adt_def,
variant_index: _,
@ -242,9 +248,7 @@ enum UnsafeOpKind {
UseOfInlineAssembly,
InitializingTypeWith,
CastOfPointerToInt,
#[allow(dead_code)] // FIXME
UseOfMutableStatic,
#[allow(dead_code)] // FIXME
UseOfExternStatic,
DerefOfRawPointer,
#[allow(dead_code)] // FIXME