bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

respond to review feedback: mainly eliminate as many conversions as possible...

Browse source 
- ... when creating diagnostics in rustc_metadata
-  use the error_code! macro
- pass macro output to diag.code()
- use fluent from within manual implementation of SessionDiagnostic
- emit the untested errors in case they occur in the wild
- stop panicking in the probably-not-dead code, add fixme to write test
This commit is contained in:
Nathan Stocks 2022-08-26 14:39:59 -06:00
parent d0ba1fbaa4
commit 0d65819d52
11 changed files with 234 additions and 226 deletions
Download patch file Download diff file Expand all files Collapse all files

18
compiler/rustc_metadata/src/native_libs.rs
View file

@ -124,7 +124,7 @@ impl<'tcx> Collector<'tcx> {
NativeLibKind::RawDylib
}
kind => {
sess.emit_err(UnknownLinkKind { span, kind: kind.to_string() });
sess.emit_err(UnknownLinkKind { span, kind });
continue;
}
};
@ -249,10 +249,7 @@ impl<'tcx> Collector<'tcx> {
}
let assign_modifier = |dst: &mut Option<bool>| {
if dst.is_some() {
sess.emit_err(MultipleModifiers {
span,
modifier: modifier.to_string(),
});
sess.emit_err(MultipleModifiers { span, modifier });
} else {
*dst = Some(value);
}
@ -287,10 +284,7 @@ impl<'tcx> Collector<'tcx> {
}
_ => {
sess.emit_err(UnknownLinkModifier {
span,
modifier: modifier.to_string(),
});
sess.emit_err(UnknownLinkModifier { span, modifier });
}
}
}
@ -379,11 +373,11 @@ impl<'tcx> Collector<'tcx> {
.filter_map(|lib| lib.name.as_ref())
.any(|n| n.as_str() == lib.name);
if new_name.is_empty() {
self.tcx.sess.emit_err(EmptyRenamingTarget { lib_name: lib.name.clone() });
self.tcx.sess.emit_err(EmptyRenamingTarget { lib_name: &lib.name });
} else if !any_duplicate {
self.tcx.sess.emit_err(RenamingNoLink { lib_name: lib.name.clone() });
self.tcx.sess.emit_err(RenamingNoLink { lib_name: &lib.name });
} else if !renames.insert(&lib.name) {
self.tcx.sess.emit_err(MultipleRenamings { lib_name: lib.name.clone() });
self.tcx.sess.emit_err(MultipleRenamings { lib_name: &lib.name });
}
}
}