bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

rustdoc: Fix incorrect usage of @!has and @!matches

Browse source 
`@!has` (and `@!matches`) with two arguments used to treat the second
argument as a literal string of HTML code. Now, that feature has been
renamed into `@!hasraw` (and `@!matchesraw`), and the arity-2 `@!has`
version is an error.

These uses thought the second argument was being treated as an XPath, as
with the arity-3 version, but in fact was being treated as literal HTML.
Because these were checking for the *absence* of the string, the tests
silently did nothing -- an XPath string won't ever be showing up in the
test's generated HTML!
This commit is contained in:
Noah Lev 2022-08-13 00:56:16 -04:00
parent b34e2404fd
commit 0d588e928e
11 changed files with 24 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/test/rustdoc/tuple-struct-fields-doc.rs
View file

@ -5,7 +5,7 @@
// @has - '//h3[@class="sidebar-title"]/a[@href="#fields"]' 'Tuple Fields'
// @has - '//*[@id="structfield.0"]' '0: u32'
// @has - '//*[@id="main-content"]/div[@class="docblock"]' 'hello'
// @!hasraw - '//*[@id="structfield.1"]'
// @!has - '//*[@id="structfield.1"]' ''
// @has - '//*[@id="structfield.2"]' '2: char'
// @has - '//*[@id="structfield.3"]' '3: i8'
// @has - '//*[@id="main-content"]/div[@class="docblock"]' 'not hello'