bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

needed_ref -> needs_ref

Browse source
This commit is contained in:
Samuel E. Moelius III 2022-07-29 17:46:09 -04:00 • committed by Samuel Moelius
parent 687fcf14c4
commit 0bc26c811c
1 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
clippy_lints/src/format_args.rs
View file

@ -137,12 +137,8 @@ fn check_to_string_in_format_args(cx: &LateContext<'_>, name: Symbol, value: &Ex
if let Some(sized_trait_id) = cx.tcx.lang_items().sized_trait();
if let Some(receiver_snippet) = snippet_opt(cx, receiver.span);
then {
let needed_ref = if implements_trait(cx, receiver_ty, sized_trait_id, &[]) {
""
} else {
"&"
};
if n_needed_derefs == 0 && needed_ref.is_empty() {
let needs_ref = !implements_trait(cx, receiver_ty, sized_trait_id, &[]);
if n_needed_derefs == 0 && !needs_ref {
span_lint_and_sugg(
cx,
TO_STRING_IN_FORMAT_ARGS,
@ -167,7 +163,7 @@ fn check_to_string_in_format_args(cx: &LateContext<'_>, name: Symbol, value: &Ex
"use this",
format!(
"{}{:*>width$}{}",
needed_ref,
if needs_ref { "&" } else { "" },
"",
receiver_snippet,
width = n_needed_derefs