bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

remove some uses of visit_all_item_likes in incremental, metadata and interface crates

Browse source 
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
This commit is contained in:
Miguel Guarniz 2022-04-06 19:04:15 -04:00
parent b73b4de982
commit 0baf85e8b6
6 changed files with 64 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

13
compiler/rustc_metadata/src/foreign_modules.rs
View file

@ -4,9 +4,16 @@ use rustc_middle::ty::TyCtxt;
use rustc_session::cstore::ForeignModule;
crate fn collect(tcx: TyCtxt<'_>) -> Vec<ForeignModule> {
let mut collector = Collector { modules: Vec::new() };
tcx.hir().visit_all_item_likes(&mut collector);
collector.modules
let mut modules = Vec::new();
for id in tcx.hir().items() {
let item = tcx.hir().item(id);
let hir::ItemKind::ForeignMod { items, .. } = item.kind else {
continue;
};
let foreign_items = items.iter().map(|it| it.id.def_id.to_def_id()).collect();
modules.push(ForeignModule { foreign_items, def_id: id.def_id.to_def_id() });
}
modules
}
struct Collector {

5
compiler/rustc_metadata/src/native_libs.rs
View file

@ -15,7 +15,10 @@ use rustc_target::spec::abi::Abi;
crate fn collect(tcx: TyCtxt<'_>) -> Vec<NativeLib> {
let mut collector = Collector { tcx, libs: Vec::new() };
tcx.hir().visit_all_item_likes(&mut collector);
for id in tcx.hir().items() {
let item = tcx.hir().item(id);
collector.visit_item(item);
}
collector.process_command_line();
collector.libs
}

6
compiler/rustc_metadata/src/rmeta/encoder.rs
View file

@ -1784,7 +1784,11 @@ impl<'a, 'tcx> EncodeContext<'a, 'tcx> {
empty_proc_macro!(self);
let tcx = self.tcx;
let mut visitor = ImplsVisitor { tcx, impls: FxHashMap::default() };
tcx.hir().visit_all_item_likes(&mut visitor);
for id in tcx.hir().items() {
let item = tcx.hir().item(id);
visitor.visit_item(item);
}
let mut all_impls: Vec<_> = visitor.impls.into_iter().collect();