bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Add check to only output 'you might have meant' when the candidate name is in the same crate

Browse source
This commit is contained in:
Byron Zhong 2022-10-25 12:35:04 -05:00
parent be61f0237b
commit 0b936d2da7
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
compiler/rustc_resolve/src/late/diagnostics.rs
View file

@ -691,7 +691,8 @@ impl<'a: 'ast, 'ast> LateResolutionVisitor<'a, '_, 'ast> {
let is_expected = &|res| source.is_expected(res);
let ident_span = path.last().map_or(span, |ident| ident.ident.span);
let typo_sugg = self.lookup_typo_candidate(path, source.namespace(), is_expected);
if let TypoCandidate::Shadowed(res, Some(sugg_span)) = typo_sugg {
let is_local = &|res: Res| res.opt_def_id().map_or(false, |id| id.is_local());
if let TypoCandidate::Shadowed(res, Some(sugg_span)) = typo_sugg && is_local(res) {
err.span_label(
sugg_span,
format!("you might have meant to refer to this {}", res.descr()),