bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Always include global target features in function attributes

Browse source 
This ensures that information about target features configured with
`-C target-feature=...` or detected with `-C target-cpu=native` is
retained for subsequent consumers of LLVM bitcode.

This is crucial for linker plugin LTO, since this information is not
conveyed to the plugin otherwise.
This commit is contained in:
Tomasz Miąsko 2022-03-03 00:00:00 +00:00
parent b6f845f225
commit 095d818e0c
2 changed files with 9 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

13
compiler/rustc_codegen_llvm/src/attributes.rs
View file

@ -378,13 +378,12 @@ pub fn from_fn_attrs<'ll, 'tcx>(
}
}
if !function_features.is_empty() {
let global_features = cx.tcx.global_backend_features(()).iter().map(|s| &s[..]);
let val = global_features
.chain(function_features.iter().map(|s| &s[..]))
.intersperse(",")
.collect::<SmallStr<1024>>();
to_add.push(llvm::CreateAttrStringValue(cx.llcx, "target-features", &val));
let global_features = cx.tcx.global_backend_features(()).iter().map(|s| s.as_str());
let function_features = function_features.iter().map(|s| s.as_str());
let target_features =
global_features.chain(function_features).intersperse(",").collect::<SmallStr<1024>>();
if !target_features.is_empty() {
to_add.push(llvm::CreateAttrStringValue(cx.llcx, "target-features", &target_features));
}
attributes::apply_to_llfn(llfn, Function, &to_add);