bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Rollup merge of #97458 - estebank:use-self-in-derive-macro, r=compiler-errors

Browse source 
Modify `derive(Debug)` to use `Self` in struct literal to avoid redundant error

Reduce verbosity in #97343.
This commit is contained in:
Matthias Krüger 2022-05-28 01:11:50 +02:00 • committed by GitHub
commit 0804ef6563
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 24 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_builtin_macros/src/deriving/generic/mod.rs
View file

@ -1039,7 +1039,9 @@ impl<'a> MethodDef<'a> {
let span = trait_.span;
let mut patterns = Vec::new();
for i in 0..self_args.len() {
let struct_path = cx.path(span, vec![type_ident]);
// We could use `type_ident` instead of `Self`, but in the case of a type parameter
// shadowing the struct name, that causes a second, unnecessary E0578 error. #97343
let struct_path = cx.path(span, vec![Ident::new(kw::SelfUpper, type_ident.span)]);
let (pat, ident_expr) = trait_.create_struct_pattern(
cx,
struct_path,