bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Remove special casing of rustdoc in rustc_lint

Browse source 
This is no longer necessary now that rustdoc doesn't run
everybody_loops.
This commit is contained in:
Joshua Nelson 2021-01-22 14:50:21 -05:00
parent 65767e5653
commit 0679a4cd93
1 changed files with 3 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

14
compiler/rustc_lint/src/early.rs
View file

@ -379,17 +379,9 @@ pub fn check_ast_crate<T: EarlyLintPass>(
// All of the buffered lints should have been emitted at this point. // All of the buffered lints should have been emitted at this point.
// If not, that means that we somehow buffered a lint for a node id // If not, that means that we somehow buffered a lint for a node id
// that was not lint-checked (perhaps it doesn't exist?). This is a bug. // that was not lint-checked (perhaps it doesn't exist?). This is a bug.
// for (_id, lints) in buffered.map {
// Rustdoc runs everybody-loops before the early lints and removes for early_lint in lints {
// function bodies, so it's totally possible for linted sess.delay_span_bug(early_lint.span, "failed to process buffered lint here");
// node ids to not exist (e.g., macros defined within functions for the
// unused_macro lint) anymore. So we only run this check
// when we're not in rustdoc mode. (see issue #47639)
if !sess.opts.actually_rustdoc {
for (_id, lints) in buffered.map {
for early_lint in lints {
sess.delay_span_bug(early_lint.span, "failed to process buffered lint here");
}
} }
} }
} }