bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity

Make PackedFingerprint's Fingerprint private

Browse source
This commit is contained in:
Tyson Nottingham 2020-11-18 15:10:43 -08:00
parent f09d474836
commit 05dde137ca
4 changed files with 25 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

19
compiler/rustc_data_structures/src/fingerprint.rs
View file

@ -170,9 +170,12 @@ impl FingerprintDecoder for opaque::Decoder<'_> {
// `DepNode`s. As of this writing, the size of a `DepNode` decreases by ~30%
// (from 24 bytes to 17) by using the packed representation here, which
// noticeably decreases total memory usage when compiling large crates.
//
// The wrapped `Fingerprint` is private to reduce the chance of a client
// invoking undefined behavior by taking a reference to the packed field.
#[cfg_attr(any(target_arch = "x86", target_arch = "x86_64"), repr(packed))]
#[derive(Eq, PartialEq, Ord, PartialOrd, Debug, Clone, Copy, Hash)]
pub struct PackedFingerprint(pub Fingerprint);
pub struct PackedFingerprint(Fingerprint);
impl std::fmt::Display for PackedFingerprint {
#[inline]
@ -198,3 +201,17 @@ impl<D: rustc_serialize::Decoder> Decodable<D> for PackedFingerprint {
Fingerprint::decode(d).map(|f| PackedFingerprint(f))
}
}
impl From<Fingerprint> for PackedFingerprint {
#[inline]
fn from(f: Fingerprint) -> PackedFingerprint {
PackedFingerprint(f)
}
}
impl From<PackedFingerprint> for Fingerprint {
#[inline]
fn from(f: PackedFingerprint) -> Fingerprint {
f.0
}
}