bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Use substrings instead of split to grab enum variant paths

Browse source 
Both versions are about equally readable, but this version avoids scanning
the entire path and building an intermediate array (`split()` in Rust is
a lazy iterator, but not in JavaScript).
This commit is contained in:
Michael Howell 2021-03-05 11:20:31 -07:00
parent 8fd946c63a
commit 0571bc4263
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/librustdoc/html/static/main.js
View file

@ -1548,9 +1548,9 @@ function defocusSearchBar() {
} else if (type === "structfield" && parentType === "variant") { } else if (type === "structfield" && parentType === "variant") {
// Structfields belonging to variants are special: the // Structfields belonging to variants are special: the
// final path element is the enum name. // final path element is the enum name.
var splitPath = item.path.split("::"); var enumNameIdx = item.path.lastIndexOf("::");
var enumName = splitPath.pop(); var enumName = item.path.substr(enumNameIdx + 2);
path = splitPath.join("::"); path = item.path.substr(0, enumNameIdx);
displayPath = path + "::" + enumName + "::" + myparent.name + "::"; displayPath = path + "::" + enumName + "::" + myparent.name + "::";
anchor = "#variant." + myparent.name + ".field." + name; anchor = "#variant." + myparent.name + ".field." + name;
pageType = "enum"; pageType = "enum";