bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

feature gate doc(primitive)

Browse source
This commit is contained in:
Joshua Nelson 2021-07-10 22:06:10 -04:00
parent 2bd17c1d43
commit 03df65497e
9 changed files with 49 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
compiler/rustc_feature/src/active.rs
View file

@ -682,6 +682,9 @@ declare_features! (
/// Allows explicit generic arguments specification with `impl Trait` present.
(active, explicit_generic_args_with_impl_trait, "1.56.0", Some(83701), None),
/// Allows using doc(primitive) without a future-incompat warning
(active, doc_primitive, "1.56.0", Some(88070), None),
// -------------------------------------------------------------------------
// feature-group-end: actual feature gates
// -------------------------------------------------------------------------

17
compiler/rustc_passes/src/check_attr.rs
View file

@ -794,9 +794,24 @@ impl CheckAttrVisitor<'tcx> {
| sym::notable_trait
| sym::passes
| sym::plugins
| sym::primitive
| sym::test => {}
sym::primitive => {
if !self.tcx.features().doc_primitive {
self.tcx.struct_span_lint_hir(
INVALID_DOC_ATTRIBUTES,
hir_id,
i_meta.span,
|lint| {
let mut diag = lint.build(
"`doc(primitive)` should never have been stable",
);
diag.emit();
},
);
}
}
_ => {
self.tcx.struct_span_lint_hir(
INVALID_DOC_ATTRIBUTES,

1
compiler/rustc_span/src/symbol.rs
View file

@ -513,6 +513,7 @@ symbols! {
doc_keyword,
doc_masked,
doc_notable_trait,
doc_primitive,
doc_spotlight,
doctest,
document_private_items,