Rollup merge of #106242 - estebank:diff-markers, r=jyn514
Detect diff markers in the parser Partly address #32059.
This commit is contained in:
commit
031a2143f0
26 changed files with 438 additions and 5 deletions
|
@ -31,7 +31,8 @@ use rustc_ast::{
|
|||
use rustc_ast_pretty::pprust;
|
||||
use rustc_data_structures::fx::FxHashSet;
|
||||
use rustc_errors::{
|
||||
fluent, Applicability, DiagnosticBuilder, DiagnosticMessage, Handler, MultiSpan, PResult,
|
||||
fluent, Applicability, DiagnosticBuilder, DiagnosticMessage, FatalError, Handler, MultiSpan,
|
||||
PResult,
|
||||
};
|
||||
use rustc_errors::{pluralize, Diagnostic, ErrorGuaranteed, IntoDiagnostic};
|
||||
use rustc_session::errors::ExprParenthesesNeeded;
|
||||
|
@ -2556,6 +2557,75 @@ impl<'a> Parser<'a> {
|
|||
Ok(())
|
||||
}
|
||||
|
||||
pub fn is_diff_marker(&mut self, long_kind: &TokenKind, short_kind: &TokenKind) -> bool {
|
||||
(0..3).all(|i| self.look_ahead(i, |tok| tok == long_kind))
|
||||
&& self.look_ahead(3, |tok| tok == short_kind)
|
||||
}
|
||||
|
||||
fn diff_marker(&mut self, long_kind: &TokenKind, short_kind: &TokenKind) -> Option<Span> {
|
||||
if self.is_diff_marker(long_kind, short_kind) {
|
||||
let lo = self.token.span;
|
||||
for _ in 0..4 {
|
||||
self.bump();
|
||||
}
|
||||
return Some(lo.to(self.prev_token.span));
|
||||
}
|
||||
None
|
||||
}
|
||||
|
||||
pub fn recover_diff_marker(&mut self) {
|
||||
let Some(start) = self.diff_marker(&TokenKind::BinOp(token::Shl), &TokenKind::Lt) else {
|
||||
return;
|
||||
};
|
||||
let mut spans = Vec::with_capacity(3);
|
||||
spans.push(start);
|
||||
let mut middlediff3 = None;
|
||||
let mut middle = None;
|
||||
let mut end = None;
|
||||
loop {
|
||||
if self.token.kind == TokenKind::Eof {
|
||||
break;
|
||||
}
|
||||
if let Some(span) = self.diff_marker(&TokenKind::OrOr, &TokenKind::BinOp(token::Or)) {
|
||||
middlediff3 = Some(span);
|
||||
}
|
||||
if let Some(span) = self.diff_marker(&TokenKind::EqEq, &TokenKind::Eq) {
|
||||
middle = Some(span);
|
||||
}
|
||||
if let Some(span) = self.diff_marker(&TokenKind::BinOp(token::Shr), &TokenKind::Gt) {
|
||||
spans.push(span);
|
||||
end = Some(span);
|
||||
break;
|
||||
}
|
||||
self.bump();
|
||||
}
|
||||
let mut err = self.struct_span_err(spans, "encountered diff marker");
|
||||
err.span_label(start, "after this is the code before the merge");
|
||||
if let Some(middle) = middlediff3 {
|
||||
err.span_label(middle, "");
|
||||
}
|
||||
if let Some(middle) = middle {
|
||||
err.span_label(middle, "");
|
||||
}
|
||||
if let Some(end) = end {
|
||||
err.span_label(end, "above this are the incoming code changes");
|
||||
}
|
||||
err.help(
|
||||
"if you're having merge conflicts after pulling new code, the top section is the code \
|
||||
you already had and the bottom section is the remote code",
|
||||
);
|
||||
err.help(
|
||||
"if you're in the middle of a rebase, the top section is the code being rebased onto \
|
||||
and the bottom section is the code coming from the current commit being rebased",
|
||||
);
|
||||
err.note(
|
||||
"for an explanation on these markers from the `git` documentation, visit \
|
||||
<https://git-scm.com/book/en/v2/Git-Tools-Advanced-Merging#_checking_out_conflicts>",
|
||||
);
|
||||
err.emit();
|
||||
FatalError.raise()
|
||||
}
|
||||
|
||||
/// Parse and throw away a parenthesized comma separated
|
||||
/// sequence of patterns until `)` is reached.
|
||||
fn skip_pat_list(&mut self) -> PResult<'a, ()> {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue