bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Auto merge of #75888 - GuillaumeGomez:trait-impl-assoc-const-doc-alias, r=ollie27

Browse source 
Add check for doc alias on assoc const in trait impl

Fixes #73721.

r? @ollie27
This commit is contained in:
bors 2020-09-05 09:35:17 +00:00
commit 02fe30971e
3 changed files with 41 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
compiler/rustc_passes/src/check_attr.rs
View file

@ -250,13 +250,23 @@ impl CheckAttrVisitor<'tcx> {
None
}
}
Target::AssocConst => {
let parent_hir_id = self.tcx.hir().get_parent_item(hir_id);
let containing_item = self.tcx.hir().expect_item(parent_hir_id);
// We can't link to trait impl's consts.
let err = "associated constant in trait implementation block";
match containing_item.kind {
ItemKind::Impl { of_trait: Some(_), .. } => Some(err),
_ => None,
}
}
_ => None,
} {
self.tcx
.sess
.struct_span_err(
meta.span(),
&format!("`#[doc(alias = \"...\")]` isn't allowed on {}", err,),
&format!("`#[doc(alias = \"...\")]` isn't allowed on {}", err),
)
.emit();
}