1
Fork 0

Pass arguments up to 2*usize by value

This commit is contained in:
Erik Desjardins 2020-11-29 19:49:41 -05:00
parent 88b81970ba
commit 0183b4109a
3 changed files with 17 additions and 12 deletions

View file

@ -2818,7 +2818,7 @@ where
|| abi == SpecAbi::RustIntrinsic
|| abi == SpecAbi::PlatformIntrinsic
{
let fixup = |arg: &mut ArgAbi<'tcx, Ty<'tcx>>, is_ret: bool| {
let fixup = |arg: &mut ArgAbi<'tcx, Ty<'tcx>>| {
if arg.is_ignore() {
return;
}
@ -2856,9 +2856,9 @@ where
_ => return,
}
// Return structures up to 2 pointers in size by value, matching `ScalarPair`. LLVM
// will usually return these in 2 registers, which is more efficient than by-ref.
let max_by_val_size = if is_ret { Pointer.size(cx) * 2 } else { Pointer.size(cx) };
// Pass and return structures up to 2 pointers in size by value, matching `ScalarPair`.
// LLVM will usually pass these in 2 registers, which is more efficient than by-ref.
let max_by_val_size = Pointer.size(cx) * 2;
let size = arg.layout.size;
if arg.layout.is_unsized() || size > max_by_val_size {
@ -2870,9 +2870,9 @@ where
arg.cast_to(Reg { kind: RegKind::Integer, size });
}
};
fixup(&mut self.ret, true);
fixup(&mut self.ret);
for arg in &mut self.args {
fixup(arg, false);
fixup(arg);
}
return;
}