2014-06-06 15:49:48 -07:00
|
|
|
|
//! Implementation of lint checking.
|
|
|
|
|
//!
|
2018-05-08 16:10:16 +03:00
|
|
|
|
//! The lint checking is mostly consolidated into one pass which runs
|
|
|
|
|
//! after all other analyses. Throughout compilation, lint warnings
|
2014-06-06 15:49:48 -07:00
|
|
|
|
//! can be added via the `add_lint` method on the Session structure. This
|
2019-02-08 14:53:55 +01:00
|
|
|
|
//! requires a span and an ID of the node that the lint is being added to. The
|
2014-06-06 15:49:48 -07:00
|
|
|
|
//! lint isn't actually emitted at that time because it is unknown what the
|
|
|
|
|
//! actual lint level at that location is.
|
|
|
|
|
//!
|
2018-05-08 16:10:16 +03:00
|
|
|
|
//! To actually emit lint warnings/errors, a separate pass is used.
|
|
|
|
|
//! A context keeps track of the current state of all lint levels.
|
2014-06-06 15:49:48 -07:00
|
|
|
|
//! Upon entering a node of the ast which can modify the lint settings, the
|
|
|
|
|
//! previous lint state is pushed onto a stack and the ast is then recursed
|
2019-02-08 14:53:55 +01:00
|
|
|
|
//! upon. As the ast is traversed, this keeps track of the current lint level
|
2014-06-06 15:49:48 -07:00
|
|
|
|
//! for all lint attributes.
|
2017-07-26 21:51:09 -07:00
|
|
|
|
|
2014-11-06 00:05:53 -08:00
|
|
|
|
use self::TargetLint::*;
|
2014-06-06 15:49:48 -07:00
|
|
|
|
|
2021-09-29 01:17:54 +03:00
|
|
|
|
use crate::levels::LintLevelsBuilder;
|
2020-01-09 07:52:01 +01:00
|
|
|
|
use crate::passes::{EarlyLintPassObject, LateLintPassObject};
|
2021-09-29 01:17:54 +03:00
|
|
|
|
use rustc_ast::util::unicode::TEXT_FLOW_CONTROL_CHARS;
|
2019-12-24 05:02:53 +01:00
|
|
|
|
use rustc_data_structures::fx::FxHashMap;
|
2019-12-30 14:22:46 +01:00
|
|
|
|
use rustc_data_structures::sync;
|
2021-12-11 00:56:21 +01:00
|
|
|
|
use rustc_errors::{struct_span_err, Applicability, SuggestionStyle};
|
2020-01-05 02:37:57 +01:00
|
|
|
|
use rustc_hir as hir;
|
2020-06-26 05:55:23 +03:00
|
|
|
|
use rustc_hir::def::Res;
|
2020-01-05 02:37:57 +01:00
|
|
|
|
use rustc_hir::def_id::{CrateNum, DefId};
|
2020-09-01 13:11:28 +01:00
|
|
|
|
use rustc_hir::definitions::{DefPathData, DisambiguatedDefPathData};
|
2020-03-29 16:41:09 +02:00
|
|
|
|
use rustc_middle::lint::LintDiagnosticBuilder;
|
|
|
|
|
use rustc_middle::middle::privacy::AccessLevels;
|
|
|
|
|
use rustc_middle::middle::stability;
|
2021-08-30 20:37:36 +03:00
|
|
|
|
use rustc_middle::ty::layout::{LayoutError, LayoutOfHelpers, TyAndLayout};
|
2020-09-02 10:40:56 +03:00
|
|
|
|
use rustc_middle::ty::print::with_no_trimmed_paths;
|
2021-09-29 01:17:54 +03:00
|
|
|
|
use rustc_middle::ty::{self, print::Printer, subst::GenericArg, RegisteredTools, Ty, TyCtxt};
|
2020-05-25 16:21:25 -07:00
|
|
|
|
use rustc_serialize::json::Json;
|
|
|
|
|
use rustc_session::lint::{BuiltinLintDiagnostics, ExternDepSpec};
|
2020-01-05 09:40:16 +01:00
|
|
|
|
use rustc_session::lint::{FutureIncompatibleInfo, Level, Lint, LintBuffer, LintId};
|
2020-01-05 10:58:44 +01:00
|
|
|
|
use rustc_session::Session;
|
Move lev_distance to rustc_ast, make non-generic
rustc_ast currently has a few dependencies on rustc_lexer. Ideally, an AST
would not have any dependency its lexer, for minimizing unnecessarily
design-time dependencies. Breaking this dependency would also have practical
benefits, since modifying rustc_lexer would not trigger a rebuild of rustc_ast.
This commit does not remove the rustc_ast --> rustc_lexer dependency,
but it does remove one of the sources of this dependency, which is the
code that handles fuzzy matching between symbol names for making suggestions
in diagnostics. Since that code depends only on Symbol, it is easy to move
it to rustc_span. It might even be best to move it to a separate crate,
since other tools such as Cargo use the same algorithm, and have simply
contain a duplicate of the code.
This changes the signature of find_best_match_for_name so that it is no
longer generic over its input. I checked the optimized binaries, and this
function was duplicated at nearly every call site, because most call sites
used short-lived iterator chains, generic over Map and such. But there's
no good reason for a function like this to be generic, since all it does
is immediately convert the generic input (the Iterator impl) to a concrete
Vec<Symbol>. This has all of the costs of generics (duplicated method bodies)
with no benefit.
Changing find_best_match_for_name to be non-generic removed about 10KB of
code from the optimized binary. I know it's a drop in the bucket, but we have
to start reducing binary size, and beginning to tame over-use of generics
is part of that.
2020-11-12 11:24:10 -08:00
|
|
|
|
use rustc_span::lev_distance::find_best_match_for_name;
|
2021-09-29 01:17:54 +03:00
|
|
|
|
use rustc_span::symbol::{sym, Ident, Symbol};
|
|
|
|
|
use rustc_span::{BytePos, MultiSpan, Span, DUMMY_SP};
|
2021-08-30 17:38:27 +03:00
|
|
|
|
use rustc_target::abi;
|
2021-01-29 19:06:00 -05:00
|
|
|
|
use tracing::debug;
|
2014-06-06 15:49:48 -07:00
|
|
|
|
|
2020-06-26 02:56:23 +03:00
|
|
|
|
use std::cell::Cell;
|
2021-03-08 15:32:41 -08:00
|
|
|
|
use std::iter;
|
2019-12-31 21:25:16 +01:00
|
|
|
|
use std::slice;
|
2019-11-11 22:46:56 +01:00
|
|
|
|
|
2014-06-06 15:49:48 -07:00
|
|
|
|
/// Information about the registered lints.
|
|
|
|
|
///
|
|
|
|
|
/// This is basically the subset of `Context` that we can
|
|
|
|
|
/// build early in the compile pipeline.
|
|
|
|
|
pub struct LintStore {
|
2019-11-30 11:31:25 +03:00
|
|
|
|
/// Registered lints.
|
2019-10-07 16:52:53 -04:00
|
|
|
|
lints: Vec<&'static Lint>,
|
2014-06-06 15:49:48 -07:00
|
|
|
|
|
2019-10-07 18:23:16 -04:00
|
|
|
|
/// Constructor functions for each variety of lint pass.
|
|
|
|
|
///
|
|
|
|
|
/// These should only be called once, but since we want to avoid locks or
|
|
|
|
|
/// interior mutability, we don't enforce this (and lints should, in theory,
|
|
|
|
|
/// be compatible with being constructed more than once, though not
|
|
|
|
|
/// necessarily in a sane manner. This is safe though.)
|
2019-12-30 14:11:49 +01:00
|
|
|
|
pub pre_expansion_passes: Vec<Box<dyn Fn() -> EarlyLintPassObject + sync::Send + sync::Sync>>,
|
|
|
|
|
pub early_passes: Vec<Box<dyn Fn() -> EarlyLintPassObject + sync::Send + sync::Sync>>,
|
2019-12-30 14:22:46 +01:00
|
|
|
|
pub late_passes: Vec<Box<dyn Fn() -> LateLintPassObject + sync::Send + sync::Sync>>,
|
2019-10-07 18:23:16 -04:00
|
|
|
|
/// This is unique in that we construct them per-module, so not once.
|
2019-12-30 14:22:46 +01:00
|
|
|
|
pub late_module_passes: Vec<Box<dyn Fn() -> LateLintPassObject + sync::Send + sync::Sync>>,
|
2014-06-06 15:49:48 -07:00
|
|
|
|
|
|
|
|
|
/// Lints indexed by name.
|
2016-11-08 14:02:55 +11:00
|
|
|
|
by_name: FxHashMap<String, TargetLint>,
|
2014-06-06 15:49:48 -07:00
|
|
|
|
|
2018-09-15 17:32:24 +01:00
|
|
|
|
/// Map of registered lint groups to what lints they expand to.
|
|
|
|
|
lint_groups: FxHashMap<&'static str, LintGroup>,
|
2017-05-16 03:16:18 +08:00
|
|
|
|
}
|
|
|
|
|
|
2017-08-15 21:45:21 +02:00
|
|
|
|
/// The target of the `by_name` map, which accounts for renaming/deprecation.
|
2020-12-29 23:16:16 -05:00
|
|
|
|
#[derive(Debug)]
|
2014-10-14 11:32:31 -07:00
|
|
|
|
enum TargetLint {
|
|
|
|
|
/// A direct lint target
|
|
|
|
|
Id(LintId),
|
|
|
|
|
|
|
|
|
|
/// Temporary renaming, used for easing migration pain; see #16545
|
|
|
|
|
Renamed(String, LintId),
|
2015-07-15 20:12:30 +03:00
|
|
|
|
|
|
|
|
|
/// Lint with this name existed previously, but has been removed/deprecated.
|
|
|
|
|
/// The string argument is the reason for removal.
|
|
|
|
|
Removed(String),
|
2021-03-16 11:59:05 -04:00
|
|
|
|
|
|
|
|
|
/// A lint name that should give no warnings and have no effect.
|
|
|
|
|
///
|
|
|
|
|
/// This is used by rustc to avoid warning about old rustdoc lints before rustdoc registers them as tool lints.
|
|
|
|
|
Ignored,
|
2015-07-15 20:12:30 +03:00
|
|
|
|
}
|
|
|
|
|
|
2017-07-26 21:51:09 -07:00
|
|
|
|
pub enum FindLintError {
|
2015-07-15 20:12:30 +03:00
|
|
|
|
NotFound,
|
2017-03-13 02:12:13 +02:00
|
|
|
|
Removed,
|
2014-10-14 11:32:31 -07:00
|
|
|
|
}
|
|
|
|
|
|
2018-09-15 17:32:24 +01:00
|
|
|
|
struct LintAlias {
|
|
|
|
|
name: &'static str,
|
|
|
|
|
/// Whether deprecation warnings should be suppressed for this alias.
|
|
|
|
|
silent: bool,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
struct LintGroup {
|
|
|
|
|
lint_ids: Vec<LintId>,
|
|
|
|
|
from_plugin: bool,
|
|
|
|
|
depr: Option<LintAlias>,
|
|
|
|
|
}
|
|
|
|
|
|
2017-07-26 21:51:09 -07:00
|
|
|
|
pub enum CheckLintNameResult<'a> {
|
|
|
|
|
Ok(&'a [LintId]),
|
2018-12-19 13:51:52 -05:00
|
|
|
|
/// Lint doesn't exist. Potentially contains a suggestion for a correct lint name.
|
|
|
|
|
NoLint(Option<Symbol>),
|
2021-07-06 17:19:20 -07:00
|
|
|
|
/// The lint refers to a tool that has not been registered.
|
|
|
|
|
NoTool,
|
2017-08-17 16:15:40 +02:00
|
|
|
|
/// The lint is either renamed or removed. This is the warning
|
2018-07-14 20:52:40 -07:00
|
|
|
|
/// message, and an optional new name (`None` if removed).
|
|
|
|
|
Warning(String, Option<String>),
|
2018-07-30 11:29:23 +02:00
|
|
|
|
/// The lint is from a tool. If the Option is None, then either
|
|
|
|
|
/// the lint does not exist in the tool or the code was not
|
|
|
|
|
/// compiled with the tool and therefore the lint was never
|
|
|
|
|
/// added to the `LintStore`. Otherwise the `LintId` will be
|
|
|
|
|
/// returned as if it where a rustc lint.
|
2018-08-27 23:25:31 +02:00
|
|
|
|
Tool(Result<&'a [LintId], (Option<&'a [LintId]>, String)>),
|
2017-07-26 21:51:09 -07:00
|
|
|
|
}
|
|
|
|
|
|
2014-06-06 15:49:48 -07:00
|
|
|
|
impl LintStore {
|
|
|
|
|
pub fn new() -> LintStore {
|
|
|
|
|
LintStore {
|
2016-10-29 22:54:04 +01:00
|
|
|
|
lints: vec![],
|
2019-10-07 18:23:16 -04:00
|
|
|
|
pre_expansion_passes: vec![],
|
|
|
|
|
early_passes: vec![],
|
|
|
|
|
late_passes: vec![],
|
2019-01-31 04:36:37 +01:00
|
|
|
|
late_module_passes: vec![],
|
2018-10-16 16:57:53 +02:00
|
|
|
|
by_name: Default::default(),
|
|
|
|
|
lint_groups: Default::default(),
|
2014-06-06 15:49:48 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-10-07 16:52:53 -04:00
|
|
|
|
pub fn get_lints<'t>(&'t self) -> &'t [&'static Lint] {
|
2015-02-20 14:08:14 -05:00
|
|
|
|
&self.lints
|
2014-06-06 15:49:48 -07:00
|
|
|
|
}
|
|
|
|
|
|
2022-01-05 13:02:16 +01:00
|
|
|
|
pub fn get_lint_groups<'t>(
|
|
|
|
|
&'t self,
|
|
|
|
|
) -> impl Iterator<Item = (&'static str, Vec<LintId>, bool)> + 't {
|
|
|
|
|
// This function is not used in a way which observes the order of lints.
|
2022-02-23 08:06:22 -05:00
|
|
|
|
#[allow(rustc::potential_query_instability)]
|
2019-12-22 17:42:04 -05:00
|
|
|
|
self.lint_groups
|
|
|
|
|
.iter()
|
2018-09-15 17:32:24 +01:00
|
|
|
|
.filter(|(_, LintGroup { depr, .. })| {
|
|
|
|
|
// Don't display deprecated lint groups.
|
|
|
|
|
depr.is_none()
|
|
|
|
|
})
|
|
|
|
|
.map(|(k, LintGroup { lint_ids, from_plugin, .. })| {
|
|
|
|
|
(*k, lint_ids.clone(), *from_plugin)
|
|
|
|
|
})
|
2014-07-21 15:27:59 +12:00
|
|
|
|
}
|
|
|
|
|
|
2019-10-22 16:53:28 -04:00
|
|
|
|
pub fn register_early_pass(
|
|
|
|
|
&mut self,
|
2019-12-22 17:42:04 -05:00
|
|
|
|
pass: impl Fn() -> EarlyLintPassObject + 'static + sync::Send + sync::Sync,
|
2019-10-22 16:53:28 -04:00
|
|
|
|
) {
|
2019-10-10 19:33:00 -04:00
|
|
|
|
self.early_passes.push(Box::new(pass));
|
2015-09-15 11:35:25 +12:00
|
|
|
|
}
|
|
|
|
|
|
2021-03-16 01:50:34 -04:00
|
|
|
|
/// Used by clippy.
|
2019-10-22 16:53:28 -04:00
|
|
|
|
pub fn register_pre_expansion_pass(
|
|
|
|
|
&mut self,
|
|
|
|
|
pass: impl Fn() -> EarlyLintPassObject + 'static + sync::Send + sync::Sync,
|
|
|
|
|
) {
|
2019-10-10 19:33:00 -04:00
|
|
|
|
self.pre_expansion_passes.push(Box::new(pass));
|
2018-07-14 16:40:17 +02:00
|
|
|
|
}
|
|
|
|
|
|
2019-10-22 16:53:28 -04:00
|
|
|
|
pub fn register_late_pass(
|
|
|
|
|
&mut self,
|
|
|
|
|
pass: impl Fn() -> LateLintPassObject + 'static + sync::Send + sync::Sync,
|
|
|
|
|
) {
|
2019-10-10 19:33:00 -04:00
|
|
|
|
self.late_passes.push(Box::new(pass));
|
2019-10-07 16:59:12 -04:00
|
|
|
|
}
|
|
|
|
|
|
2019-10-22 16:53:28 -04:00
|
|
|
|
pub fn register_late_mod_pass(
|
|
|
|
|
&mut self,
|
|
|
|
|
pass: impl Fn() -> LateLintPassObject + 'static + sync::Send + sync::Sync,
|
|
|
|
|
) {
|
2019-10-10 19:33:00 -04:00
|
|
|
|
self.late_module_passes.push(Box::new(pass));
|
2015-09-15 11:35:25 +12:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Helper method for register_early/late_pass
|
2019-10-07 17:21:50 -04:00
|
|
|
|
pub fn register_lints(&mut self, lints: &[&'static Lint]) {
|
2019-09-24 18:24:45 -04:00
|
|
|
|
for lint in lints {
|
2019-10-07 16:52:53 -04:00
|
|
|
|
self.lints.push(lint);
|
2014-06-06 15:49:48 -07:00
|
|
|
|
|
2018-06-21 09:04:50 +02:00
|
|
|
|
let id = LintId::of(lint);
|
2014-11-06 12:25:16 -05:00
|
|
|
|
if self.by_name.insert(lint.name_lower(), Id(id)).is_some() {
|
2019-09-23 20:13:02 -04:00
|
|
|
|
bug!("duplicate specification of lint {}", lint.name_lower())
|
2014-06-06 15:49:48 -07:00
|
|
|
|
}
|
|
|
|
|
|
2021-06-15 17:16:21 +02:00
|
|
|
|
if let Some(FutureIncompatibleInfo { reason, .. }) = lint.future_incompatible {
|
|
|
|
|
if let Some(edition) = reason.edition() {
|
2019-12-22 17:42:04 -05:00
|
|
|
|
self.lint_groups
|
|
|
|
|
.entry(edition.lint_name())
|
2019-10-08 21:49:21 -04:00
|
|
|
|
.or_insert(LintGroup {
|
|
|
|
|
lint_ids: vec![],
|
|
|
|
|
from_plugin: lint.is_plugin,
|
|
|
|
|
depr: None,
|
|
|
|
|
})
|
2019-12-22 17:42:04 -05:00
|
|
|
|
.lint_ids
|
|
|
|
|
.push(id);
|
2021-06-24 16:29:03 +02:00
|
|
|
|
} else {
|
2021-06-28 17:42:27 +02:00
|
|
|
|
// Lints belonging to the `future_incompatible` lint group are lints where a
|
|
|
|
|
// future version of rustc will cause existing code to stop compiling.
|
|
|
|
|
// Lints tied to an edition don't count because they are opt-in.
|
2021-06-24 16:29:03 +02:00
|
|
|
|
self.lint_groups
|
|
|
|
|
.entry("future_incompatible")
|
|
|
|
|
.or_insert(LintGroup {
|
|
|
|
|
lint_ids: vec![],
|
|
|
|
|
from_plugin: lint.is_plugin,
|
|
|
|
|
depr: None,
|
|
|
|
|
})
|
|
|
|
|
.lint_ids
|
|
|
|
|
.push(id);
|
2019-10-08 21:49:21 -04:00
|
|
|
|
}
|
2018-02-22 16:51:42 -08:00
|
|
|
|
}
|
|
|
|
|
}
|
2016-01-08 17:53:44 -05:00
|
|
|
|
}
|
|
|
|
|
|
2019-12-22 17:42:04 -05:00
|
|
|
|
pub fn register_group_alias(&mut self, lint_name: &'static str, alias: &'static str) {
|
|
|
|
|
self.lint_groups.insert(
|
|
|
|
|
alias,
|
|
|
|
|
LintGroup {
|
|
|
|
|
lint_ids: vec![],
|
|
|
|
|
from_plugin: false,
|
|
|
|
|
depr: Some(LintAlias { name: lint_name, silent: true }),
|
|
|
|
|
},
|
|
|
|
|
);
|
2018-09-15 15:26:45 +01:00
|
|
|
|
}
|
|
|
|
|
|
2018-08-27 23:24:42 +02:00
|
|
|
|
pub fn register_group(
|
|
|
|
|
&mut self,
|
|
|
|
|
from_plugin: bool,
|
|
|
|
|
name: &'static str,
|
|
|
|
|
deprecated_name: Option<&'static str>,
|
|
|
|
|
to: Vec<LintId>,
|
|
|
|
|
) {
|
|
|
|
|
let new = self
|
|
|
|
|
.lint_groups
|
2019-12-22 17:42:04 -05:00
|
|
|
|
.insert(name, LintGroup { lint_ids: to, from_plugin, depr: None })
|
2018-08-27 23:24:42 +02:00
|
|
|
|
.is_none();
|
|
|
|
|
if let Some(deprecated) = deprecated_name {
|
2019-12-22 17:42:04 -05:00
|
|
|
|
self.lint_groups.insert(
|
|
|
|
|
deprecated,
|
|
|
|
|
LintGroup {
|
|
|
|
|
lint_ids: vec![],
|
|
|
|
|
from_plugin,
|
|
|
|
|
depr: Some(LintAlias { name, silent: false }),
|
|
|
|
|
},
|
|
|
|
|
);
|
2018-08-27 23:24:42 +02:00
|
|
|
|
}
|
2014-07-21 15:27:59 +12:00
|
|
|
|
|
|
|
|
|
if !new {
|
2019-09-23 20:13:02 -04:00
|
|
|
|
bug!("duplicate specification of lint group {}", name);
|
2014-07-21 15:27:59 +12:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2021-03-16 11:59:05 -04:00
|
|
|
|
/// This lint should give no warning and have no effect.
|
|
|
|
|
///
|
|
|
|
|
/// This is used by rustc to avoid warning about old rustdoc lints before rustdoc registers them as tool lints.
|
|
|
|
|
#[track_caller]
|
|
|
|
|
pub fn register_ignored(&mut self, name: &str) {
|
|
|
|
|
if self.by_name.insert(name.to_string(), Ignored).is_some() {
|
|
|
|
|
bug!("duplicate specification of lint {}", name);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// This lint has been renamed; warn about using the new name and apply the lint.
|
2020-12-29 23:16:40 -05:00
|
|
|
|
#[track_caller]
|
2015-02-25 22:44:44 +11:00
|
|
|
|
pub fn register_renamed(&mut self, old_name: &str, new_name: &str) {
|
2022-02-19 00:48:49 +01:00
|
|
|
|
let Some(&Id(target)) = self.by_name.get(new_name) else {
|
|
|
|
|
bug!("invalid lint renaming of {} to {}", old_name, new_name);
|
2014-10-14 11:32:31 -07:00
|
|
|
|
};
|
|
|
|
|
self.by_name.insert(old_name.to_string(), Renamed(new_name.to_string(), target));
|
|
|
|
|
}
|
|
|
|
|
|
2015-07-15 20:12:30 +03:00
|
|
|
|
pub fn register_removed(&mut self, name: &str, reason: &str) {
|
|
|
|
|
self.by_name.insert(name.into(), Removed(reason.into()));
|
|
|
|
|
}
|
|
|
|
|
|
2018-09-15 17:05:52 +01:00
|
|
|
|
pub fn find_lints(&self, mut lint_name: &str) -> Result<Vec<LintId>, FindLintError> {
|
2014-11-12 15:51:51 -08:00
|
|
|
|
match self.by_name.get(lint_name) {
|
2017-07-26 21:51:09 -07:00
|
|
|
|
Some(&Id(lint_id)) => Ok(vec![lint_id]),
|
2019-12-22 17:42:04 -05:00
|
|
|
|
Some(&Renamed(_, lint_id)) => Ok(vec![lint_id]),
|
|
|
|
|
Some(&Removed(_)) => Err(FindLintError::Removed),
|
2021-03-16 11:59:05 -04:00
|
|
|
|
Some(&Ignored) => Ok(vec![]),
|
2019-12-22 17:42:04 -05:00
|
|
|
|
None => loop {
|
|
|
|
|
return match self.lint_groups.get(lint_name) {
|
|
|
|
|
Some(LintGroup { lint_ids, depr, .. }) => {
|
|
|
|
|
if let Some(LintAlias { name, .. }) = depr {
|
|
|
|
|
lint_name = name;
|
|
|
|
|
continue;
|
2018-09-15 17:05:52 +01:00
|
|
|
|
}
|
2019-12-22 17:42:04 -05:00
|
|
|
|
Ok(lint_ids.clone())
|
|
|
|
|
}
|
|
|
|
|
None => Err(FindLintError::Removed),
|
|
|
|
|
};
|
|
|
|
|
},
|
2014-06-06 15:49:48 -07:00
|
|
|
|
}
|
2017-05-16 03:16:18 +08:00
|
|
|
|
}
|
|
|
|
|
|
2021-07-06 17:19:20 -07:00
|
|
|
|
/// Checks the validity of lint names derived from the command line.
|
2021-06-24 16:38:32 -07:00
|
|
|
|
pub fn check_lint_name_cmdline(
|
|
|
|
|
&self,
|
|
|
|
|
sess: &Session,
|
|
|
|
|
lint_name: &str,
|
2021-07-06 17:19:20 -07:00
|
|
|
|
level: Level,
|
2021-09-29 01:17:54 +03:00
|
|
|
|
registered_tools: &RegisteredTools,
|
2021-07-06 17:19:20 -07:00
|
|
|
|
) {
|
2021-07-07 10:50:50 -07:00
|
|
|
|
let (tool_name, lint_name_only) = parse_lint_and_tool_name(lint_name);
|
2021-08-18 11:53:59 +02:00
|
|
|
|
if lint_name_only == crate::WARNINGS.name_lower() && level == Level::ForceWarn {
|
2022-01-27 09:44:25 +00:00
|
|
|
|
struct_span_err!(
|
2021-08-18 11:53:59 +02:00
|
|
|
|
sess,
|
|
|
|
|
DUMMY_SP,
|
|
|
|
|
E0602,
|
|
|
|
|
"`{}` lint group is not supported with ´--force-warn´",
|
|
|
|
|
crate::WARNINGS.name_lower()
|
|
|
|
|
)
|
|
|
|
|
.emit();
|
2022-01-27 09:44:25 +00:00
|
|
|
|
return;
|
2021-08-18 11:53:59 +02:00
|
|
|
|
}
|
2021-09-29 01:17:54 +03:00
|
|
|
|
let db = match self.check_lint_name(lint_name_only, tool_name, registered_tools) {
|
2017-07-26 21:51:09 -07:00
|
|
|
|
CheckLintNameResult::Ok(_) => None,
|
2019-12-22 17:42:04 -05:00
|
|
|
|
CheckLintNameResult::Warning(ref msg, _) => Some(sess.struct_warn(msg)),
|
2018-12-19 13:51:52 -05:00
|
|
|
|
CheckLintNameResult::NoLint(suggestion) => {
|
2019-12-31 21:25:16 +01:00
|
|
|
|
let mut err =
|
|
|
|
|
struct_span_err!(sess, DUMMY_SP, E0602, "unknown lint: `{}`", lint_name);
|
2018-12-19 13:51:52 -05:00
|
|
|
|
|
|
|
|
|
if let Some(suggestion) = suggestion {
|
|
|
|
|
err.help(&format!("did you mean: `{}`", suggestion));
|
|
|
|
|
}
|
|
|
|
|
|
2022-01-27 09:44:25 +00:00
|
|
|
|
Some(err.forget_guarantee())
|
2017-07-26 21:51:09 -07:00
|
|
|
|
}
|
2018-09-01 17:43:14 +02:00
|
|
|
|
CheckLintNameResult::Tool(result) => match result {
|
|
|
|
|
Err((Some(_), new_name)) => Some(sess.struct_warn(&format!(
|
2018-09-01 21:45:44 +05:30
|
|
|
|
"lint name `{}` is deprecated \
|
2018-09-01 17:43:14 +02:00
|
|
|
|
and does not have an effect anymore. \
|
|
|
|
|
Use: {}",
|
|
|
|
|
lint_name, new_name
|
|
|
|
|
))),
|
|
|
|
|
_ => None,
|
|
|
|
|
},
|
2022-01-27 09:44:25 +00:00
|
|
|
|
CheckLintNameResult::NoTool => Some(
|
|
|
|
|
struct_span_err!(
|
|
|
|
|
sess,
|
|
|
|
|
DUMMY_SP,
|
|
|
|
|
E0602,
|
|
|
|
|
"unknown lint tool: `{}`",
|
|
|
|
|
tool_name.unwrap()
|
|
|
|
|
)
|
|
|
|
|
.forget_guarantee(),
|
|
|
|
|
),
|
2017-07-26 21:51:09 -07:00
|
|
|
|
};
|
2017-05-16 03:16:18 +08:00
|
|
|
|
|
2017-07-26 21:51:09 -07:00
|
|
|
|
if let Some(mut db) = db {
|
2021-06-04 23:21:43 +02:00
|
|
|
|
let msg = format!(
|
|
|
|
|
"requested on the command line with `{} {}`",
|
|
|
|
|
match level {
|
|
|
|
|
Level::Allow => "-A",
|
|
|
|
|
Level::Warn => "-W",
|
2021-07-21 15:40:52 +02:00
|
|
|
|
Level::ForceWarn => "--force-warn",
|
2021-06-04 23:21:43 +02:00
|
|
|
|
Level::Deny => "-D",
|
|
|
|
|
Level::Forbid => "-F",
|
|
|
|
|
},
|
|
|
|
|
lint_name
|
|
|
|
|
);
|
|
|
|
|
db.note(&msg);
|
2017-07-26 21:51:09 -07:00
|
|
|
|
db.emit();
|
2017-05-16 03:16:18 +08:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2021-01-29 19:06:00 -05:00
|
|
|
|
/// True if this symbol represents a lint group name.
|
|
|
|
|
pub fn is_lint_group(&self, lint_name: Symbol) -> bool {
|
|
|
|
|
debug!(
|
|
|
|
|
"is_lint_group(lint_name={:?}, lint_groups={:?})",
|
|
|
|
|
lint_name,
|
|
|
|
|
self.lint_groups.keys().collect::<Vec<_>>()
|
|
|
|
|
);
|
2021-12-15 14:39:23 +11:00
|
|
|
|
let lint_name_str = lint_name.as_str();
|
|
|
|
|
self.lint_groups.contains_key(lint_name_str) || {
|
2021-01-29 19:06:00 -05:00
|
|
|
|
let warnings_name_str = crate::WARNINGS.name_lower();
|
2021-12-15 14:39:23 +11:00
|
|
|
|
lint_name_str == warnings_name_str
|
2021-01-29 19:06:00 -05:00
|
|
|
|
}
|
2017-05-16 03:16:18 +08:00
|
|
|
|
}
|
|
|
|
|
|
2017-07-26 21:51:09 -07:00
|
|
|
|
/// Checks the name of a lint for its existence, and whether it was
|
|
|
|
|
/// renamed or removed. Generates a DiagnosticBuilder containing a
|
|
|
|
|
/// warning for renamed and removed lints. This is over both lint
|
|
|
|
|
/// names from attributes and those passed on the command line. Since
|
|
|
|
|
/// it emits non-fatal warnings and there are *two* lint passes that
|
|
|
|
|
/// inspect attributes, this is only run from the late pass to avoid
|
|
|
|
|
/// printing duplicate warnings.
|
2018-07-30 11:29:23 +02:00
|
|
|
|
pub fn check_lint_name(
|
|
|
|
|
&self,
|
|
|
|
|
lint_name: &str,
|
2019-09-03 16:02:32 +10:00
|
|
|
|
tool_name: Option<Symbol>,
|
2021-09-29 01:17:54 +03:00
|
|
|
|
registered_tools: &RegisteredTools,
|
2018-08-29 22:02:42 -07:00
|
|
|
|
) -> CheckLintNameResult<'_> {
|
2021-07-07 10:50:50 -07:00
|
|
|
|
if let Some(tool_name) = tool_name {
|
2021-09-29 01:17:54 +03:00
|
|
|
|
// FIXME: rustc and rustdoc are considered tools for lints, but not for attributes.
|
|
|
|
|
if tool_name != sym::rustc
|
|
|
|
|
&& tool_name != sym::rustdoc
|
|
|
|
|
&& !registered_tools.contains(&Ident::with_dummy_span(tool_name))
|
|
|
|
|
{
|
2021-07-07 10:50:50 -07:00
|
|
|
|
return CheckLintNameResult::NoTool;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2018-07-30 11:29:23 +02:00
|
|
|
|
let complete_name = if let Some(tool_name) = tool_name {
|
|
|
|
|
format!("{}::{}", tool_name, lint_name)
|
|
|
|
|
} else {
|
|
|
|
|
lint_name.to_string()
|
|
|
|
|
};
|
2018-08-27 23:25:31 +02:00
|
|
|
|
// If the lint was scoped with `tool::` check if the tool lint exists
|
2020-12-30 13:49:28 -05:00
|
|
|
|
if let Some(tool_name) = tool_name {
|
2018-07-30 11:29:23 +02:00
|
|
|
|
match self.by_name.get(&complete_name) {
|
|
|
|
|
None => match self.lint_groups.get(&*complete_name) {
|
2020-12-30 13:49:28 -05:00
|
|
|
|
// If the lint isn't registered, there are two possibilities:
|
|
|
|
|
None => {
|
|
|
|
|
// 1. The tool is currently running, so this lint really doesn't exist.
|
|
|
|
|
// FIXME: should this handle tools that never register a lint, like rustfmt?
|
|
|
|
|
tracing::debug!("lints={:?}", self.by_name.keys().collect::<Vec<_>>());
|
|
|
|
|
let tool_prefix = format!("{}::", tool_name);
|
|
|
|
|
return if self.by_name.keys().any(|lint| lint.starts_with(&tool_prefix)) {
|
|
|
|
|
self.no_lint_suggestion(&complete_name)
|
|
|
|
|
} else {
|
|
|
|
|
// 2. The tool isn't currently running, so no lints will be registered.
|
|
|
|
|
// To avoid giving a false positive, ignore all unknown lints.
|
|
|
|
|
CheckLintNameResult::Tool(Err((None, String::new())))
|
|
|
|
|
};
|
|
|
|
|
}
|
2018-09-15 17:32:24 +01:00
|
|
|
|
Some(LintGroup { lint_ids, .. }) => {
|
|
|
|
|
return CheckLintNameResult::Tool(Ok(&lint_ids));
|
|
|
|
|
}
|
2018-07-30 11:29:23 +02:00
|
|
|
|
},
|
2018-08-27 23:25:31 +02:00
|
|
|
|
Some(&Id(ref id)) => return CheckLintNameResult::Tool(Ok(slice::from_ref(id))),
|
2018-07-30 11:29:23 +02:00
|
|
|
|
// If the lint was registered as removed or renamed by the lint tool, we don't need
|
|
|
|
|
// to treat tool_lints and rustc lints different and can use the code below.
|
|
|
|
|
_ => {}
|
2015-07-23 22:19:12 -07:00
|
|
|
|
}
|
2018-07-30 11:29:23 +02:00
|
|
|
|
}
|
|
|
|
|
match self.by_name.get(&complete_name) {
|
|
|
|
|
Some(&Renamed(ref new_name, _)) => CheckLintNameResult::Warning(
|
2019-12-22 17:42:04 -05:00
|
|
|
|
format!("lint `{}` has been renamed to `{}`", complete_name, new_name),
|
2018-07-30 11:29:23 +02:00
|
|
|
|
Some(new_name.to_owned()),
|
|
|
|
|
),
|
|
|
|
|
Some(&Removed(ref reason)) => CheckLintNameResult::Warning(
|
2021-01-17 14:23:25 -05:00
|
|
|
|
format!("lint `{}` has been removed: {}", complete_name, reason),
|
2018-07-30 11:29:23 +02:00
|
|
|
|
None,
|
|
|
|
|
),
|
|
|
|
|
None => match self.lint_groups.get(&*complete_name) {
|
2018-08-27 23:25:31 +02:00
|
|
|
|
// If neither the lint, nor the lint group exists check if there is a `clippy::`
|
|
|
|
|
// variant of this lint
|
|
|
|
|
None => self.check_tool_name_for_backwards_compat(&complete_name, "clippy"),
|
2018-09-15 17:32:24 +01:00
|
|
|
|
Some(LintGroup { lint_ids, depr, .. }) => {
|
2018-08-27 23:25:31 +02:00
|
|
|
|
// Check if the lint group name is deprecated
|
2018-09-15 17:32:24 +01:00
|
|
|
|
if let Some(LintAlias { name, silent }) = depr {
|
|
|
|
|
let LintGroup { lint_ids, .. } = self.lint_groups.get(name).unwrap();
|
|
|
|
|
return if *silent {
|
|
|
|
|
CheckLintNameResult::Ok(&lint_ids)
|
2018-09-15 15:26:45 +01:00
|
|
|
|
} else {
|
2020-03-05 14:29:58 +01:00
|
|
|
|
CheckLintNameResult::Tool(Err((Some(&lint_ids), (*name).to_string())))
|
2018-09-15 15:26:45 +01:00
|
|
|
|
};
|
2018-08-27 23:25:31 +02:00
|
|
|
|
}
|
2018-09-15 17:32:24 +01:00
|
|
|
|
CheckLintNameResult::Ok(&lint_ids)
|
2018-08-27 23:25:31 +02:00
|
|
|
|
}
|
2018-07-30 11:29:23 +02:00
|
|
|
|
},
|
2017-11-23 16:41:51 +02:00
|
|
|
|
Some(&Id(ref id)) => CheckLintNameResult::Ok(slice::from_ref(id)),
|
2021-03-16 11:59:05 -04:00
|
|
|
|
Some(&Ignored) => CheckLintNameResult::Ok(&[]),
|
2015-07-23 22:19:12 -07:00
|
|
|
|
}
|
2014-06-06 15:49:48 -07:00
|
|
|
|
}
|
2018-08-27 23:25:31 +02:00
|
|
|
|
|
2020-12-30 13:49:28 -05:00
|
|
|
|
fn no_lint_suggestion(&self, lint_name: &str) -> CheckLintNameResult<'_> {
|
2021-01-16 17:11:26 +01:00
|
|
|
|
let name_lower = lint_name.to_lowercase();
|
2020-12-30 13:49:28 -05:00
|
|
|
|
|
2021-01-16 17:11:26 +01:00
|
|
|
|
if lint_name.chars().any(char::is_uppercase) && self.find_lints(&name_lower).is_ok() {
|
|
|
|
|
// First check if the lint name is (partly) in upper case instead of lower case...
|
2021-05-05 10:33:14 -05:00
|
|
|
|
return CheckLintNameResult::NoLint(Some(Symbol::intern(&name_lower)));
|
2021-01-16 17:11:26 +01:00
|
|
|
|
}
|
2021-05-05 10:33:14 -05:00
|
|
|
|
// ...if not, search for lints with a similar name
|
|
|
|
|
let groups = self.lint_groups.keys().copied().map(Symbol::intern);
|
|
|
|
|
let lints = self.lints.iter().map(|l| Symbol::intern(&l.name_lower()));
|
|
|
|
|
let names: Vec<Symbol> = groups.chain(lints).collect();
|
|
|
|
|
let suggestion = find_best_match_for_name(&names, Symbol::intern(&name_lower), None);
|
|
|
|
|
CheckLintNameResult::NoLint(suggestion)
|
2020-12-30 13:49:28 -05:00
|
|
|
|
}
|
|
|
|
|
|
2018-08-27 23:25:31 +02:00
|
|
|
|
fn check_tool_name_for_backwards_compat(
|
|
|
|
|
&self,
|
|
|
|
|
lint_name: &str,
|
|
|
|
|
tool_name: &str,
|
2018-08-29 22:02:42 -07:00
|
|
|
|
) -> CheckLintNameResult<'_> {
|
2018-08-27 23:25:31 +02:00
|
|
|
|
let complete_name = format!("{}::{}", tool_name, lint_name);
|
|
|
|
|
match self.by_name.get(&complete_name) {
|
|
|
|
|
None => match self.lint_groups.get(&*complete_name) {
|
|
|
|
|
// Now we are sure, that this lint exists nowhere
|
2020-12-30 13:49:28 -05:00
|
|
|
|
None => self.no_lint_suggestion(lint_name),
|
2018-09-15 17:32:24 +01:00
|
|
|
|
Some(LintGroup { lint_ids, depr, .. }) => {
|
2018-09-15 15:26:45 +01:00
|
|
|
|
// Reaching this would be weird, but let's cover this case anyway
|
2018-09-15 17:32:24 +01:00
|
|
|
|
if let Some(LintAlias { name, silent }) = depr {
|
|
|
|
|
let LintGroup { lint_ids, .. } = self.lint_groups.get(name).unwrap();
|
|
|
|
|
return if *silent {
|
|
|
|
|
CheckLintNameResult::Tool(Err((Some(&lint_ids), complete_name)))
|
2018-09-15 15:26:45 +01:00
|
|
|
|
} else {
|
2020-03-05 14:29:58 +01:00
|
|
|
|
CheckLintNameResult::Tool(Err((Some(&lint_ids), (*name).to_string())))
|
2018-09-15 15:26:45 +01:00
|
|
|
|
};
|
2018-08-27 23:25:31 +02:00
|
|
|
|
}
|
2018-09-15 17:32:24 +01:00
|
|
|
|
CheckLintNameResult::Tool(Err((Some(&lint_ids), complete_name)))
|
2018-08-27 23:25:31 +02:00
|
|
|
|
}
|
|
|
|
|
},
|
|
|
|
|
Some(&Id(ref id)) => {
|
|
|
|
|
CheckLintNameResult::Tool(Err((Some(slice::from_ref(id)), complete_name)))
|
|
|
|
|
}
|
2020-12-29 23:16:16 -05:00
|
|
|
|
Some(other) => {
|
|
|
|
|
tracing::debug!("got renamed lint {:?}", other);
|
|
|
|
|
CheckLintNameResult::NoLint(None)
|
|
|
|
|
}
|
2018-08-27 23:25:31 +02:00
|
|
|
|
}
|
|
|
|
|
}
|
2014-06-06 15:49:48 -07:00
|
|
|
|
}
|
|
|
|
|
|
2021-10-25 15:43:07 -05:00
|
|
|
|
/// Context for lint checking outside of type inference.
|
2020-06-25 23:41:36 +03:00
|
|
|
|
pub struct LateContext<'tcx> {
|
2014-06-06 15:49:48 -07:00
|
|
|
|
/// Type context we're checking in.
|
2019-06-14 00:48:52 +03:00
|
|
|
|
pub tcx: TyCtxt<'tcx>,
|
2014-06-06 15:49:48 -07:00
|
|
|
|
|
2020-06-26 02:56:23 +03:00
|
|
|
|
/// Current body, or `None` if outside a body.
|
|
|
|
|
pub enclosing_body: Option<hir::BodyId>,
|
|
|
|
|
|
2020-07-17 08:47:04 +00:00
|
|
|
|
/// Type-checking results for the current body. Access using the `typeck_results`
|
|
|
|
|
/// and `maybe_typeck_results` methods, which handle querying the typeck results on demand.
|
2020-06-26 02:56:23 +03:00
|
|
|
|
// FIXME(eddyb) move all the code accessing internal fields like this,
|
|
|
|
|
// to this module, to avoid exposing it to lint logic.
|
2020-07-17 08:47:04 +00:00
|
|
|
|
pub(super) cached_typeck_results: Cell<Option<&'tcx ty::TypeckResults<'tcx>>>,
|
2020-06-26 02:56:23 +03:00
|
|
|
|
|
2017-06-07 15:21:55 +03:00
|
|
|
|
/// Parameter environment for the item we are in.
|
|
|
|
|
pub param_env: ty::ParamEnv<'tcx>,
|
|
|
|
|
|
2015-11-19 14:16:35 +03:00
|
|
|
|
/// Items accessible from the crate being checked.
|
2020-06-25 23:41:36 +03:00
|
|
|
|
pub access_levels: &'tcx AccessLevels,
|
2014-06-17 16:55:34 -07:00
|
|
|
|
|
2017-05-16 03:16:18 +08:00
|
|
|
|
/// The store of registered lints and the lint levels.
|
2019-12-30 14:22:46 +01:00
|
|
|
|
pub lint_store: &'tcx LintStore,
|
2017-07-26 21:51:09 -07:00
|
|
|
|
|
2019-12-30 14:22:46 +01:00
|
|
|
|
pub last_node_with_lint_attrs: hir::HirId,
|
2017-10-28 17:19:07 -04:00
|
|
|
|
|
|
|
|
|
/// Generic type parameters in scope for the item we are in.
|
2019-11-30 17:46:46 +01:00
|
|
|
|
pub generics: Option<&'tcx hir::Generics<'tcx>>,
|
2018-06-11 08:48:15 +02:00
|
|
|
|
|
|
|
|
|
/// We are only looking at one module
|
2019-12-30 14:11:49 +01:00
|
|
|
|
pub only_module: bool,
|
2014-06-06 15:49:48 -07:00
|
|
|
|
}
|
|
|
|
|
|
2021-09-28 00:28:49 +03:00
|
|
|
|
/// Context for lint checking of the AST, after expansion, before lowering to HIR.
|
2015-09-10 16:40:59 +12:00
|
|
|
|
pub struct EarlyContext<'a> {
|
2019-12-30 14:11:49 +01:00
|
|
|
|
pub builder: LintLevelsBuilder<'a>,
|
|
|
|
|
pub buffered: LintBuffer,
|
2019-01-18 07:40:55 +01:00
|
|
|
|
}
|
|
|
|
|
|
2018-07-14 16:40:17 +02:00
|
|
|
|
pub trait LintPassObject: Sized {}
|
2017-05-16 03:16:18 +08:00
|
|
|
|
|
2018-07-14 16:40:17 +02:00
|
|
|
|
impl LintPassObject for EarlyLintPassObject {}
|
2017-05-16 03:16:18 +08:00
|
|
|
|
|
2018-07-14 16:40:17 +02:00
|
|
|
|
impl LintPassObject for LateLintPassObject {}
|
2017-05-16 03:16:18 +08:00
|
|
|
|
|
2019-06-11 12:21:38 +03:00
|
|
|
|
pub trait LintContext: Sized {
|
2017-05-16 03:16:18 +08:00
|
|
|
|
type PassObject: LintPassObject;
|
|
|
|
|
|
2015-09-10 16:40:59 +12:00
|
|
|
|
fn sess(&self) -> &Session;
|
|
|
|
|
fn lints(&self) -> &LintStore;
|
2014-06-06 15:49:48 -07:00
|
|
|
|
|
2020-02-06 01:28:23 +10:00
|
|
|
|
fn lookup_with_diagnostics(
|
2019-12-22 17:42:04 -05:00
|
|
|
|
&self,
|
|
|
|
|
lint: &'static Lint,
|
2020-02-06 01:28:23 +10:00
|
|
|
|
span: Option<impl Into<MultiSpan>>,
|
2020-02-02 19:41:14 +10:00
|
|
|
|
decorate: impl for<'a> FnOnce(LintDiagnosticBuilder<'a>),
|
2019-12-22 17:42:04 -05:00
|
|
|
|
diagnostic: BuiltinLintDiagnostics,
|
|
|
|
|
) {
|
2020-01-31 22:24:57 +10:00
|
|
|
|
self.lookup(lint, span, |lint| {
|
2020-02-02 19:41:14 +10:00
|
|
|
|
// We first generate a blank diagnostic.
|
|
|
|
|
let mut db = lint.build("");
|
|
|
|
|
|
|
|
|
|
// Now, set up surrounding context.
|
2020-01-31 22:24:57 +10:00
|
|
|
|
let sess = self.sess();
|
|
|
|
|
match diagnostic {
|
2021-08-19 11:40:00 -07:00
|
|
|
|
BuiltinLintDiagnostics::UnicodeTextFlow(span, content) => {
|
|
|
|
|
let spans: Vec<_> = content
|
|
|
|
|
.char_indices()
|
|
|
|
|
.filter_map(|(i, c)| {
|
2021-11-04 23:31:42 +01:00
|
|
|
|
TEXT_FLOW_CONTROL_CHARS.contains(&c).then(|| {
|
2021-08-19 11:40:00 -07:00
|
|
|
|
let lo = span.lo() + BytePos(2 + i as u32);
|
|
|
|
|
(c, span.with_lo(lo).with_hi(lo + BytePos(c.len_utf8() as u32)))
|
|
|
|
|
})
|
|
|
|
|
})
|
|
|
|
|
.collect();
|
|
|
|
|
let (an, s) = match spans.len() {
|
|
|
|
|
1 => ("an ", ""),
|
|
|
|
|
_ => ("", "s"),
|
|
|
|
|
};
|
|
|
|
|
db.span_label(span, &format!(
|
|
|
|
|
"this comment contains {}invisible unicode text flow control codepoint{}",
|
|
|
|
|
an,
|
|
|
|
|
s,
|
|
|
|
|
));
|
|
|
|
|
for (c, span) in &spans {
|
|
|
|
|
db.span_label(*span, format!("{:?}", c));
|
|
|
|
|
}
|
|
|
|
|
db.note(
|
|
|
|
|
"these kind of unicode codepoints change the way text flows on \
|
|
|
|
|
applications that support them, but can cause confusion because they \
|
|
|
|
|
change the order of characters on the screen",
|
|
|
|
|
);
|
|
|
|
|
if !spans.is_empty() {
|
|
|
|
|
db.multipart_suggestion_with_style(
|
|
|
|
|
"if their presence wasn't intentional, you can remove them",
|
|
|
|
|
spans.into_iter().map(|(_, span)| (span, "".to_string())).collect(),
|
|
|
|
|
Applicability::MachineApplicable,
|
|
|
|
|
SuggestionStyle::HideCodeAlways,
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
},
|
2020-01-31 22:24:57 +10:00
|
|
|
|
BuiltinLintDiagnostics::Normal => (),
|
|
|
|
|
BuiltinLintDiagnostics::AbsPathWithModule(span) => {
|
|
|
|
|
let (sugg, app) = match sess.source_map().span_to_snippet(span) {
|
|
|
|
|
Ok(ref s) => {
|
|
|
|
|
// FIXME(Manishearth) ideally the emitting code
|
|
|
|
|
// can tell us whether or not this is global
|
2020-02-02 09:47:58 +10:00
|
|
|
|
let opt_colon =
|
|
|
|
|
if s.trim_start().starts_with("::") { "" } else { "::" };
|
2020-01-31 22:24:57 +10:00
|
|
|
|
|
|
|
|
|
(format!("crate{}{}", opt_colon, s), Applicability::MachineApplicable)
|
|
|
|
|
}
|
|
|
|
|
Err(_) => ("crate::<path>".to_string(), Applicability::HasPlaceholders),
|
|
|
|
|
};
|
|
|
|
|
db.span_suggestion(span, "use `crate`", sugg, app);
|
|
|
|
|
}
|
|
|
|
|
BuiltinLintDiagnostics::ProcMacroDeriveResolutionFallback(span) => {
|
|
|
|
|
db.span_label(
|
|
|
|
|
span,
|
|
|
|
|
"names from parent modules are not accessible without an explicit import",
|
|
|
|
|
);
|
|
|
|
|
}
|
2020-02-02 09:47:58 +10:00
|
|
|
|
BuiltinLintDiagnostics::MacroExpandedMacroExportsAccessedByAbsolutePaths(
|
|
|
|
|
span_def,
|
|
|
|
|
) => {
|
2020-01-31 22:24:57 +10:00
|
|
|
|
db.span_note(span_def, "the macro is defined here");
|
|
|
|
|
}
|
|
|
|
|
BuiltinLintDiagnostics::UnknownCrateTypes(span, note, sugg) => {
|
|
|
|
|
db.span_suggestion(span, ¬e, sugg, Applicability::MaybeIncorrect);
|
|
|
|
|
}
|
2021-10-23 18:55:02 +09:00
|
|
|
|
BuiltinLintDiagnostics::UnusedImports(message, replaces, in_test_module) => {
|
2020-01-31 22:24:57 +10:00
|
|
|
|
if !replaces.is_empty() {
|
|
|
|
|
db.tool_only_multipart_suggestion(
|
|
|
|
|
&message,
|
|
|
|
|
replaces,
|
|
|
|
|
Applicability::MachineApplicable,
|
|
|
|
|
);
|
|
|
|
|
}
|
2021-10-23 18:55:02 +09:00
|
|
|
|
|
|
|
|
|
if let Some(span) = in_test_module {
|
|
|
|
|
let def_span = self.sess().source_map().guess_head_span(span);
|
|
|
|
|
db.span_help(
|
|
|
|
|
span.shrink_to_lo().to(def_span),
|
|
|
|
|
"consider adding a `#[cfg(test)]` to the containing module",
|
|
|
|
|
);
|
|
|
|
|
}
|
2020-01-31 22:24:57 +10:00
|
|
|
|
}
|
|
|
|
|
BuiltinLintDiagnostics::RedundantImport(spans, ident) => {
|
|
|
|
|
for (span, is_imported) in spans {
|
|
|
|
|
let introduced = if is_imported { "imported" } else { "defined" };
|
|
|
|
|
db.span_label(
|
|
|
|
|
span,
|
|
|
|
|
format!("the item `{}` is already {} here", ident, introduced),
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
BuiltinLintDiagnostics::DeprecatedMacro(suggestion, span) => {
|
2020-07-25 13:49:46 -04:00
|
|
|
|
stability::deprecation_suggestion(&mut db, "macro", suggestion, span)
|
2020-01-05 10:07:26 +01:00
|
|
|
|
}
|
2020-02-21 16:01:48 -08:00
|
|
|
|
BuiltinLintDiagnostics::UnusedDocComment(span) => {
|
2020-04-21 21:09:24 -07:00
|
|
|
|
db.span_label(span, "rustdoc does not generate documentation for macro invocations");
|
2020-02-21 16:01:48 -08:00
|
|
|
|
db.help("to document an item produced by a macro, \
|
|
|
|
|
the macro must produce the documentation as part of its expansion");
|
|
|
|
|
}
|
2020-11-30 23:24:08 +09:00
|
|
|
|
BuiltinLintDiagnostics::PatternsInFnsWithoutBody(span, ident) => {
|
|
|
|
|
db.span_suggestion(span, "remove `mut` from the parameter", ident.to_string(), Applicability::MachineApplicable);
|
|
|
|
|
}
|
2020-09-01 17:12:38 -04:00
|
|
|
|
BuiltinLintDiagnostics::MissingAbi(span, default_abi) => {
|
|
|
|
|
db.span_label(span, "ABI should be specified here");
|
|
|
|
|
db.help(&format!("the default ABI is {}", default_abi.name()));
|
|
|
|
|
}
|
2020-11-14 14:47:14 +03:00
|
|
|
|
BuiltinLintDiagnostics::LegacyDeriveHelpers(span) => {
|
|
|
|
|
db.span_label(span, "the attribute is introduced here");
|
|
|
|
|
}
|
2020-05-25 16:21:25 -07:00
|
|
|
|
BuiltinLintDiagnostics::ExternDepSpec(krate, loc) => {
|
|
|
|
|
let json = match loc {
|
|
|
|
|
ExternDepSpec::Json(json) => {
|
|
|
|
|
db.help(&format!("remove unnecessary dependency `{}`", krate));
|
|
|
|
|
json
|
|
|
|
|
}
|
|
|
|
|
ExternDepSpec::Raw(raw) => {
|
|
|
|
|
db.help(&format!("remove unnecessary dependency `{}` at `{}`", krate, raw));
|
|
|
|
|
db.span_suggestion_with_style(
|
|
|
|
|
DUMMY_SP,
|
|
|
|
|
"raw extern location",
|
|
|
|
|
raw.clone(),
|
|
|
|
|
Applicability::Unspecified,
|
|
|
|
|
SuggestionStyle::CompletelyHidden,
|
|
|
|
|
);
|
|
|
|
|
Json::String(raw)
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
db.tool_only_suggestion_with_metadata(
|
|
|
|
|
"json extern location",
|
|
|
|
|
Applicability::Unspecified,
|
|
|
|
|
json
|
|
|
|
|
);
|
|
|
|
|
}
|
2021-03-14 16:55:59 -04:00
|
|
|
|
BuiltinLintDiagnostics::ProcMacroBackCompat(note) => {
|
|
|
|
|
db.note(¬e);
|
|
|
|
|
}
|
2021-03-25 21:42:21 +08:00
|
|
|
|
BuiltinLintDiagnostics::OrPatternsBackCompat(span,suggestion) => {
|
2021-04-14 20:34:51 -05:00
|
|
|
|
db.span_suggestion(span, "use pat_param to preserve semantics", suggestion, Applicability::MachineApplicable);
|
2021-03-25 21:42:21 +08:00
|
|
|
|
}
|
2021-06-14 12:56:49 +00:00
|
|
|
|
BuiltinLintDiagnostics::ReservedPrefix(span) => {
|
|
|
|
|
db.span_label(span, "unknown prefix");
|
|
|
|
|
db.span_suggestion_verbose(
|
|
|
|
|
span.shrink_to_hi(),
|
|
|
|
|
"insert whitespace here to avoid this being parsed as a prefix in Rust 2021",
|
|
|
|
|
" ".into(),
|
|
|
|
|
Applicability::MachineApplicable,
|
|
|
|
|
);
|
|
|
|
|
}
|
2021-07-14 19:51:45 -05:00
|
|
|
|
BuiltinLintDiagnostics::UnusedBuiltinAttribute {
|
|
|
|
|
attr_name,
|
|
|
|
|
macro_name,
|
|
|
|
|
invoc_span
|
|
|
|
|
} => {
|
|
|
|
|
db.span_note(
|
|
|
|
|
invoc_span,
|
|
|
|
|
&format!("the built-in attribute `{attr_name}` will be ignored, since it's applied to the macro invocation `{macro_name}`")
|
|
|
|
|
);
|
|
|
|
|
}
|
Display an extra note for trailing semicolon lint with trailing macro
Currently, we parse macros at the end of a block
(e.g. `fn foo() { my_macro!() }`) as expressions, rather than
statements. This means that a macro invoked in this position
cannot expand to items or semicolon-terminated expressions.
In the future, we might want to start parsing these kinds of macros
as statements. This would make expansion more 'token-based'
(i.e. macro expansion behaves (almost) as if you just textually
replaced the macro invocation with its output). However,
this is a breaking change (see PR #78991), so it will require
further discussion.
Since the current behavior will not be changing any time soon,
we need to address the interaction with the
`SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` lint. Since we are parsing
the result of macro expansion as an expression, we will emit a lint
if there's a trailing semicolon in the macro output. However, this
results in a somewhat confusing message for users, since it visually
looks like there should be no problem with having a semicolon
at the end of a block
(e.g. `fn foo() { my_macro!() }` => `fn foo() { produced_expr; }`)
To help reduce confusion, this commit adds a note explaining
that the macro is being interpreted as an expression. Additionally,
we suggest adding a semicolon after the macro *invocation* - this
will cause us to parse the macro call as a statement. We do *not*
use a structured suggestion for this, since the user may actually
want to remove the semicolon from the macro definition (allowing
the block to evaluate to the expression produced by the macro).
2021-07-22 11:24:42 -05:00
|
|
|
|
BuiltinLintDiagnostics::TrailingMacro(is_trailing, name) => {
|
|
|
|
|
if is_trailing {
|
|
|
|
|
db.note("macro invocations at the end of a block are treated as expressions");
|
|
|
|
|
db.note(&format!("to ignore the value produced by the macro, add a semicolon after the invocation of `{name}`"));
|
|
|
|
|
}
|
|
|
|
|
}
|
2021-07-10 16:38:55 +02:00
|
|
|
|
BuiltinLintDiagnostics::BreakWithLabelAndLoop(span) => {
|
2021-08-03 21:23:29 +02:00
|
|
|
|
db.multipart_suggestion(
|
|
|
|
|
"wrap this expression in parentheses",
|
|
|
|
|
vec![(span.shrink_to_lo(), "(".to_string()),
|
|
|
|
|
(span.shrink_to_hi(), ")".to_string())],
|
|
|
|
|
Applicability::MachineApplicable
|
|
|
|
|
);
|
2021-07-10 16:38:55 +02:00
|
|
|
|
}
|
2021-07-20 16:35:26 -04:00
|
|
|
|
BuiltinLintDiagnostics::NamedAsmLabel(help) => {
|
|
|
|
|
db.help(&help);
|
2022-01-06 14:39:42 +01:00
|
|
|
|
db.note("see the asm section of Rust By Example <https://doc.rust-lang.org/nightly/rust-by-example/unsafe/asm.html#labels> for more information");
|
2022-02-20 00:48:10 +01:00
|
|
|
|
},
|
|
|
|
|
BuiltinLintDiagnostics::UnexpectedCfg(span, name, value) => {
|
2022-02-20 01:26:52 +01:00
|
|
|
|
let possibilities: Vec<Symbol> = if value.is_some() {
|
|
|
|
|
let Some(values) = &sess.parse_sess.check_config.values_valid.get(&name) else {
|
2022-02-20 00:48:10 +01:00
|
|
|
|
bug!("it shouldn't be possible to have a diagnostic on a value whose name is not in values");
|
|
|
|
|
};
|
|
|
|
|
values.iter().map(|&s| s).collect()
|
|
|
|
|
} else {
|
|
|
|
|
let Some(names_valid) = &sess.parse_sess.check_config.names_valid else {
|
2022-02-20 01:26:52 +01:00
|
|
|
|
bug!("it shouldn't be possible to have a diagnostic on a name if name checking is not enabled");
|
2022-02-20 00:48:10 +01:00
|
|
|
|
};
|
|
|
|
|
names_valid.iter().map(|s| *s).collect()
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
// Show the full list if all possible values for a given name, but don't do it
|
|
|
|
|
// for names as the possibilities could be very long
|
|
|
|
|
if value.is_some() {
|
2022-02-20 01:26:52 +01:00
|
|
|
|
if !possibilities.is_empty() {
|
|
|
|
|
let mut possibilities = possibilities.iter().map(Symbol::as_str).collect::<Vec<_>>();
|
|
|
|
|
possibilities.sort();
|
2022-02-20 00:48:10 +01:00
|
|
|
|
|
2022-02-20 01:26:52 +01:00
|
|
|
|
let possibilities = possibilities.join(", ");
|
|
|
|
|
db.note(&format!("expected values for `{name}` are: {possibilities}"));
|
|
|
|
|
} else {
|
|
|
|
|
db.note(&format!("no expected value for `{name}`"));
|
|
|
|
|
}
|
2022-02-20 00:48:10 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Suggest the most probable if we found one
|
|
|
|
|
if let Some(best_match) = find_best_match_for_name(&possibilities, value.unwrap_or(name), None) {
|
2022-02-20 01:26:52 +01:00
|
|
|
|
let punctuation = if value.is_some() { "\"" } else { "" };
|
|
|
|
|
db.span_suggestion(span, "did you mean", format!("{punctuation}{best_match}{punctuation}"), Applicability::MaybeIncorrect);
|
2022-02-20 00:48:10 +01:00
|
|
|
|
}
|
|
|
|
|
},
|
2020-01-05 10:07:26 +01:00
|
|
|
|
}
|
2020-02-02 19:41:14 +10:00
|
|
|
|
// Rewrap `db`, and pass control to the user.
|
|
|
|
|
decorate(LintDiagnosticBuilder::new(db));
|
2020-01-31 22:24:57 +10:00
|
|
|
|
});
|
2018-02-22 22:34:06 -08:00
|
|
|
|
}
|
|
|
|
|
|
2020-02-06 03:18:40 +10:00
|
|
|
|
// FIXME: These methods should not take an Into<MultiSpan> -- instead, callers should need to
|
|
|
|
|
// set the span in their `decorate` function (preferably using set_span).
|
2019-12-22 17:42:04 -05:00
|
|
|
|
fn lookup<S: Into<MultiSpan>>(
|
|
|
|
|
&self,
|
|
|
|
|
lint: &'static Lint,
|
|
|
|
|
span: Option<S>,
|
2020-01-31 22:24:57 +10:00
|
|
|
|
decorate: impl for<'a> FnOnce(LintDiagnosticBuilder<'a>),
|
|
|
|
|
);
|
2015-12-21 10:00:43 +13:00
|
|
|
|
|
2019-12-22 17:42:04 -05:00
|
|
|
|
fn struct_span_lint<S: Into<MultiSpan>>(
|
|
|
|
|
&self,
|
|
|
|
|
lint: &'static Lint,
|
|
|
|
|
span: S,
|
2020-02-02 09:47:58 +10:00
|
|
|
|
decorate: impl for<'a> FnOnce(LintDiagnosticBuilder<'a>),
|
2020-01-31 22:24:57 +10:00
|
|
|
|
) {
|
|
|
|
|
self.lookup(lint, Some(span), decorate);
|
2015-12-21 10:00:43 +13:00
|
|
|
|
}
|
2015-09-10 16:40:59 +12:00
|
|
|
|
/// Emit a lint at the appropriate level, with no associated span.
|
2020-02-02 19:41:14 +10:00
|
|
|
|
fn lint(&self, lint: &'static Lint, decorate: impl for<'a> FnOnce(LintDiagnosticBuilder<'a>)) {
|
|
|
|
|
self.lookup(lint, None as Option<Span>, decorate);
|
2015-09-10 16:40:59 +12:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl<'a> EarlyContext<'a> {
|
2021-09-28 00:28:49 +03:00
|
|
|
|
pub(crate) fn new(
|
2018-07-14 16:40:17 +02:00
|
|
|
|
sess: &'a Session,
|
2021-09-28 00:28:49 +03:00
|
|
|
|
warn_about_weird_lints: bool,
|
2019-10-09 08:46:11 -04:00
|
|
|
|
lint_store: &'a LintStore,
|
2021-09-29 01:17:54 +03:00
|
|
|
|
registered_tools: &'a RegisteredTools,
|
2018-07-14 16:40:17 +02:00
|
|
|
|
buffered: LintBuffer,
|
|
|
|
|
) -> EarlyContext<'a> {
|
2015-09-10 16:40:59 +12:00
|
|
|
|
EarlyContext {
|
2021-09-29 01:17:54 +03:00
|
|
|
|
builder: LintLevelsBuilder::new(
|
|
|
|
|
sess,
|
|
|
|
|
warn_about_weird_lints,
|
|
|
|
|
lint_store,
|
|
|
|
|
registered_tools,
|
|
|
|
|
),
|
2018-07-14 16:40:17 +02:00
|
|
|
|
buffered,
|
2017-07-26 21:51:09 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2019-01-18 07:40:55 +01:00
|
|
|
|
}
|
2017-07-26 21:51:09 -07:00
|
|
|
|
|
2020-06-25 23:41:36 +03:00
|
|
|
|
impl LintContext for LateContext<'_> {
|
2017-05-16 03:16:18 +08:00
|
|
|
|
type PassObject = LateLintPassObject;
|
|
|
|
|
|
2019-02-08 14:53:55 +01:00
|
|
|
|
/// Gets the overall compiler `Session` object.
|
2015-09-10 16:40:59 +12:00
|
|
|
|
fn sess(&self) -> &Session {
|
|
|
|
|
&self.tcx.sess
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn lints(&self) -> &LintStore {
|
2019-01-31 03:04:39 +01:00
|
|
|
|
&*self.lint_store
|
2015-09-10 16:40:59 +12:00
|
|
|
|
}
|
|
|
|
|
|
2019-12-22 17:42:04 -05:00
|
|
|
|
fn lookup<S: Into<MultiSpan>>(
|
|
|
|
|
&self,
|
|
|
|
|
lint: &'static Lint,
|
|
|
|
|
span: Option<S>,
|
2020-01-31 22:24:57 +10:00
|
|
|
|
decorate: impl for<'a> FnOnce(LintDiagnosticBuilder<'a>),
|
|
|
|
|
) {
|
2019-02-06 14:16:11 +01:00
|
|
|
|
let hir_id = self.last_node_with_lint_attrs;
|
|
|
|
|
|
2017-07-26 21:51:09 -07:00
|
|
|
|
match span {
|
2020-01-31 22:24:57 +10:00
|
|
|
|
Some(s) => self.tcx.struct_span_lint_hir(lint, hir_id, s, decorate),
|
|
|
|
|
None => self.tcx.struct_lint_node(lint, hir_id, decorate),
|
2017-07-26 21:51:09 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2015-09-10 16:40:59 +12:00
|
|
|
|
}
|
|
|
|
|
|
2019-06-11 12:21:38 +03:00
|
|
|
|
impl LintContext for EarlyContext<'_> {
|
2017-05-16 03:16:18 +08:00
|
|
|
|
type PassObject = EarlyLintPassObject;
|
|
|
|
|
|
2019-02-08 14:53:55 +01:00
|
|
|
|
/// Gets the overall compiler `Session` object.
|
2015-09-10 16:40:59 +12:00
|
|
|
|
fn sess(&self) -> &Session {
|
2021-09-28 00:28:49 +03:00
|
|
|
|
&self.builder.sess()
|
2015-09-10 16:40:59 +12:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn lints(&self) -> &LintStore {
|
2021-09-28 00:28:49 +03:00
|
|
|
|
self.builder.lint_store()
|
2015-09-10 16:40:59 +12:00
|
|
|
|
}
|
|
|
|
|
|
2019-12-22 17:42:04 -05:00
|
|
|
|
fn lookup<S: Into<MultiSpan>>(
|
|
|
|
|
&self,
|
|
|
|
|
lint: &'static Lint,
|
|
|
|
|
span: Option<S>,
|
2020-01-31 22:24:57 +10:00
|
|
|
|
decorate: impl for<'a> FnOnce(LintDiagnosticBuilder<'a>),
|
|
|
|
|
) {
|
|
|
|
|
self.builder.struct_lint(lint, span.map(|s| s.into()), decorate)
|
2017-07-26 21:51:09 -07:00
|
|
|
|
}
|
2019-01-18 07:40:55 +01:00
|
|
|
|
}
|
2017-07-26 21:51:09 -07:00
|
|
|
|
|
2020-06-25 23:41:36 +03:00
|
|
|
|
impl<'tcx> LateContext<'tcx> {
|
2020-07-17 08:47:04 +00:00
|
|
|
|
/// Gets the type-checking results for the current body,
|
2020-06-26 05:55:23 +03:00
|
|
|
|
/// or `None` if outside a body.
|
2020-07-17 08:47:04 +00:00
|
|
|
|
pub fn maybe_typeck_results(&self) -> Option<&'tcx ty::TypeckResults<'tcx>> {
|
|
|
|
|
self.cached_typeck_results.get().or_else(|| {
|
2020-06-26 05:55:23 +03:00
|
|
|
|
self.enclosing_body.map(|body| {
|
2020-07-17 08:47:04 +00:00
|
|
|
|
let typeck_results = self.tcx.typeck_body(body);
|
|
|
|
|
self.cached_typeck_results.set(Some(typeck_results));
|
|
|
|
|
typeck_results
|
2020-06-26 02:56:23 +03:00
|
|
|
|
})
|
2020-06-26 05:55:23 +03:00
|
|
|
|
})
|
|
|
|
|
}
|
|
|
|
|
|
2020-07-17 08:47:04 +00:00
|
|
|
|
/// Gets the type-checking results for the current body.
|
2020-06-26 05:55:23 +03:00
|
|
|
|
/// As this will ICE if called outside bodies, only call when working with
|
|
|
|
|
/// `Expr` or `Pat` nodes (they are guaranteed to be found only in bodies).
|
|
|
|
|
#[track_caller]
|
2020-07-17 08:47:04 +00:00
|
|
|
|
pub fn typeck_results(&self) -> &'tcx ty::TypeckResults<'tcx> {
|
|
|
|
|
self.maybe_typeck_results().expect("`LateContext::typeck_results` called outside of body")
|
2020-06-26 05:55:23 +03:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Returns the final resolution of a `QPath`, or `Res::Err` if unavailable.
|
2020-07-17 08:47:04 +00:00
|
|
|
|
/// Unlike `.typeck_results().qpath_res(qpath, id)`, this can be used even outside
|
2020-06-26 05:55:23 +03:00
|
|
|
|
/// bodies (e.g. for paths in `hir::Ty`), without any risk of ICE-ing.
|
|
|
|
|
pub fn qpath_res(&self, qpath: &hir::QPath<'_>, id: hir::HirId) -> Res {
|
|
|
|
|
match *qpath {
|
|
|
|
|
hir::QPath::Resolved(_, ref path) => path.res,
|
2020-08-04 14:34:24 +01:00
|
|
|
|
hir::QPath::TypeRelative(..) | hir::QPath::LangItem(..) => self
|
2020-07-17 08:47:04 +00:00
|
|
|
|
.maybe_typeck_results()
|
2021-01-18 13:29:37 -06:00
|
|
|
|
.filter(|typeck_results| typeck_results.hir_owner == id.owner)
|
|
|
|
|
.or_else(|| {
|
|
|
|
|
if self.tcx.has_typeck_results(id.owner.to_def_id()) {
|
|
|
|
|
Some(self.tcx.typeck(id.owner))
|
|
|
|
|
} else {
|
|
|
|
|
None
|
|
|
|
|
}
|
|
|
|
|
})
|
2020-07-17 08:47:04 +00:00
|
|
|
|
.and_then(|typeck_results| typeck_results.type_dependent_def(id))
|
2020-06-26 05:55:23 +03:00
|
|
|
|
.map_or(Res::Err, |(kind, def_id)| Res::Def(kind, def_id)),
|
2020-06-26 02:56:23 +03:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-04-05 23:04:56 +02:00
|
|
|
|
/// Check if a `DefId`'s path matches the given absolute type path usage.
|
2019-04-07 19:47:54 +02:00
|
|
|
|
///
|
2020-12-29 20:28:08 -05:00
|
|
|
|
/// Anonymous scopes such as `extern` imports are matched with `kw::Empty`;
|
2019-11-02 16:12:33 +01:00
|
|
|
|
/// inherent `impl` blocks are matched with the name of the type.
|
|
|
|
|
///
|
2020-09-19 11:32:55 +02:00
|
|
|
|
/// Instead of using this method, it is often preferable to instead use
|
2020-09-19 15:36:53 +02:00
|
|
|
|
/// `rustc_diagnostic_item` or a `lang_item`. This is less prone to errors
|
|
|
|
|
/// as paths get invalidated if the target definition moves.
|
2020-09-19 10:57:13 +02:00
|
|
|
|
///
|
2019-04-07 19:47:54 +02:00
|
|
|
|
/// # Examples
|
2019-05-02 12:33:59 -04:00
|
|
|
|
///
|
|
|
|
|
/// ```rust,ignore (no context or def id available)
|
2019-05-14 15:58:22 +02:00
|
|
|
|
/// if cx.match_def_path(def_id, &[sym::core, sym::option, sym::Option]) {
|
2019-04-07 19:47:54 +02:00
|
|
|
|
/// // The given `def_id` is that of an `Option` type
|
|
|
|
|
/// }
|
|
|
|
|
/// ```
|
2021-03-16 01:50:34 -04:00
|
|
|
|
///
|
|
|
|
|
/// Used by clippy, but should be replaced by diagnostic items eventually.
|
2019-05-14 15:58:22 +02:00
|
|
|
|
pub fn match_def_path(&self, def_id: DefId, path: &[Symbol]) -> bool {
|
2019-04-07 19:47:54 +02:00
|
|
|
|
let names = self.get_def_path(def_id);
|
|
|
|
|
|
2021-03-08 15:32:41 -08:00
|
|
|
|
names.len() == path.len() && iter::zip(names, path).all(|(a, &b)| a == b)
|
2019-04-07 19:47:54 +02:00
|
|
|
|
}
|
|
|
|
|
|
2019-05-14 15:58:22 +02:00
|
|
|
|
/// Gets the absolute path of `def_id` as a vector of `Symbol`.
|
2019-04-07 19:47:54 +02:00
|
|
|
|
///
|
|
|
|
|
/// # Examples
|
2019-05-02 12:33:59 -04:00
|
|
|
|
///
|
|
|
|
|
/// ```rust,ignore (no context or def id available)
|
2019-04-07 19:47:54 +02:00
|
|
|
|
/// let def_path = cx.get_def_path(def_id);
|
2019-05-14 15:58:22 +02:00
|
|
|
|
/// if let &[sym::core, sym::option, sym::Option] = &def_path[..] {
|
2019-04-07 19:47:54 +02:00
|
|
|
|
/// // The given `def_id` is that of an `Option` type
|
|
|
|
|
/// }
|
|
|
|
|
/// ```
|
2019-05-14 15:58:22 +02:00
|
|
|
|
pub fn get_def_path(&self, def_id: DefId) -> Vec<Symbol> {
|
2019-06-11 22:03:44 +03:00
|
|
|
|
pub struct AbsolutePathPrinter<'tcx> {
|
2019-06-14 00:48:52 +03:00
|
|
|
|
pub tcx: TyCtxt<'tcx>,
|
2019-04-05 23:04:56 +02:00
|
|
|
|
}
|
|
|
|
|
|
2019-06-14 00:48:52 +03:00
|
|
|
|
impl<'tcx> Printer<'tcx> for AbsolutePathPrinter<'tcx> {
|
2019-04-05 23:04:56 +02:00
|
|
|
|
type Error = !;
|
|
|
|
|
|
2019-05-14 15:58:22 +02:00
|
|
|
|
type Path = Vec<Symbol>;
|
2019-04-05 23:04:56 +02:00
|
|
|
|
type Region = ();
|
|
|
|
|
type Type = ();
|
|
|
|
|
type DynExistential = ();
|
2019-03-18 12:50:57 +02:00
|
|
|
|
type Const = ();
|
2019-04-05 23:04:56 +02:00
|
|
|
|
|
2019-06-14 00:48:52 +03:00
|
|
|
|
fn tcx(&self) -> TyCtxt<'tcx> {
|
2019-04-05 23:04:56 +02:00
|
|
|
|
self.tcx
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn print_region(self, _region: ty::Region<'_>) -> Result<Self::Region, Self::Error> {
|
|
|
|
|
Ok(())
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn print_type(self, _ty: Ty<'tcx>) -> Result<Self::Type, Self::Error> {
|
|
|
|
|
Ok(())
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn print_dyn_existential(
|
|
|
|
|
self,
|
2020-10-05 16:51:33 -04:00
|
|
|
|
_predicates: &'tcx ty::List<ty::Binder<'tcx, ty::ExistentialPredicate<'tcx>>>,
|
2019-03-18 12:50:57 +02:00
|
|
|
|
) -> Result<Self::DynExistential, Self::Error> {
|
|
|
|
|
Ok(())
|
|
|
|
|
}
|
|
|
|
|
|
2022-02-02 14:24:45 +11:00
|
|
|
|
fn print_const(self, _ct: ty::Const<'tcx>) -> Result<Self::Const, Self::Error> {
|
2019-04-05 23:04:56 +02:00
|
|
|
|
Ok(())
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn path_crate(self, cnum: CrateNum) -> Result<Self::Path, Self::Error> {
|
2021-05-10 18:23:32 +02:00
|
|
|
|
Ok(vec![self.tcx.crate_name(cnum)])
|
2019-04-05 23:04:56 +02:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn path_qualified(
|
|
|
|
|
self,
|
|
|
|
|
self_ty: Ty<'tcx>,
|
|
|
|
|
trait_ref: Option<ty::TraitRef<'tcx>>,
|
2019-05-14 15:58:22 +02:00
|
|
|
|
) -> Result<Self::Path, Self::Error> {
|
2019-04-05 23:04:56 +02:00
|
|
|
|
if trait_ref.is_none() {
|
2020-08-03 00:49:11 +02:00
|
|
|
|
if let ty::Adt(def, substs) = self_ty.kind() {
|
2019-04-05 23:04:56 +02:00
|
|
|
|
return self.print_def_path(def.did, substs);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// This shouldn't ever be needed, but just in case:
|
2022-02-16 13:04:48 -05:00
|
|
|
|
with_no_trimmed_paths!({
|
2020-09-02 10:40:56 +03:00
|
|
|
|
Ok(vec![match trait_ref {
|
|
|
|
|
Some(trait_ref) => Symbol::intern(&format!("{:?}", trait_ref)),
|
|
|
|
|
None => Symbol::intern(&format!("<{}>", self_ty)),
|
|
|
|
|
}])
|
|
|
|
|
})
|
2019-04-05 23:04:56 +02:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn path_append_impl(
|
|
|
|
|
self,
|
|
|
|
|
print_prefix: impl FnOnce(Self) -> Result<Self::Path, Self::Error>,
|
|
|
|
|
_disambiguated_data: &DisambiguatedDefPathData,
|
|
|
|
|
self_ty: Ty<'tcx>,
|
|
|
|
|
trait_ref: Option<ty::TraitRef<'tcx>>,
|
2019-05-14 15:58:22 +02:00
|
|
|
|
) -> Result<Self::Path, Self::Error> {
|
2019-04-05 23:04:56 +02:00
|
|
|
|
let mut path = print_prefix(self)?;
|
|
|
|
|
|
|
|
|
|
// This shouldn't ever be needed, but just in case:
|
|
|
|
|
path.push(match trait_ref {
|
2022-02-16 13:04:48 -05:00
|
|
|
|
Some(trait_ref) => {
|
|
|
|
|
with_no_trimmed_paths!(Symbol::intern(&format!(
|
2020-09-02 10:40:56 +03:00
|
|
|
|
"<impl {} for {}>",
|
|
|
|
|
trait_ref.print_only_trait_path(),
|
|
|
|
|
self_ty
|
2022-02-16 13:04:48 -05:00
|
|
|
|
)))
|
|
|
|
|
}
|
2020-09-02 10:40:56 +03:00
|
|
|
|
None => {
|
2022-02-16 13:04:48 -05:00
|
|
|
|
with_no_trimmed_paths!(Symbol::intern(&format!("<impl {}>", self_ty)))
|
2020-09-02 10:40:56 +03:00
|
|
|
|
}
|
2019-04-05 23:04:56 +02:00
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
Ok(path)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn path_append(
|
|
|
|
|
self,
|
|
|
|
|
print_prefix: impl FnOnce(Self) -> Result<Self::Path, Self::Error>,
|
|
|
|
|
disambiguated_data: &DisambiguatedDefPathData,
|
2019-05-14 15:58:22 +02:00
|
|
|
|
) -> Result<Self::Path, Self::Error> {
|
2019-04-05 23:04:56 +02:00
|
|
|
|
let mut path = print_prefix(self)?;
|
|
|
|
|
|
2021-12-17 16:45:15 +08:00
|
|
|
|
// Skip `::{{extern}}` blocks and `::{{constructor}}` on tuple/unit structs.
|
|
|
|
|
if let DefPathData::ForeignMod | DefPathData::Ctor = disambiguated_data.data {
|
2020-03-22 13:36:56 +01:00
|
|
|
|
return Ok(path);
|
2019-04-05 23:04:56 +02:00
|
|
|
|
}
|
|
|
|
|
|
2020-09-01 13:11:28 +01:00
|
|
|
|
path.push(Symbol::intern(&disambiguated_data.data.to_string()));
|
2019-04-05 23:04:56 +02:00
|
|
|
|
Ok(path)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn path_generic_args(
|
|
|
|
|
self,
|
|
|
|
|
print_prefix: impl FnOnce(Self) -> Result<Self::Path, Self::Error>,
|
2019-09-25 16:39:44 +01:00
|
|
|
|
_args: &[GenericArg<'tcx>],
|
2019-05-14 15:58:22 +02:00
|
|
|
|
) -> Result<Self::Path, Self::Error> {
|
2019-04-05 23:04:56 +02:00
|
|
|
|
print_prefix(self)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-12-22 17:42:04 -05:00
|
|
|
|
AbsolutePathPrinter { tcx: self.tcx }.print_def_path(def_id, &[]).unwrap()
|
2019-04-05 23:04:56 +02:00
|
|
|
|
}
|
2019-01-31 01:36:11 +01:00
|
|
|
|
}
|
|
|
|
|
|
2021-08-25 16:40:39 +03:00
|
|
|
|
impl<'tcx> abi::HasDataLayout for LateContext<'tcx> {
|
|
|
|
|
#[inline]
|
|
|
|
|
fn data_layout(&self) -> &abi::TargetDataLayout {
|
|
|
|
|
&self.tcx.data_layout
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl<'tcx> ty::layout::HasTyCtxt<'tcx> for LateContext<'tcx> {
|
|
|
|
|
#[inline]
|
|
|
|
|
fn tcx(&self) -> TyCtxt<'tcx> {
|
|
|
|
|
self.tcx
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl<'tcx> ty::layout::HasParamEnv<'tcx> for LateContext<'tcx> {
|
|
|
|
|
#[inline]
|
|
|
|
|
fn param_env(&self) -> ty::ParamEnv<'tcx> {
|
|
|
|
|
self.param_env
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2021-08-30 20:37:36 +03:00
|
|
|
|
impl<'tcx> LayoutOfHelpers<'tcx> for LateContext<'tcx> {
|
2021-08-30 17:38:27 +03:00
|
|
|
|
type LayoutOfResult = Result<TyAndLayout<'tcx>, LayoutError<'tcx>>;
|
2019-01-31 01:36:11 +01:00
|
|
|
|
|
2021-08-30 18:01:58 +03:00
|
|
|
|
#[inline]
|
|
|
|
|
fn handle_layout_err(&self, err: LayoutError<'tcx>, _: Span, _: Ty<'tcx>) -> LayoutError<'tcx> {
|
|
|
|
|
err
|
2019-01-31 01:36:11 +01:00
|
|
|
|
}
|
|
|
|
|
}
|
2021-06-24 16:38:32 -07:00
|
|
|
|
|
|
|
|
|
pub fn parse_lint_and_tool_name(lint_name: &str) -> (Option<Symbol>, &str) {
|
|
|
|
|
match lint_name.split_once("::") {
|
2021-07-06 17:19:20 -07:00
|
|
|
|
Some((tool_name, lint_name)) => {
|
|
|
|
|
let tool_name = Symbol::intern(tool_name);
|
|
|
|
|
|
|
|
|
|
(Some(tool_name), lint_name)
|
|
|
|
|
}
|
2021-06-24 16:38:32 -07:00
|
|
|
|
None => (None, lint_name),
|
|
|
|
|
}
|
|
|
|
|
}
|