2020-03-06 11:17:12 -03:00
|
|
|
//! See Rustc Dev Guide chapters on [trait-resolution] and [trait-specialization] for more info on
|
|
|
|
//! how this works.
|
2018-02-25 15:24:14 -06:00
|
|
|
//!
|
2020-03-09 18:33:04 -03:00
|
|
|
//! [trait-resolution]: https://rustc-dev-guide.rust-lang.org/traits/resolution.html
|
|
|
|
//! [trait-specialization]: https://rustc-dev-guide.rust-lang.org/traits/specialization.html
|
2014-09-12 10:54:08 -04:00
|
|
|
|
2022-02-02 14:36:45 -03:00
|
|
|
use crate::infer::outlives::env::OutlivesEnvironment;
|
2022-06-13 01:11:16 -04:00
|
|
|
use crate::infer::{CombinedSnapshot, InferOk};
|
2022-08-22 15:52:49 -03:00
|
|
|
use crate::traits::outlives_bounds::InferCtxtExt as _;
|
2019-02-05 11:20:45 -06:00
|
|
|
use crate::traits::select::IntercrateAmbiguityCause;
|
2022-03-24 18:41:30 -03:00
|
|
|
use crate::traits::util::impl_subject_and_oblig;
|
2020-01-24 15:57:01 -05:00
|
|
|
use crate::traits::SkipLeakCheck;
|
2021-10-23 00:03:33 -03:00
|
|
|
use crate::traits::{
|
2022-12-01 18:59:58 +00:00
|
|
|
self, Obligation, ObligationCause, ObligationCtxt, PredicateObligation, PredicateObligations,
|
|
|
|
SelectionContext,
|
2021-10-23 00:03:33 -03:00
|
|
|
};
|
2022-07-10 02:48:53 +09:00
|
|
|
use rustc_data_structures::fx::FxIndexSet;
|
2022-01-23 20:41:46 +00:00
|
|
|
use rustc_errors::Diagnostic;
|
2022-08-23 09:08:30 -03:00
|
|
|
use rustc_hir::def_id::{DefId, CRATE_DEF_ID, LOCAL_CRATE};
|
2023-03-15 14:00:15 +01:00
|
|
|
use rustc_infer::infer::{DefineOpaqueTypes, DefiningAnchor, InferCtxt, TyCtxtInferExt};
|
2022-08-02 06:02:04 +00:00
|
|
|
use rustc_infer::traits::util;
|
2022-01-30 18:55:22 -03:00
|
|
|
use rustc_middle::traits::specialization_graph::OverlapMode;
|
2022-05-24 09:15:19 +02:00
|
|
|
use rustc_middle::ty::fast_reject::{DeepRejectCtxt, TreatParams};
|
2023-02-22 02:18:40 +00:00
|
|
|
use rustc_middle::ty::visit::{TypeVisitable, TypeVisitableExt};
|
|
|
|
use rustc_middle::ty::{self, ImplSubject, Ty, TyCtxt, TypeVisitor};
|
2020-01-01 19:30:57 +01:00
|
|
|
use rustc_span::symbol::sym;
|
2019-12-31 20:15:40 +03:00
|
|
|
use rustc_span::DUMMY_SP;
|
2022-03-18 14:07:22 -03:00
|
|
|
use std::fmt::Debug;
|
2020-03-20 05:28:17 +02:00
|
|
|
use std::iter;
|
2022-07-21 11:51:09 +02:00
|
|
|
use std::ops::ControlFlow;
|
2014-09-12 10:54:08 -04:00
|
|
|
|
2022-12-01 18:59:58 +00:00
|
|
|
use super::NormalizeExt;
|
|
|
|
|
2017-11-22 23:01:51 +02:00
|
|
|
/// Whether we do the orphan check relative to this crate or
|
|
|
|
/// to some remote crate.
|
2017-11-29 20:50:26 +02:00
|
|
|
#[derive(Copy, Clone, Debug)]
|
2017-11-22 23:01:51 +02:00
|
|
|
enum InCrate {
|
|
|
|
Local,
|
|
|
|
Remote,
|
2017-11-22 22:39:40 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(Debug, Copy, Clone)]
|
|
|
|
pub enum Conflict {
|
|
|
|
Upstream,
|
2020-02-08 19:14:50 +01:00
|
|
|
Downstream,
|
2017-11-22 22:39:40 +02:00
|
|
|
}
|
2015-03-30 17:46:34 -04:00
|
|
|
|
2017-07-23 22:30:47 +09:00
|
|
|
pub struct OverlapResult<'tcx> {
|
|
|
|
pub impl_header: ty::ImplHeader<'tcx>,
|
2022-07-10 02:48:53 +09:00
|
|
|
pub intercrate_ambiguity_causes: FxIndexSet<IntercrateAmbiguityCause>,
|
2018-11-20 11:20:05 -05:00
|
|
|
|
2019-02-08 14:53:55 +01:00
|
|
|
/// `true` if the overlap might've been permitted before the shift
|
2018-11-20 11:20:05 -05:00
|
|
|
/// to universes.
|
|
|
|
pub involves_placeholder: bool,
|
|
|
|
}
|
|
|
|
|
2022-01-23 20:41:46 +00:00
|
|
|
pub fn add_placeholder_note(err: &mut Diagnostic) {
|
2020-02-27 13:34:08 +01:00
|
|
|
err.note(
|
2018-11-20 11:20:05 -05:00
|
|
|
"this behavior recently changed as a result of a bug fix; \
|
2020-02-27 13:34:08 +01:00
|
|
|
see rust-lang/rust#56105 for details",
|
|
|
|
);
|
2017-07-23 22:30:47 +09:00
|
|
|
}
|
|
|
|
|
2022-10-11 15:37:11 -05:00
|
|
|
/// If there are types that satisfy both impls, returns `Some`
|
2018-01-29 18:20:24 -05:00
|
|
|
/// with a suitably-freshened `ImplHeader` with those types
|
2022-10-11 15:37:11 -05:00
|
|
|
/// substituted. Otherwise, returns `None`.
|
|
|
|
#[instrument(skip(tcx, skip_leak_check), level = "debug")]
|
2022-12-20 22:10:40 +01:00
|
|
|
pub fn overlapping_impls(
|
|
|
|
tcx: TyCtxt<'_>,
|
2018-01-29 18:20:24 -05:00
|
|
|
impl1_def_id: DefId,
|
|
|
|
impl2_def_id: DefId,
|
2020-01-24 15:57:01 -05:00
|
|
|
skip_leak_check: SkipLeakCheck,
|
2022-01-30 18:55:22 -03:00
|
|
|
overlap_mode: OverlapMode,
|
2022-12-20 22:10:40 +01:00
|
|
|
) -> Option<OverlapResult<'_>> {
|
2021-02-04 10:45:17 +01:00
|
|
|
// Before doing expensive operations like entering an inference context, do
|
|
|
|
// a quick check via fast_reject to tell if the impl headers could possibly
|
|
|
|
// unify.
|
2023-03-12 00:59:54 +00:00
|
|
|
let drcx = DeepRejectCtxt { treat_obligation_params: TreatParams::AsCandidateKey };
|
2023-01-11 11:32:33 -07:00
|
|
|
let impl1_ref = tcx.impl_trait_ref(impl1_def_id);
|
|
|
|
let impl2_ref = tcx.impl_trait_ref(impl2_def_id);
|
2022-05-24 09:15:19 +02:00
|
|
|
let may_overlap = match (impl1_ref, impl2_ref) {
|
2023-01-11 11:32:33 -07:00
|
|
|
(Some(a), Some(b)) => iter::zip(a.skip_binder().substs, b.skip_binder().substs)
|
2022-05-24 09:15:19 +02:00
|
|
|
.all(|(arg1, arg2)| drcx.generic_args_may_unify(arg1, arg2)),
|
|
|
|
(None, None) => {
|
2023-02-07 01:29:48 -07:00
|
|
|
let self_ty1 = tcx.type_of(impl1_def_id).skip_binder();
|
|
|
|
let self_ty2 = tcx.type_of(impl2_def_id).skip_binder();
|
2022-05-24 09:15:19 +02:00
|
|
|
drcx.types_may_unify(self_ty1, self_ty2)
|
2021-03-08 15:32:41 -08:00
|
|
|
}
|
2022-05-24 09:15:19 +02:00
|
|
|
_ => bug!("unexpected impls: {impl1_def_id:?} {impl2_def_id:?}"),
|
|
|
|
};
|
|
|
|
|
|
|
|
if !may_overlap {
|
2021-02-04 10:45:17 +01:00
|
|
|
// Some types involved are definitely different, so the impls couldn't possibly overlap.
|
|
|
|
debug!("overlapping_impls: fast_reject early-exit");
|
2022-10-11 15:37:11 -05:00
|
|
|
return None;
|
2021-02-04 10:45:17 +01:00
|
|
|
}
|
2014-10-09 17:19:50 -04:00
|
|
|
|
2023-03-21 16:34:04 +01:00
|
|
|
let infcx = tcx
|
|
|
|
.infer_ctxt()
|
|
|
|
.with_opaque_type_inference(DefiningAnchor::Bubble)
|
|
|
|
.intercrate(true)
|
|
|
|
.build();
|
2022-10-27 12:00:21 +00:00
|
|
|
let selcx = &mut SelectionContext::new(&infcx);
|
2022-05-24 09:15:19 +02:00
|
|
|
let overlaps =
|
2022-01-30 18:55:22 -03:00
|
|
|
overlap(selcx, skip_leak_check, impl1_def_id, impl2_def_id, overlap_mode).is_some();
|
2018-01-26 17:21:43 -05:00
|
|
|
if !overlaps {
|
2022-10-11 15:37:11 -05:00
|
|
|
return None;
|
2018-01-26 17:21:43 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
// In the case where we detect an error, run the check again, but
|
2022-03-30 15:14:15 -04:00
|
|
|
// this time tracking intercrate ambiguity causes for better
|
2018-01-26 17:21:43 -05:00
|
|
|
// diagnostics. (These take time and can lead to false errors.)
|
2023-03-21 16:34:04 +01:00
|
|
|
let infcx = tcx
|
|
|
|
.infer_ctxt()
|
|
|
|
.with_opaque_type_inference(DefiningAnchor::Bubble)
|
|
|
|
.intercrate(true)
|
|
|
|
.build();
|
2022-10-27 12:00:21 +00:00
|
|
|
let selcx = &mut SelectionContext::new(&infcx);
|
2018-01-26 17:21:43 -05:00
|
|
|
selcx.enable_tracking_intercrate_ambiguity_causes();
|
2022-10-11 15:37:11 -05:00
|
|
|
Some(overlap(selcx, skip_leak_check, impl1_def_id, impl2_def_id, overlap_mode).unwrap())
|
2015-02-12 12:42:02 -05:00
|
|
|
}
|
|
|
|
|
2019-06-14 01:32:15 +03:00
|
|
|
fn with_fresh_ty_vars<'cx, 'tcx>(
|
|
|
|
selcx: &mut SelectionContext<'cx, 'tcx>,
|
|
|
|
param_env: ty::ParamEnv<'tcx>,
|
|
|
|
impl_def_id: DefId,
|
|
|
|
) -> ty::ImplHeader<'tcx> {
|
2017-05-23 04:19:47 -04:00
|
|
|
let tcx = selcx.tcx();
|
2022-11-25 23:31:28 +00:00
|
|
|
let impl_substs = selcx.infcx.fresh_substs_for_item(DUMMY_SP, impl_def_id);
|
2017-05-23 04:19:47 -04:00
|
|
|
|
|
|
|
let header = ty::ImplHeader {
|
2017-07-03 11:19:51 -07:00
|
|
|
impl_def_id,
|
2023-02-07 01:29:48 -07:00
|
|
|
self_ty: tcx.type_of(impl_def_id).subst(tcx, impl_substs),
|
2023-01-10 14:57:22 -07:00
|
|
|
trait_ref: tcx.impl_trait_ref(impl_def_id).map(|i| i.subst(tcx, impl_substs)),
|
2018-09-16 20:15:49 +03:00
|
|
|
predicates: tcx.predicates_of(impl_def_id).instantiate(tcx, impl_substs).predicates,
|
|
|
|
};
|
2017-05-23 04:19:47 -04:00
|
|
|
|
2022-12-01 18:59:58 +00:00
|
|
|
let InferOk { value: mut header, obligations } =
|
|
|
|
selcx.infcx.at(&ObligationCause::dummy(), param_env).normalize(header);
|
2017-05-23 04:19:47 -04:00
|
|
|
|
|
|
|
header.predicates.extend(obligations.into_iter().map(|o| o.predicate));
|
|
|
|
header
|
|
|
|
}
|
|
|
|
|
2015-12-01 11:26:47 -08:00
|
|
|
/// Can both impl `a` and impl `b` be satisfied by a common type (including
|
2019-02-08 14:53:55 +01:00
|
|
|
/// where-clauses)? If so, returns an `ImplHeader` that unifies the two impls.
|
2019-06-14 00:48:52 +03:00
|
|
|
fn overlap<'cx, 'tcx>(
|
|
|
|
selcx: &mut SelectionContext<'cx, 'tcx>,
|
2020-01-24 15:57:01 -05:00
|
|
|
skip_leak_check: SkipLeakCheck,
|
2022-01-21 10:50:42 -03:00
|
|
|
impl1_def_id: DefId,
|
|
|
|
impl2_def_id: DefId,
|
2022-01-30 18:55:22 -03:00
|
|
|
overlap_mode: OverlapMode,
|
2018-11-20 11:20:05 -05:00
|
|
|
) -> Option<OverlapResult<'tcx>> {
|
2022-02-03 22:40:29 -03:00
|
|
|
debug!(
|
|
|
|
"overlap(impl1_def_id={:?}, impl2_def_id={:?}, overlap_mode={:?})",
|
|
|
|
impl1_def_id, impl2_def_id, overlap_mode
|
|
|
|
);
|
2015-02-23 13:02:31 -05:00
|
|
|
|
2022-11-25 23:31:28 +00:00
|
|
|
selcx.infcx.probe_maybe_skip_leak_check(skip_leak_check.is_yes(), |snapshot| {
|
2022-02-21 10:40:41 +01:00
|
|
|
overlap_within_probe(selcx, impl1_def_id, impl2_def_id, overlap_mode, snapshot)
|
2020-01-24 15:57:01 -05:00
|
|
|
})
|
2018-11-20 11:20:05 -05:00
|
|
|
}
|
|
|
|
|
2021-12-14 09:44:49 +00:00
|
|
|
fn overlap_within_probe<'cx, 'tcx>(
|
2019-06-14 00:48:52 +03:00
|
|
|
selcx: &mut SelectionContext<'cx, 'tcx>,
|
2022-01-21 10:50:42 -03:00
|
|
|
impl1_def_id: DefId,
|
|
|
|
impl2_def_id: DefId,
|
2022-01-30 18:55:22 -03:00
|
|
|
overlap_mode: OverlapMode,
|
2022-09-09 13:01:06 -05:00
|
|
|
snapshot: &CombinedSnapshot<'tcx>,
|
2018-11-20 11:20:05 -05:00
|
|
|
) -> Option<OverlapResult<'tcx>> {
|
2022-11-25 23:31:28 +00:00
|
|
|
let infcx = selcx.infcx;
|
2022-01-22 18:16:11 -03:00
|
|
|
|
|
|
|
if overlap_mode.use_negative_impl() {
|
2022-11-21 11:04:55 -03:00
|
|
|
if negative_impl(infcx.tcx, impl1_def_id, impl2_def_id)
|
|
|
|
|| negative_impl(infcx.tcx, impl2_def_id, impl1_def_id)
|
2022-01-22 18:16:11 -03:00
|
|
|
{
|
|
|
|
return None;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-09-07 09:46:53 -04:00
|
|
|
// For the purposes of this check, we don't bring any placeholder
|
2017-05-23 04:19:47 -04:00
|
|
|
// types into scope; instead, we replace the generic types with
|
|
|
|
// fresh type variables, and hence we do our evaluations in an
|
|
|
|
// empty environment.
|
2018-02-10 13:18:02 -05:00
|
|
|
let param_env = ty::ParamEnv::empty();
|
2017-05-23 04:19:47 -04:00
|
|
|
|
2022-01-21 10:50:42 -03:00
|
|
|
let impl1_header = with_fresh_ty_vars(selcx, param_env, impl1_def_id);
|
|
|
|
let impl2_header = with_fresh_ty_vars(selcx, param_env, impl2_def_id);
|
2015-03-30 17:46:34 -04:00
|
|
|
|
2023-03-15 14:00:15 +01:00
|
|
|
let obligations = equate_impl_headers(selcx.infcx, &impl1_header, &impl2_header)?;
|
2022-01-22 18:16:11 -03:00
|
|
|
debug!("overlap: unification check succeeded");
|
|
|
|
|
|
|
|
if overlap_mode.use_implicit_negative() {
|
|
|
|
if implicit_negative(selcx, param_env, &impl1_header, impl2_header, obligations) {
|
|
|
|
return None;
|
2022-01-21 12:53:50 -03:00
|
|
|
}
|
2022-01-21 11:02:52 -03:00
|
|
|
}
|
|
|
|
|
2022-10-14 00:25:34 +08:00
|
|
|
// We disable the leak when creating the `snapshot` by using
|
2022-02-21 10:40:41 +01:00
|
|
|
// `infcx.probe_maybe_disable_leak_check`.
|
|
|
|
if infcx.leak_check(true, snapshot).is_err() {
|
|
|
|
debug!("overlap: leak check failed");
|
|
|
|
return None;
|
2022-01-21 11:02:52 -03:00
|
|
|
}
|
|
|
|
|
|
|
|
let intercrate_ambiguity_causes = selcx.take_intercrate_ambiguity_causes();
|
|
|
|
debug!("overlap: intercrate_ambiguity_causes={:#?}", intercrate_ambiguity_causes);
|
|
|
|
|
|
|
|
let involves_placeholder =
|
2022-11-25 23:31:28 +00:00
|
|
|
matches!(selcx.infcx.region_constraints_added_in_snapshot(snapshot), Some(true));
|
2022-01-21 11:02:52 -03:00
|
|
|
|
2022-11-25 23:31:28 +00:00
|
|
|
let impl_header = selcx.infcx.resolve_vars_if_possible(impl1_header);
|
2022-01-21 11:02:52 -03:00
|
|
|
Some(OverlapResult { impl_header, intercrate_ambiguity_causes, involves_placeholder })
|
|
|
|
}
|
|
|
|
|
2023-03-15 14:00:15 +01:00
|
|
|
#[instrument(level = "debug", skip(infcx), ret)]
|
|
|
|
fn equate_impl_headers<'tcx>(
|
|
|
|
infcx: &InferCtxt<'tcx>,
|
|
|
|
impl1: &ty::ImplHeader<'tcx>,
|
|
|
|
impl2: &ty::ImplHeader<'tcx>,
|
2022-01-22 18:16:11 -03:00
|
|
|
) -> Option<PredicateObligations<'tcx>> {
|
2023-03-15 14:00:15 +01:00
|
|
|
let result = match (impl1.trait_ref, impl2.trait_ref) {
|
|
|
|
(Some(impl1_ref), Some(impl2_ref)) => infcx
|
|
|
|
.at(&ObligationCause::dummy(), ty::ParamEnv::empty())
|
|
|
|
.eq(DefineOpaqueTypes::Yes, impl1_ref, impl2_ref),
|
|
|
|
(None, None) => infcx.at(&ObligationCause::dummy(), ty::ParamEnv::empty()).eq(
|
|
|
|
DefineOpaqueTypes::Yes,
|
|
|
|
impl1.self_ty,
|
|
|
|
impl2.self_ty,
|
|
|
|
),
|
|
|
|
_ => bug!("mk_eq_impl_headers given mismatched impl kinds"),
|
|
|
|
};
|
|
|
|
|
|
|
|
result.map(|infer_ok| infer_ok.obligations).ok()
|
2022-01-22 18:16:11 -03:00
|
|
|
}
|
|
|
|
|
2022-01-21 11:02:52 -03:00
|
|
|
/// Given impl1 and impl2 check if both impls can be satisfied by a common type (including
|
|
|
|
/// where-clauses) If so, return false, otherwise return true, they are disjoint.
|
2022-01-22 18:16:11 -03:00
|
|
|
fn implicit_negative<'cx, 'tcx>(
|
2022-01-21 11:02:52 -03:00
|
|
|
selcx: &mut SelectionContext<'cx, 'tcx>,
|
|
|
|
param_env: ty::ParamEnv<'tcx>,
|
|
|
|
impl1_header: &ty::ImplHeader<'tcx>,
|
|
|
|
impl2_header: ty::ImplHeader<'tcx>,
|
2022-01-22 18:16:11 -03:00
|
|
|
obligations: PredicateObligations<'tcx>,
|
2022-01-21 11:02:52 -03:00
|
|
|
) -> bool {
|
2021-10-22 09:22:19 -03:00
|
|
|
// There's no overlap if obligations are unsatisfiable or if the obligation negated is
|
|
|
|
// satisfied.
|
|
|
|
//
|
|
|
|
// For example, given these two impl headers:
|
|
|
|
//
|
|
|
|
// `impl<'a> From<&'a str> for Box<dyn Error>`
|
|
|
|
// `impl<E> From<E> for Box<dyn Error> where E: Error`
|
|
|
|
//
|
|
|
|
// So we have:
|
|
|
|
//
|
|
|
|
// `Box<dyn Error>: From<&'?a str>`
|
|
|
|
// `Box<dyn Error>: From<?E>`
|
|
|
|
//
|
|
|
|
// After equating the two headers:
|
|
|
|
//
|
|
|
|
// `Box<dyn Error> = Box<dyn Error>`
|
|
|
|
// So, `?E = &'?a str` and then given the where clause `&'?a str: Error`.
|
|
|
|
//
|
|
|
|
// If the obligation `&'?a str: Error` holds, it means that there's overlap. If that doesn't
|
|
|
|
// hold we need to check if `&'?a str: !Error` holds, if doesn't hold there's overlap because
|
|
|
|
// at some point an impl for `&'?a str: Error` could be added.
|
2022-02-03 22:40:29 -03:00
|
|
|
debug!(
|
|
|
|
"implicit_negative(impl1_header={:?}, impl2_header={:?}, obligations={:?})",
|
|
|
|
impl1_header, impl2_header, obligations
|
|
|
|
);
|
2022-11-25 23:31:28 +00:00
|
|
|
let infcx = selcx.infcx;
|
2022-01-21 10:50:42 -03:00
|
|
|
let opt_failing_obligation = impl1_header
|
2016-02-26 13:21:44 -08:00
|
|
|
.predicates
|
2016-02-26 10:51:10 -08:00
|
|
|
.iter()
|
2020-10-24 02:21:18 +02:00
|
|
|
.copied()
|
2022-01-21 10:50:42 -03:00
|
|
|
.chain(impl2_header.predicates)
|
2019-05-11 19:08:26 +01:00
|
|
|
.map(|p| infcx.resolve_vars_if_possible(p))
|
2016-02-26 10:51:10 -08:00
|
|
|
.map(|p| Obligation {
|
|
|
|
cause: ObligationCause::dummy(),
|
2017-07-03 11:19:51 -07:00
|
|
|
param_env,
|
2016-02-26 10:51:10 -08:00
|
|
|
recursion_depth: 0,
|
|
|
|
predicate: p,
|
|
|
|
})
|
2017-04-18 15:48:19 -04:00
|
|
|
.chain(obligations)
|
2022-02-10 16:39:52 -03:00
|
|
|
.find(|o| !selcx.predicate_may_hold_fatal(o));
|
2015-02-23 13:02:31 -05:00
|
|
|
|
|
|
|
if let Some(failing_obligation) = opt_failing_obligation {
|
2015-06-18 20:25:05 +03:00
|
|
|
debug!("overlap: obligation unsatisfiable {:?}", failing_obligation);
|
2022-01-21 11:02:52 -03:00
|
|
|
true
|
|
|
|
} else {
|
|
|
|
false
|
move leak-check to during coherence, candidate eval
In particular, it no longer occurs during the subtyping check. This is
important for enabling lazy normalization, because the subtyping check
will be producing sub-obligations that could affect its results.
Consider an example like
for<'a> fn(<&'a as Mirror>::Item) =
fn(&'b u8)
where `<T as Mirror>::Item = T` for all `T`. We will wish to produce a
new subobligation like
<'!1 as Mirror>::Item = &'b u8
This will, after being solved, ultimately yield a constraint that `'!1
= 'b` which will fail. But with the leak-check being performed on
subtyping, there is no opportunity to normalize `<'!1 as
Mirror>::Item` (unless we invoke that normalization directly from
within subtyping, and I would prefer that subtyping and unification
are distinct operations rather than part of the trait solving stack).
The reason to keep the leak check during coherence and trait
evaluation is partly for backwards compatibility. The coherence change
permits impls for `fn(T)` and `fn(&T)` to co-exist, and the trait
evaluation change means that we can distinguish those two cases
without ambiguity errors. It also avoids recreating #57639, where we
were incorrectly choosing a where clause that would have failed the
leak check over the impl which succeeds.
The other reason to keep the leak check in those places is that I
think it is actually close to the model we want. To the point, I think
the trait solver ought to have the job of "breaking down"
higher-ranked region obligation like ``!1: '2` into into region
obligations that operate on things in the root universe, at which
point they should be handed off to polonius. The leak check isn't
*really* doing that -- these obligations are still handed to the
region solver to process -- but if/when we do adopt that model, the
decision to pass/fail would be happening in roughly this part of the
code.
This change had somewhat more side-effects than I anticipated. It
seems like there are cases where the leak-check was not being enforced
during method proving and trait selection. I haven't quite tracked
this down but I think it ought to be documented, so that we know what
precisely we are committing to.
One surprising test was `issue-30786.rs`. The behavior there seems a
bit "fishy" to me, but the problem is not related to the leak check
change as far as I can tell, but more to do with the closure signature
inference code and perhaps the associated type projection, which
together seem to be conspiring to produce an unexpected
signature. Nonetheless, it is an example of where changing the
leak-check can have some unexpected consequences: we're now failing to
resolve a method earlier than we were, which suggests we might change
some method resolutions that would have been ambiguous to be
successful.
TODO:
* figure out remainig test failures
* add new coherence tests for the patterns we ARE disallowing
2020-05-20 10:19:36 +00:00
|
|
|
}
|
2015-02-12 12:42:02 -05:00
|
|
|
}
|
|
|
|
|
2022-01-21 12:53:50 -03:00
|
|
|
/// Given impl1 and impl2 check if both impls are never satisfied by a common type (including
|
|
|
|
/// where-clauses) If so, return true, they are disjoint and false otherwise.
|
2022-12-20 22:10:40 +01:00
|
|
|
fn negative_impl(tcx: TyCtxt<'_>, impl1_def_id: DefId, impl2_def_id: DefId) -> bool {
|
2022-02-03 22:40:29 -03:00
|
|
|
debug!("negative_impl(impl1_def_id={:?}, impl2_def_id={:?})", impl1_def_id, impl2_def_id);
|
2022-01-21 12:53:50 -03:00
|
|
|
|
|
|
|
// Create an infcx, taking the predicates of impl1 as assumptions:
|
|
|
|
let infcx = tcx.infer_ctxt().build();
|
2022-03-17 22:51:45 -03:00
|
|
|
// create a parameter environment corresponding to a (placeholder) instantiation of impl1
|
2022-03-24 12:27:09 -03:00
|
|
|
let impl_env = tcx.param_env(impl1_def_id);
|
2022-03-24 14:17:54 -03:00
|
|
|
let subject1 = match traits::fully_normalize(
|
|
|
|
&infcx,
|
|
|
|
ObligationCause::dummy(),
|
|
|
|
impl_env,
|
|
|
|
tcx.impl_subject(impl1_def_id),
|
|
|
|
) {
|
|
|
|
Ok(s) => s,
|
2022-08-13 22:04:50 +00:00
|
|
|
Err(err) => {
|
|
|
|
tcx.sess.delay_span_bug(
|
|
|
|
tcx.def_span(impl1_def_id),
|
|
|
|
format!("failed to fully normalize {:?}: {:?}", impl1_def_id, err),
|
|
|
|
);
|
|
|
|
return false;
|
|
|
|
}
|
2022-03-24 12:27:09 -03:00
|
|
|
};
|
2022-09-19 22:03:59 -05:00
|
|
|
|
2022-03-24 12:27:09 -03:00
|
|
|
// Attempt to prove that impl2 applies, given all of the above.
|
|
|
|
let selcx = &mut SelectionContext::new(&infcx);
|
|
|
|
let impl2_substs = infcx.fresh_substs_for_item(DUMMY_SP, impl2_def_id);
|
2022-03-24 18:41:30 -03:00
|
|
|
let (subject2, obligations) =
|
|
|
|
impl_subject_and_oblig(selcx, impl_env, impl2_def_id, impl2_substs);
|
2022-09-19 22:03:59 -05:00
|
|
|
|
2022-08-22 15:52:49 -03:00
|
|
|
!equate(&infcx, impl_env, subject1, subject2, obligations, impl1_def_id)
|
2022-03-24 12:27:09 -03:00
|
|
|
}
|
|
|
|
|
2022-09-09 13:01:06 -05:00
|
|
|
fn equate<'tcx>(
|
|
|
|
infcx: &InferCtxt<'tcx>,
|
2022-03-24 12:27:09 -03:00
|
|
|
impl_env: ty::ParamEnv<'tcx>,
|
|
|
|
subject1: ImplSubject<'tcx>,
|
|
|
|
subject2: ImplSubject<'tcx>,
|
2022-03-18 14:07:22 -03:00
|
|
|
obligations: impl Iterator<Item = PredicateObligation<'tcx>>,
|
2022-08-22 15:52:49 -03:00
|
|
|
body_def_id: DefId,
|
2022-03-18 14:07:22 -03:00
|
|
|
) -> bool {
|
|
|
|
// do the impls unify? If not, not disjoint.
|
2022-03-24 12:27:09 -03:00
|
|
|
let Ok(InferOk { obligations: more_obligations, .. }) =
|
2023-03-15 14:00:15 +01:00
|
|
|
infcx.at(&ObligationCause::dummy(), impl_env).eq(DefineOpaqueTypes::No,subject1, subject2)
|
2022-03-24 12:27:09 -03:00
|
|
|
else {
|
|
|
|
debug!("explicit_disjoint: {:?} does not unify with {:?}", subject1, subject2);
|
|
|
|
return true;
|
|
|
|
};
|
2022-03-18 14:07:22 -03:00
|
|
|
|
2022-08-22 15:52:49 -03:00
|
|
|
let opt_failing_obligation = obligations
|
|
|
|
.into_iter()
|
|
|
|
.chain(more_obligations)
|
2022-11-21 11:26:23 -03:00
|
|
|
.find(|o| negative_impl_exists(infcx, o, body_def_id));
|
2022-03-18 14:07:22 -03:00
|
|
|
|
|
|
|
if let Some(failing_obligation) = opt_failing_obligation {
|
|
|
|
debug!("overlap: obligation unsatisfiable {:?}", failing_obligation);
|
|
|
|
false
|
|
|
|
} else {
|
|
|
|
true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-03-18 14:13:06 -03:00
|
|
|
/// Try to prove that a negative impl exist for the given obligation and its super predicates.
|
2022-11-21 11:26:23 -03:00
|
|
|
#[instrument(level = "debug", skip(infcx))]
|
|
|
|
fn negative_impl_exists<'tcx>(
|
|
|
|
infcx: &InferCtxt<'tcx>,
|
2022-01-21 10:53:17 -03:00
|
|
|
o: &PredicateObligation<'tcx>,
|
2022-08-22 15:52:49 -03:00
|
|
|
body_def_id: DefId,
|
2022-01-21 10:53:17 -03:00
|
|
|
) -> bool {
|
2022-11-21 11:26:23 -03:00
|
|
|
if resolve_negative_obligation(infcx.fork(), o, body_def_id) {
|
2022-03-17 12:09:00 -03:00
|
|
|
return true;
|
|
|
|
}
|
2022-03-17 11:26:45 -03:00
|
|
|
|
2022-03-18 14:13:06 -03:00
|
|
|
// Try to prove a negative obligation exists for super predicates
|
2022-11-21 11:26:23 -03:00
|
|
|
for o in util::elaborate_predicates(infcx.tcx, iter::once(o.predicate)) {
|
|
|
|
if resolve_negative_obligation(infcx.fork(), &o, body_def_id) {
|
2022-03-17 12:09:00 -03:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
2022-02-02 14:36:45 -03:00
|
|
|
|
2022-03-17 12:09:00 -03:00
|
|
|
false
|
|
|
|
}
|
2022-03-17 11:26:45 -03:00
|
|
|
|
2022-03-17 12:09:00 -03:00
|
|
|
#[instrument(level = "debug", skip(infcx))]
|
2022-09-09 13:01:06 -05:00
|
|
|
fn resolve_negative_obligation<'tcx>(
|
|
|
|
infcx: InferCtxt<'tcx>,
|
2022-03-17 12:09:00 -03:00
|
|
|
o: &PredicateObligation<'tcx>,
|
2022-08-22 15:52:49 -03:00
|
|
|
body_def_id: DefId,
|
2022-03-17 12:09:00 -03:00
|
|
|
) -> bool {
|
|
|
|
let tcx = infcx.tcx;
|
2022-02-02 14:36:45 -03:00
|
|
|
|
2022-03-17 14:55:16 -03:00
|
|
|
let Some(o) = o.flip_polarity(tcx) else {
|
|
|
|
return false;
|
|
|
|
};
|
2022-02-10 16:38:27 -03:00
|
|
|
|
2022-08-20 03:23:23 +00:00
|
|
|
let param_env = o.param_env;
|
2023-03-14 14:19:06 +01:00
|
|
|
let ocx = ObligationCtxt::new(&infcx);
|
|
|
|
ocx.register_obligation(o);
|
|
|
|
let errors = ocx.select_all_or_error();
|
|
|
|
if !errors.is_empty() {
|
2022-03-17 14:55:16 -03:00
|
|
|
return false;
|
|
|
|
}
|
2022-03-17 11:26:45 -03:00
|
|
|
|
2023-01-15 12:58:46 +01:00
|
|
|
let body_def_id = body_def_id.as_local().unwrap_or(CRATE_DEF_ID);
|
2022-08-22 15:52:49 -03:00
|
|
|
|
2022-08-23 09:08:30 -03:00
|
|
|
let ocx = ObligationCtxt::new(&infcx);
|
|
|
|
let wf_tys = ocx.assumed_wf_types(param_env, DUMMY_SP, body_def_id);
|
|
|
|
let outlives_env = OutlivesEnvironment::with_bounds(
|
|
|
|
param_env,
|
2023-03-15 15:09:29 +00:00
|
|
|
Some(&infcx),
|
2023-01-15 12:58:46 +01:00
|
|
|
infcx.implied_bounds_tys(param_env, body_def_id, wf_tys),
|
2022-08-23 09:08:30 -03:00
|
|
|
);
|
|
|
|
|
2022-06-29 18:04:58 +02:00
|
|
|
infcx.process_registered_region_obligations(outlives_env.region_bound_pairs(), param_env);
|
2022-03-17 12:09:00 -03:00
|
|
|
|
2022-07-29 06:17:17 +00:00
|
|
|
infcx.resolve_regions(&outlives_env).is_empty()
|
2022-01-21 10:53:17 -03:00
|
|
|
}
|
|
|
|
|
2023-01-17 09:39:35 +00:00
|
|
|
#[instrument(level = "debug", skip(tcx), ret)]
|
2019-06-14 00:48:52 +03:00
|
|
|
pub fn trait_ref_is_knowable<'tcx>(
|
|
|
|
tcx: TyCtxt<'tcx>,
|
2019-06-12 00:11:55 +03:00
|
|
|
trait_ref: ty::TraitRef<'tcx>,
|
2022-08-13 13:35:27 +02:00
|
|
|
) -> Result<(), Conflict> {
|
2023-01-17 09:39:35 +00:00
|
|
|
if orphan_check_trait_ref(trait_ref, InCrate::Remote).is_ok() {
|
2017-11-22 22:39:40 +02:00
|
|
|
// A downstream or cousin crate is allowed to implement some
|
|
|
|
// substitution of this trait-ref.
|
2022-08-13 13:35:27 +02:00
|
|
|
return Err(Conflict::Downstream);
|
2017-11-28 14:52:34 +02:00
|
|
|
}
|
|
|
|
|
2017-11-22 22:39:40 +02:00
|
|
|
if trait_ref_is_local_or_fundamental(tcx, trait_ref) {
|
|
|
|
// This is a local or fundamental trait, so future-compatibility
|
|
|
|
// is no concern. We know that downstream/cousin crates are not
|
|
|
|
// allowed to implement a substitution of this trait ref, which
|
|
|
|
// means impls could only come from dependencies of this crate,
|
|
|
|
// which we already know about.
|
2022-08-13 13:35:27 +02:00
|
|
|
return Ok(());
|
2017-11-22 22:39:40 +02:00
|
|
|
}
|
2017-11-22 23:01:51 +02:00
|
|
|
|
2017-11-22 22:39:40 +02:00
|
|
|
// This is a remote non-fundamental trait, so if another crate
|
|
|
|
// can be the "final owner" of a substitution of this trait-ref,
|
|
|
|
// they are allowed to implement it future-compatibly.
|
|
|
|
//
|
|
|
|
// However, if we are a final owner, then nobody else can be,
|
|
|
|
// and if we are an intermediate owner, then we don't care
|
|
|
|
// about future-compatibility, which means that we're OK if
|
|
|
|
// we are an owner.
|
2023-01-17 09:39:35 +00:00
|
|
|
if orphan_check_trait_ref(trait_ref, InCrate::Local).is_ok() {
|
2022-08-13 13:35:27 +02:00
|
|
|
Ok(())
|
2017-11-22 22:39:40 +02:00
|
|
|
} else {
|
2022-08-13 13:35:27 +02:00
|
|
|
Err(Conflict::Upstream)
|
2015-03-30 17:46:34 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-06-14 00:48:52 +03:00
|
|
|
pub fn trait_ref_is_local_or_fundamental<'tcx>(
|
|
|
|
tcx: TyCtxt<'tcx>,
|
2019-06-12 00:11:55 +03:00
|
|
|
trait_ref: ty::TraitRef<'tcx>,
|
|
|
|
) -> bool {
|
2019-05-08 13:21:18 +10:00
|
|
|
trait_ref.def_id.krate == LOCAL_CRATE || tcx.has_attr(trait_ref.def_id, sym::fundamental)
|
2017-08-28 16:50:41 -04:00
|
|
|
}
|
|
|
|
|
2023-01-17 09:39:35 +00:00
|
|
|
#[derive(Debug)]
|
Implement new orphan rule that requires that impls of remote traits meet the following two criteria:
- the self type includes some local type; and,
- type parameters in the self type must be constrained by a local type.
A type parameter is called *constrained* if it appears in some type-parameter of a local type.
Here are some examples that are accepted. In all of these examples, I
assume that `Foo` is a trait defined in another crate. If `Foo` were
defined in the local crate, then all the examples would be legal.
- `impl Foo for LocalType`
- `impl<T> Foo<T> for LocalType` -- T does not appear in Self, so it is OK
- `impl<T> Foo<T> for LocalType<T>` -- T here is constrained by LocalType
- `impl<T> Foo<T> for (LocalType<T>, T)` -- T here is constrained by LocalType
Here are some illegal examples (again, these examples assume that
`Foo` is not local to the current crate):
- `impl Foo for int` -- the Self type is not local
- `impl<T> Foo for T` -- T appears in Self unconstrained by a local type
- `impl<T> Foo for (LocalType, T)` -- T appears in Self unconstrained by a local type
This is a [breaking-change]. For the time being, you can opt out of
the new rules by placing `#[old_orphan_check]` on the trait (and
enabling the feature gate where the trait is defined). Longer term,
you should restructure your traits to avoid the problem. Usually this
means changing the order of parameters so that the "central" type
parameter is in the `Self` position.
As an example of that refactoring, consider the `BorrowFrom` trait:
```rust
pub trait BorrowFrom<Sized? Owned> for Sized? {
fn borrow_from(owned: &Owned) -> &Self;
}
```
As defined, this trait is commonly implemented for custom pointer
types, such as `Arc`. Those impls follow the pattern:
```rust
impl<T> BorrowFrom<Arc<T>> for T {...}
```
Unfortunately, this impl is illegal because the self type `T` is not
local to the current crate. Therefore, we are going to change the order of the parameters,
so that `BorrowFrom` becomes `Borrow`:
```rust
pub trait Borrow<Sized? Borrowed> for Sized? {
fn borrow_from(owned: &Self) -> &Borrowed;
}
```
Now the `Arc` impl is written:
```rust
impl<T> Borrow<T> for Arc<T> { ... }
```
This impl is legal because the self type (`Arc<T>`) is local.
2015-01-04 20:35:06 -05:00
|
|
|
pub enum OrphanCheckErr<'tcx> {
|
2019-10-27 10:22:22 -07:00
|
|
|
NonLocalInputType(Vec<(Ty<'tcx>, bool /* Is this the first input type? */)>),
|
2019-11-09 17:32:15 +01:00
|
|
|
UncoveredTy(Ty<'tcx>, Option<Ty<'tcx>>),
|
Fix orphan checking (cc #19470). (This is not a complete fix of #19470 because of the backwards compatibility feature gate.)
This is a [breaking-change]. The new rules require that, for an impl of a trait defined
in some other crate, two conditions must hold:
1. Some type must be local.
2. Every type parameter must appear "under" some local type.
Here are some examples that are legal:
```rust
struct MyStruct<T> { ... }
// Here `T` appears "under' `MyStruct`.
impl<T> Clone for MyStruct<T> { }
// Here `T` appears "under' `MyStruct` as well. Note that it also appears
// elsewhere.
impl<T> Iterator<T> for MyStruct<T> { }
```
Here is an illegal example:
```rust
// Here `U` does not appear "under" `MyStruct` or any other local type.
// We call `U` "uncovered".
impl<T,U> Iterator<U> for MyStruct<T> { }
```
There are a couple of ways to rewrite this last example so that it is
legal:
1. In some cases, the uncovered type parameter (here, `U`) should be converted
into an associated type. This is however a non-local change that requires access
to the original trait. Also, associated types are not fully baked.
2. Add `U` as a type parameter of `MyStruct`:
```rust
struct MyStruct<T,U> { ... }
impl<T,U> Iterator<U> for MyStruct<T,U> { }
```
3. Create a newtype wrapper for `U`
```rust
impl<T,U> Iterator<Wrapper<U>> for MyStruct<T,U> { }
```
Because associated types are not fully baked, which in the case of the
`Hash` trait makes adhering to this rule impossible, you can
temporarily disable this rule in your crate by using
`#![feature(old_orphan_check)]`. Note that the `old_orphan_check`
feature will be removed before 1.0 is released.
2014-12-26 03:30:51 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
/// Checks the coherence orphan rules. `impl_def_id` should be the
|
2019-02-08 14:53:55 +01:00
|
|
|
/// `DefId` of a trait impl. To pass, either the trait must be local, or else
|
Fix orphan checking (cc #19470). (This is not a complete fix of #19470 because of the backwards compatibility feature gate.)
This is a [breaking-change]. The new rules require that, for an impl of a trait defined
in some other crate, two conditions must hold:
1. Some type must be local.
2. Every type parameter must appear "under" some local type.
Here are some examples that are legal:
```rust
struct MyStruct<T> { ... }
// Here `T` appears "under' `MyStruct`.
impl<T> Clone for MyStruct<T> { }
// Here `T` appears "under' `MyStruct` as well. Note that it also appears
// elsewhere.
impl<T> Iterator<T> for MyStruct<T> { }
```
Here is an illegal example:
```rust
// Here `U` does not appear "under" `MyStruct` or any other local type.
// We call `U` "uncovered".
impl<T,U> Iterator<U> for MyStruct<T> { }
```
There are a couple of ways to rewrite this last example so that it is
legal:
1. In some cases, the uncovered type parameter (here, `U`) should be converted
into an associated type. This is however a non-local change that requires access
to the original trait. Also, associated types are not fully baked.
2. Add `U` as a type parameter of `MyStruct`:
```rust
struct MyStruct<T,U> { ... }
impl<T,U> Iterator<U> for MyStruct<T,U> { }
```
3. Create a newtype wrapper for `U`
```rust
impl<T,U> Iterator<Wrapper<U>> for MyStruct<T,U> { }
```
Because associated types are not fully baked, which in the case of the
`Hash` trait makes adhering to this rule impossible, you can
temporarily disable this rule in your crate by using
`#![feature(old_orphan_check)]`. Note that the `old_orphan_check`
feature will be removed before 1.0 is released.
2014-12-26 03:30:51 -05:00
|
|
|
/// two conditions must be satisfied:
|
|
|
|
///
|
Implement new orphan rule that requires that impls of remote traits meet the following two criteria:
- the self type includes some local type; and,
- type parameters in the self type must be constrained by a local type.
A type parameter is called *constrained* if it appears in some type-parameter of a local type.
Here are some examples that are accepted. In all of these examples, I
assume that `Foo` is a trait defined in another crate. If `Foo` were
defined in the local crate, then all the examples would be legal.
- `impl Foo for LocalType`
- `impl<T> Foo<T> for LocalType` -- T does not appear in Self, so it is OK
- `impl<T> Foo<T> for LocalType<T>` -- T here is constrained by LocalType
- `impl<T> Foo<T> for (LocalType<T>, T)` -- T here is constrained by LocalType
Here are some illegal examples (again, these examples assume that
`Foo` is not local to the current crate):
- `impl Foo for int` -- the Self type is not local
- `impl<T> Foo for T` -- T appears in Self unconstrained by a local type
- `impl<T> Foo for (LocalType, T)` -- T appears in Self unconstrained by a local type
This is a [breaking-change]. For the time being, you can opt out of
the new rules by placing `#[old_orphan_check]` on the trait (and
enabling the feature gate where the trait is defined). Longer term,
you should restructure your traits to avoid the problem. Usually this
means changing the order of parameters so that the "central" type
parameter is in the `Self` position.
As an example of that refactoring, consider the `BorrowFrom` trait:
```rust
pub trait BorrowFrom<Sized? Owned> for Sized? {
fn borrow_from(owned: &Owned) -> &Self;
}
```
As defined, this trait is commonly implemented for custom pointer
types, such as `Arc`. Those impls follow the pattern:
```rust
impl<T> BorrowFrom<Arc<T>> for T {...}
```
Unfortunately, this impl is illegal because the self type `T` is not
local to the current crate. Therefore, we are going to change the order of the parameters,
so that `BorrowFrom` becomes `Borrow`:
```rust
pub trait Borrow<Sized? Borrowed> for Sized? {
fn borrow_from(owned: &Self) -> &Borrowed;
}
```
Now the `Arc` impl is written:
```rust
impl<T> Borrow<T> for Arc<T> { ... }
```
This impl is legal because the self type (`Arc<T>`) is local.
2015-01-04 20:35:06 -05:00
|
|
|
/// 1. All type parameters in `Self` must be "covered" by some local type constructor.
|
|
|
|
/// 2. Some local type must appear in `Self`.
|
2023-01-17 09:39:35 +00:00
|
|
|
#[instrument(level = "debug", skip(tcx), ret)]
|
2019-06-21 18:12:39 +02:00
|
|
|
pub fn orphan_check(tcx: TyCtxt<'_>, impl_def_id: DefId) -> Result<(), OrphanCheckErr<'_>> {
|
2014-09-12 10:54:08 -04:00
|
|
|
// We only except this routine to be invoked on implementations
|
|
|
|
// of a trait, not inherent implementations.
|
2023-01-11 11:32:33 -07:00
|
|
|
let trait_ref = tcx.impl_trait_ref(impl_def_id).unwrap().subst_identity();
|
2023-01-17 09:39:35 +00:00
|
|
|
debug!(?trait_ref);
|
2014-09-12 10:54:08 -04:00
|
|
|
|
Fix orphan checking (cc #19470). (This is not a complete fix of #19470 because of the backwards compatibility feature gate.)
This is a [breaking-change]. The new rules require that, for an impl of a trait defined
in some other crate, two conditions must hold:
1. Some type must be local.
2. Every type parameter must appear "under" some local type.
Here are some examples that are legal:
```rust
struct MyStruct<T> { ... }
// Here `T` appears "under' `MyStruct`.
impl<T> Clone for MyStruct<T> { }
// Here `T` appears "under' `MyStruct` as well. Note that it also appears
// elsewhere.
impl<T> Iterator<T> for MyStruct<T> { }
```
Here is an illegal example:
```rust
// Here `U` does not appear "under" `MyStruct` or any other local type.
// We call `U` "uncovered".
impl<T,U> Iterator<U> for MyStruct<T> { }
```
There are a couple of ways to rewrite this last example so that it is
legal:
1. In some cases, the uncovered type parameter (here, `U`) should be converted
into an associated type. This is however a non-local change that requires access
to the original trait. Also, associated types are not fully baked.
2. Add `U` as a type parameter of `MyStruct`:
```rust
struct MyStruct<T,U> { ... }
impl<T,U> Iterator<U> for MyStruct<T,U> { }
```
3. Create a newtype wrapper for `U`
```rust
impl<T,U> Iterator<Wrapper<U>> for MyStruct<T,U> { }
```
Because associated types are not fully baked, which in the case of the
`Hash` trait makes adhering to this rule impossible, you can
temporarily disable this rule in your crate by using
`#![feature(old_orphan_check)]`. Note that the `old_orphan_check`
feature will be removed before 1.0 is released.
2014-12-26 03:30:51 -05:00
|
|
|
// If the *trait* is local to the crate, ok.
|
2015-08-16 09:06:23 -04:00
|
|
|
if trait_ref.def_id.is_local() {
|
2015-06-18 20:25:05 +03:00
|
|
|
debug!("trait {:?} is local to current crate", trait_ref.def_id);
|
Fix orphan checking (cc #19470). (This is not a complete fix of #19470 because of the backwards compatibility feature gate.)
This is a [breaking-change]. The new rules require that, for an impl of a trait defined
in some other crate, two conditions must hold:
1. Some type must be local.
2. Every type parameter must appear "under" some local type.
Here are some examples that are legal:
```rust
struct MyStruct<T> { ... }
// Here `T` appears "under' `MyStruct`.
impl<T> Clone for MyStruct<T> { }
// Here `T` appears "under' `MyStruct` as well. Note that it also appears
// elsewhere.
impl<T> Iterator<T> for MyStruct<T> { }
```
Here is an illegal example:
```rust
// Here `U` does not appear "under" `MyStruct` or any other local type.
// We call `U` "uncovered".
impl<T,U> Iterator<U> for MyStruct<T> { }
```
There are a couple of ways to rewrite this last example so that it is
legal:
1. In some cases, the uncovered type parameter (here, `U`) should be converted
into an associated type. This is however a non-local change that requires access
to the original trait. Also, associated types are not fully baked.
2. Add `U` as a type parameter of `MyStruct`:
```rust
struct MyStruct<T,U> { ... }
impl<T,U> Iterator<U> for MyStruct<T,U> { }
```
3. Create a newtype wrapper for `U`
```rust
impl<T,U> Iterator<Wrapper<U>> for MyStruct<T,U> { }
```
Because associated types are not fully baked, which in the case of the
`Hash` trait makes adhering to this rule impossible, you can
temporarily disable this rule in your crate by using
`#![feature(old_orphan_check)]`. Note that the `old_orphan_check`
feature will be removed before 1.0 is released.
2014-12-26 03:30:51 -05:00
|
|
|
return Ok(());
|
2014-09-12 10:54:08 -04:00
|
|
|
}
|
|
|
|
|
2023-01-17 09:39:35 +00:00
|
|
|
orphan_check_trait_ref(trait_ref, InCrate::Local)
|
2015-03-30 17:46:34 -04:00
|
|
|
}
|
|
|
|
|
2019-02-08 14:53:55 +01:00
|
|
|
/// Checks whether a trait-ref is potentially implementable by a crate.
|
2017-11-29 20:50:26 +02:00
|
|
|
///
|
|
|
|
/// The current rule is that a trait-ref orphan checks in a crate C:
|
|
|
|
///
|
|
|
|
/// 1. Order the parameters in the trait-ref in subst order - Self first,
|
2018-11-27 02:59:49 +00:00
|
|
|
/// others linearly (e.g., `<U as Foo<V, W>>` is U < V < W).
|
2017-11-29 20:50:26 +02:00
|
|
|
/// 2. Of these type parameters, there is at least one type parameter
|
|
|
|
/// in which, walking the type as a tree, you can reach a type local
|
|
|
|
/// to C where all types in-between are fundamental types. Call the
|
|
|
|
/// first such parameter the "local key parameter".
|
2018-11-27 02:59:49 +00:00
|
|
|
/// - e.g., `Box<LocalType>` is OK, because you can visit LocalType
|
2017-11-29 20:50:26 +02:00
|
|
|
/// going through `Box`, which is fundamental.
|
|
|
|
/// - similarly, `FundamentalPair<Vec<()>, Box<LocalType>>` is OK for
|
|
|
|
/// the same reason.
|
|
|
|
/// - but (knowing that `Vec<T>` is non-fundamental, and assuming it's
|
|
|
|
/// not local), `Vec<LocalType>` is bad, because `Vec<->` is between
|
|
|
|
/// the local type and the type parameter.
|
2020-07-20 23:18:06 +02:00
|
|
|
/// 3. Before this local type, no generic type parameter of the impl must
|
|
|
|
/// be reachable through fundamental types.
|
|
|
|
/// - e.g. `impl<T> Trait<LocalType> for Vec<T>` is fine, as `Vec` is not fundamental.
|
2022-05-24 09:15:19 +02:00
|
|
|
/// - while `impl<T> Trait<LocalType> for Box<T>` results in an error, as `T` is
|
2020-07-20 23:18:06 +02:00
|
|
|
/// reachable through the fundamental type `Box`.
|
2017-11-29 20:50:26 +02:00
|
|
|
/// 4. Every type in the local key parameter not known in C, going
|
|
|
|
/// through the parameter's type tree, must appear only as a subtree of
|
|
|
|
/// a type local to C, with only fundamental types between the type
|
|
|
|
/// local to C and the local key parameter.
|
2018-11-27 02:59:49 +00:00
|
|
|
/// - e.g., `Vec<LocalType<T>>>` (or equivalently `Box<Vec<LocalType<T>>>`)
|
2017-11-29 20:50:26 +02:00
|
|
|
/// is bad, because the only local type with `T` as a subtree is
|
|
|
|
/// `LocalType<T>`, and `Vec<->` is between it and the type parameter.
|
|
|
|
/// - similarly, `FundamentalPair<LocalType<T>, T>` is bad, because
|
2018-02-16 15:56:50 +01:00
|
|
|
/// the second occurrence of `T` is not a subtree of *any* local type.
|
2017-11-29 20:50:26 +02:00
|
|
|
/// - however, `LocalType<Vec<T>>` is OK, because `T` is a subtree of
|
|
|
|
/// `LocalType<Vec<T>>`, which is local and has no types between it and
|
|
|
|
/// the type parameter.
|
|
|
|
///
|
|
|
|
/// The orphan rules actually serve several different purposes:
|
|
|
|
///
|
2018-11-27 02:59:49 +00:00
|
|
|
/// 1. They enable link-safety - i.e., 2 mutually-unknowing crates (where
|
2017-11-29 20:50:26 +02:00
|
|
|
/// every type local to one crate is unknown in the other) can't implement
|
|
|
|
/// the same trait-ref. This follows because it can be seen that no such
|
|
|
|
/// type can orphan-check in 2 such crates.
|
|
|
|
///
|
|
|
|
/// To check that a local impl follows the orphan rules, we check it in
|
|
|
|
/// InCrate::Local mode, using type parameters for the "generic" types.
|
|
|
|
///
|
|
|
|
/// 2. They ground negative reasoning for coherence. If a user wants to
|
|
|
|
/// write both a conditional blanket impl and a specific impl, we need to
|
|
|
|
/// make sure they do not overlap. For example, if we write
|
2022-04-15 15:04:34 -07:00
|
|
|
/// ```ignore (illustrative)
|
2017-11-29 20:50:26 +02:00
|
|
|
/// impl<T> IntoIterator for Vec<T>
|
|
|
|
/// impl<T: Iterator> IntoIterator for T
|
|
|
|
/// ```
|
2017-12-05 15:43:37 +02:00
|
|
|
/// We need to be able to prove that `Vec<$0>: !Iterator` for every type $0.
|
2017-11-29 20:50:26 +02:00
|
|
|
/// We can observe that this holds in the current crate, but we need to make
|
|
|
|
/// sure this will also hold in all unknown crates (both "independent" crates,
|
|
|
|
/// which we need for link-safety, and also child crates, because we don't want
|
|
|
|
/// child crates to get error for impl conflicts in a *dependency*).
|
|
|
|
///
|
|
|
|
/// For that, we only allow negative reasoning if, for every assignment to the
|
|
|
|
/// inference variables, every unknown crate would get an orphan error if they
|
|
|
|
/// try to implement this trait-ref. To check for this, we use InCrate::Remote
|
|
|
|
/// mode. That is sound because we already know all the impls from known crates.
|
|
|
|
///
|
2020-05-01 22:28:15 +02:00
|
|
|
/// 3. For non-`#[fundamental]` traits, they guarantee that parent crates can
|
2017-11-29 20:50:26 +02:00
|
|
|
/// add "non-blanket" impls without breaking negative reasoning in dependent
|
|
|
|
/// crates. This is the "rebalancing coherence" (RFC 1023) restriction.
|
|
|
|
///
|
|
|
|
/// For that, we only a allow crate to perform negative reasoning on
|
2020-05-01 22:28:15 +02:00
|
|
|
/// non-local-non-`#[fundamental]` only if there's a local key parameter as per (2).
|
2017-11-29 20:50:26 +02:00
|
|
|
///
|
|
|
|
/// Because we never perform negative reasoning generically (coherence does
|
|
|
|
/// not involve type parameters), this can be interpreted as doing the full
|
|
|
|
/// orphan check (using InCrate::Local mode), substituting non-local known
|
|
|
|
/// types for all inference variables.
|
|
|
|
///
|
|
|
|
/// This allows for crates to future-compatibly add impls as long as they
|
|
|
|
/// can't apply to types with a key parameter in a child crate - applying
|
|
|
|
/// the rules, this basically means that every type parameter in the impl
|
|
|
|
/// must appear behind a non-fundamental type (because this is not a
|
|
|
|
/// type-system requirement, crate owners might also go for "semantic
|
|
|
|
/// future-compatibility" involving things such as sealed traits, but
|
|
|
|
/// the above requirement is sufficient, and is necessary in "open world"
|
|
|
|
/// cases).
|
|
|
|
///
|
|
|
|
/// Note that this function is never called for types that have both type
|
|
|
|
/// parameters and inference variables.
|
2023-01-17 09:39:35 +00:00
|
|
|
#[instrument(level = "trace", ret)]
|
2019-06-12 00:11:55 +03:00
|
|
|
fn orphan_check_trait_ref<'tcx>(
|
|
|
|
trait_ref: ty::TraitRef<'tcx>,
|
|
|
|
in_crate: InCrate,
|
|
|
|
) -> Result<(), OrphanCheckErr<'tcx>> {
|
2022-01-12 03:19:52 +00:00
|
|
|
if trait_ref.needs_infer() && trait_ref.needs_subst() {
|
2017-11-29 20:50:26 +02:00
|
|
|
bug!(
|
|
|
|
"can't orphan check a trait ref with both params and inference variables {:?}",
|
|
|
|
trait_ref
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2023-01-17 09:39:35 +00:00
|
|
|
let mut checker = OrphanChecker::new(in_crate);
|
2022-07-21 11:51:09 +02:00
|
|
|
match trait_ref.visit_with(&mut checker) {
|
|
|
|
ControlFlow::Continue(()) => Err(OrphanCheckErr::NonLocalInputType(checker.non_local_tys)),
|
|
|
|
ControlFlow::Break(OrphanCheckEarlyExit::ParamTy(ty)) => {
|
|
|
|
// Does there exist some local type after the `ParamTy`.
|
|
|
|
checker.search_first_local_ty = true;
|
|
|
|
if let Some(OrphanCheckEarlyExit::LocalTy(local_ty)) =
|
|
|
|
trait_ref.visit_with(&mut checker).break_value()
|
|
|
|
{
|
|
|
|
Err(OrphanCheckErr::UncoveredTy(ty, Some(local_ty)))
|
|
|
|
} else {
|
|
|
|
Err(OrphanCheckErr::UncoveredTy(ty, None))
|
2020-03-20 05:28:17 +02:00
|
|
|
}
|
2019-09-17 14:40:36 +02:00
|
|
|
}
|
2022-07-21 11:51:09 +02:00
|
|
|
ControlFlow::Break(OrphanCheckEarlyExit::LocalTy(_)) => Ok(()),
|
2015-03-30 17:46:34 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-07-21 11:51:09 +02:00
|
|
|
struct OrphanChecker<'tcx> {
|
2021-12-14 09:44:49 +00:00
|
|
|
in_crate: InCrate,
|
2022-07-21 11:51:09 +02:00
|
|
|
in_self_ty: bool,
|
|
|
|
/// Ignore orphan check failures and exclusively search for the first
|
|
|
|
/// local type.
|
|
|
|
search_first_local_ty: bool,
|
|
|
|
non_local_tys: Vec<(Ty<'tcx>, bool)>,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<'tcx> OrphanChecker<'tcx> {
|
2023-01-17 09:39:35 +00:00
|
|
|
fn new(in_crate: InCrate) -> Self {
|
2022-07-21 11:51:09 +02:00
|
|
|
OrphanChecker {
|
|
|
|
in_crate,
|
|
|
|
in_self_ty: true,
|
|
|
|
search_first_local_ty: false,
|
|
|
|
non_local_tys: Vec::new(),
|
2020-07-17 21:40:47 +02:00
|
|
|
}
|
2019-10-13 11:25:30 -07:00
|
|
|
}
|
2015-03-30 17:46:34 -04:00
|
|
|
|
2022-07-21 11:51:09 +02:00
|
|
|
fn found_non_local_ty(&mut self, t: Ty<'tcx>) -> ControlFlow<OrphanCheckEarlyExit<'tcx>> {
|
|
|
|
self.non_local_tys.push((t, self.in_self_ty));
|
2023-01-17 23:17:13 -08:00
|
|
|
ControlFlow::Continue(())
|
2022-07-21 11:51:09 +02:00
|
|
|
}
|
2020-03-20 05:28:17 +02:00
|
|
|
|
2022-07-21 11:51:09 +02:00
|
|
|
fn found_param_ty(&mut self, t: Ty<'tcx>) -> ControlFlow<OrphanCheckEarlyExit<'tcx>> {
|
|
|
|
if self.search_first_local_ty {
|
2023-01-17 23:17:13 -08:00
|
|
|
ControlFlow::Continue(())
|
2022-07-21 11:51:09 +02:00
|
|
|
} else {
|
|
|
|
ControlFlow::Break(OrphanCheckEarlyExit::ParamTy(t))
|
2020-03-20 05:28:17 +02:00
|
|
|
}
|
2022-07-21 11:51:09 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
fn def_id_is_local(&mut self, def_id: DefId) -> bool {
|
|
|
|
match self.in_crate {
|
|
|
|
InCrate::Local => def_id.is_local(),
|
|
|
|
InCrate::Remote => false,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2020-03-20 05:28:17 +02:00
|
|
|
|
2022-07-21 11:51:09 +02:00
|
|
|
enum OrphanCheckEarlyExit<'tcx> {
|
|
|
|
ParamTy(Ty<'tcx>),
|
|
|
|
LocalTy(Ty<'tcx>),
|
2015-03-30 17:46:34 -04:00
|
|
|
}
|
|
|
|
|
2023-02-09 19:38:07 +00:00
|
|
|
impl<'tcx> TypeVisitor<TyCtxt<'tcx>> for OrphanChecker<'tcx> {
|
2022-07-21 11:51:09 +02:00
|
|
|
type BreakTy = OrphanCheckEarlyExit<'tcx>;
|
|
|
|
fn visit_region(&mut self, _r: ty::Region<'tcx>) -> ControlFlow<Self::BreakTy> {
|
2023-01-17 23:17:13 -08:00
|
|
|
ControlFlow::Continue(())
|
2017-11-22 22:39:40 +02:00
|
|
|
}
|
|
|
|
|
2022-07-21 11:51:09 +02:00
|
|
|
fn visit_ty(&mut self, ty: Ty<'tcx>) -> ControlFlow<Self::BreakTy> {
|
|
|
|
let result = match *ty.kind() {
|
|
|
|
ty::Bool
|
|
|
|
| ty::Char
|
|
|
|
| ty::Int(..)
|
|
|
|
| ty::Uint(..)
|
|
|
|
| ty::Float(..)
|
|
|
|
| ty::Str
|
|
|
|
| ty::FnDef(..)
|
|
|
|
| ty::FnPtr(_)
|
|
|
|
| ty::Array(..)
|
|
|
|
| ty::Slice(..)
|
|
|
|
| ty::RawPtr(..)
|
|
|
|
| ty::Never
|
|
|
|
| ty::Tuple(..)
|
2022-11-26 21:51:55 +00:00
|
|
|
| ty::Alias(ty::Projection, ..) => self.found_non_local_ty(ty),
|
2022-07-21 11:51:09 +02:00
|
|
|
|
|
|
|
ty::Param(..) => self.found_param_ty(ty),
|
|
|
|
|
|
|
|
ty::Placeholder(..) | ty::Bound(..) | ty::Infer(..) => match self.in_crate {
|
|
|
|
InCrate::Local => self.found_non_local_ty(ty),
|
|
|
|
// The inference variable might be unified with a local
|
|
|
|
// type in that remote crate.
|
|
|
|
InCrate::Remote => ControlFlow::Break(OrphanCheckEarlyExit::LocalTy(ty)),
|
|
|
|
},
|
|
|
|
|
|
|
|
// For fundamental types, we just look inside of them.
|
|
|
|
ty::Ref(_, ty, _) => ty.visit_with(self),
|
|
|
|
ty::Adt(def, substs) => {
|
|
|
|
if self.def_id_is_local(def.did()) {
|
|
|
|
ControlFlow::Break(OrphanCheckEarlyExit::LocalTy(ty))
|
|
|
|
} else if def.is_fundamental() {
|
|
|
|
substs.visit_with(self)
|
|
|
|
} else {
|
|
|
|
self.found_non_local_ty(ty)
|
|
|
|
}
|
2018-12-04 13:28:06 +02:00
|
|
|
}
|
2022-07-21 11:51:09 +02:00
|
|
|
ty::Foreign(def_id) => {
|
|
|
|
if self.def_id_is_local(def_id) {
|
|
|
|
ControlFlow::Break(OrphanCheckEarlyExit::LocalTy(ty))
|
|
|
|
} else {
|
|
|
|
self.found_non_local_ty(ty)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
ty::Dynamic(tt, ..) => {
|
|
|
|
let principal = tt.principal().map(|p| p.def_id());
|
|
|
|
if principal.map_or(false, |p| self.def_id_is_local(p)) {
|
|
|
|
ControlFlow::Break(OrphanCheckEarlyExit::LocalTy(ty))
|
|
|
|
} else {
|
|
|
|
self.found_non_local_ty(ty)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
ty::Error(_) => ControlFlow::Break(OrphanCheckEarlyExit::LocalTy(ty)),
|
2023-01-17 09:39:35 +00:00
|
|
|
ty::Closure(did, ..) | ty::Generator(did, ..) => {
|
|
|
|
if self.def_id_is_local(did) {
|
|
|
|
ControlFlow::Break(OrphanCheckEarlyExit::LocalTy(ty))
|
|
|
|
} else {
|
|
|
|
self.found_non_local_ty(ty)
|
|
|
|
}
|
2022-07-21 11:51:09 +02:00
|
|
|
}
|
2023-01-17 09:39:35 +00:00
|
|
|
// This should only be created when checking whether we have to check whether some
|
|
|
|
// auto trait impl applies. There will never be multiple impls, so we can just
|
|
|
|
// act as if it were a local type here.
|
2022-10-01 14:56:24 +02:00
|
|
|
ty::GeneratorWitness(_) | ty::GeneratorWitnessMIR(..) => {
|
|
|
|
ControlFlow::Break(OrphanCheckEarlyExit::LocalTy(ty))
|
|
|
|
}
|
2022-11-26 21:51:55 +00:00
|
|
|
ty::Alias(ty::Opaque, ..) => {
|
2022-07-24 10:34:35 +00:00
|
|
|
// This merits some explanation.
|
|
|
|
// Normally, opaque types are not involved when performing
|
|
|
|
// coherence checking, since it is illegal to directly
|
|
|
|
// implement a trait on an opaque type. However, we might
|
|
|
|
// end up looking at an opaque type during coherence checking
|
|
|
|
// if an opaque type gets used within another type (e.g. as
|
|
|
|
// the type of a field) when checking for auto trait or `Sized`
|
|
|
|
// impls. This requires us to decide whether or not an opaque
|
|
|
|
// type should be considered 'local' or not.
|
|
|
|
//
|
|
|
|
// We choose to treat all opaque types as non-local, even
|
|
|
|
// those that appear within the same crate. This seems
|
|
|
|
// somewhat surprising at first, but makes sense when
|
|
|
|
// you consider that opaque types are supposed to hide
|
|
|
|
// the underlying type *within the same crate*. When an
|
|
|
|
// opaque type is used from outside the module
|
|
|
|
// where it is declared, it should be impossible to observe
|
|
|
|
// anything about it other than the traits that it implements.
|
|
|
|
//
|
|
|
|
// The alternative would be to look at the underlying type
|
|
|
|
// to determine whether or not the opaque type itself should
|
|
|
|
// be considered local. However, this could make it a breaking change
|
|
|
|
// to switch the underlying ('defining') type from a local type
|
|
|
|
// to a remote type. This would violate the rule that opaque
|
|
|
|
// types should be completely opaque apart from the traits
|
|
|
|
// that they implement, so we don't use this behavior.
|
|
|
|
self.found_non_local_ty(ty)
|
|
|
|
}
|
2022-07-21 11:51:09 +02:00
|
|
|
};
|
|
|
|
// A bit of a hack, the `OrphanChecker` is only used to visit a `TraitRef`, so
|
|
|
|
// the first type we visit is always the self type.
|
|
|
|
self.in_self_ty = false;
|
|
|
|
result
|
|
|
|
}
|
2014-09-12 10:54:08 -04:00
|
|
|
|
2022-07-29 09:43:22 +02:00
|
|
|
/// All possible values for a constant parameter already exist
|
|
|
|
/// in the crate defining the trait, so they are always non-local[^1].
|
|
|
|
///
|
|
|
|
/// Because there's no way to have an impl where the first local
|
|
|
|
/// generic argument is a constant, we also don't have to fail
|
|
|
|
/// the orphan check when encountering a parameter or a generic constant.
|
|
|
|
///
|
|
|
|
/// This means that we can completely ignore constants during the orphan check.
|
|
|
|
///
|
2023-01-05 09:45:44 +01:00
|
|
|
/// See `tests/ui/coherence/const-generics-orphan-check-ok.rs` for examples.
|
2022-07-29 09:43:22 +02:00
|
|
|
///
|
|
|
|
/// [^1]: This might not hold for function pointers or trait objects in the future.
|
|
|
|
/// As these should be quite rare as const arguments and especially rare as impl
|
|
|
|
/// parameters, allowing uncovered const parameters in impls seems more useful
|
|
|
|
/// than allowing `impl<T> Trait<local_fn_ptr, T> for i32` to compile.
|
2022-07-21 11:51:09 +02:00
|
|
|
fn visit_const(&mut self, _c: ty::Const<'tcx>) -> ControlFlow<Self::BreakTy> {
|
2023-01-17 23:17:13 -08:00
|
|
|
ControlFlow::Continue(())
|
2014-09-12 10:54:08 -04:00
|
|
|
}
|
|
|
|
}
|