2019-10-11 21:00:09 +02:00
|
|
|
//! Meta-syntax validation logic of attributes for post-expansion.
|
|
|
|
|
2023-04-27 01:53:06 +01:00
|
|
|
use crate::{errors, parse_in};
|
2019-12-05 14:19:00 +01:00
|
|
|
|
2023-08-02 09:56:26 +10:00
|
|
|
use rustc_ast::token::Delimiter;
|
Overhaul `MacArgs::Eq`.
The value in `MacArgs::Eq` is currently represented as a `Token`.
Because of `TokenKind::Interpolated`, `Token` can be either a token or
an arbitrary AST fragment. In practice, a `MacArgs::Eq` starts out as a
literal or macro call AST fragment, and then is later lowered to a
literal token. But this is very non-obvious. `Token` is a much more
general type than what is needed.
This commit restricts things, by introducing a new type `MacArgsEqKind`
that is either an AST expression (pre-lowering) or an AST literal
(post-lowering). The downside is that the code is a bit more verbose in
a few places. The benefit is that makes it much clearer what the
possibilities are (though also shorter in some other places). Also, it
removes one use of `TokenKind::Interpolated`, taking us a step closer to
removing that variant, which will let us make `Token` impl `Copy` and
remove many "handle Interpolated" code paths in the parser.
Things to note:
- Error messages have improved. Messages like this:
```
unexpected token: `"bug" + "found"`
```
now say "unexpected expression", which makes more sense. Although
arbitrary expressions can exist within tokens thanks to
`TokenKind::Interpolated`, that's not obvious to anyone who doesn't
know compiler internals.
- In `parse_mac_args_common`, we no longer need to collect tokens for
the value expression.
2022-04-29 06:52:01 +10:00
|
|
|
use rustc_ast::tokenstream::DelimSpan;
|
2022-11-18 11:24:21 +11:00
|
|
|
use rustc_ast::MetaItemKind;
|
2023-08-02 09:56:26 +10:00
|
|
|
use rustc_ast::{self as ast, AttrArgs, AttrArgsEq, Attribute, DelimArgs, MetaItem};
|
2021-09-17 13:08:56 -07:00
|
|
|
use rustc_errors::{Applicability, FatalError, PResult};
|
2021-11-12 20:15:14 +08:00
|
|
|
use rustc_feature::{AttributeTemplate, BuiltinAttribute, BUILTIN_ATTRIBUTE_MAP};
|
2023-12-12 09:55:50 +11:00
|
|
|
use rustc_session::errors::report_lit_error;
|
2020-01-05 10:47:20 +01:00
|
|
|
use rustc_session::lint::builtin::ILL_FORMED_ATTRIBUTE_INPUT;
|
2024-04-14 20:11:14 +00:00
|
|
|
use rustc_session::lint::BuiltinLintDiag;
|
2020-01-05 10:47:20 +01:00
|
|
|
use rustc_session::parse::ParseSess;
|
2022-11-24 16:00:57 +11:00
|
|
|
use rustc_span::{sym, Span, Symbol};
|
2019-10-11 21:00:09 +02:00
|
|
|
|
2024-03-04 16:31:49 +11:00
|
|
|
pub fn check_attr(psess: &ParseSess, attr: &Attribute) {
|
2019-12-07 21:28:29 +03:00
|
|
|
if attr.is_doc_comment() {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2021-11-12 20:15:14 +08:00
|
|
|
let attr_info = attr.ident().and_then(|ident| BUILTIN_ATTRIBUTE_MAP.get(&ident.name));
|
2019-10-11 21:00:09 +02:00
|
|
|
|
|
|
|
// Check input tokens for built-in and key-value attributes.
|
|
|
|
match attr_info {
|
|
|
|
// `rustc_dummy` doesn't have any restrictions specific to built-in attributes.
|
2021-11-12 20:15:14 +08:00
|
|
|
Some(BuiltinAttribute { name, template, .. }) if *name != sym::rustc_dummy => {
|
2024-03-04 16:31:49 +11:00
|
|
|
check_builtin_attribute(psess, attr, *name, *template)
|
2019-12-22 17:42:04 -05:00
|
|
|
}
|
2022-11-18 11:24:21 +11:00
|
|
|
_ if let AttrArgs::Eq(..) = attr.get_normal_item().args => {
|
2021-08-16 17:29:49 +02:00
|
|
|
// All key-value attributes are restricted to meta-item syntax.
|
2024-03-04 16:31:49 +11:00
|
|
|
parse_meta(psess, attr)
|
Make `DiagnosticBuilder::emit` consuming.
This works for most of its call sites. This is nice, because `emit` very
much makes sense as a consuming operation -- indeed,
`DiagnosticBuilderState` exists to ensure no diagnostic is emitted
twice, but it uses runtime checks.
For the small number of call sites where a consuming emit doesn't work,
the commit adds `DiagnosticBuilder::emit_without_consuming`. (This will
be removed in subsequent commits.)
Likewise, `emit_unless` becomes consuming. And `delay_as_bug` becomes
consuming, while `delay_as_bug_without_consuming` is added (which will
also be removed in subsequent commits.)
All this requires significant changes to `DiagnosticBuilder`'s chaining
methods. Currently `DiagnosticBuilder` method chaining uses a
non-consuming `&mut self -> &mut Self` style, which allows chaining to
be used when the chain ends in `emit()`, like so:
```
struct_err(msg).span(span).emit();
```
But it doesn't work when producing a `DiagnosticBuilder` value,
requiring this:
```
let mut err = self.struct_err(msg);
err.span(span);
err
```
This style of chaining won't work with consuming `emit` though. For
that, we need to use to a `self -> Self` style. That also would allow
`DiagnosticBuilder` production to be chained, e.g.:
```
self.struct_err(msg).span(span)
```
However, removing the `&mut self -> &mut Self` style would require that
individual modifications of a `DiagnosticBuilder` go from this:
```
err.span(span);
```
to this:
```
err = err.span(span);
```
There are *many* such places. I have a high tolerance for tedious
refactorings, but even I gave up after a long time trying to convert
them all.
Instead, this commit has it both ways: the existing `&mut self -> Self`
chaining methods are kept, and new `self -> Self` chaining methods are
added, all of which have a `_mv` suffix (short for "move"). Changes to
the existing `forward!` macro lets this happen with very little
additional boilerplate code. I chose to add the suffix to the new
chaining methods rather than the existing ones, because the number of
changes required is much smaller that way.
This doubled chainging is a bit clumsy, but I think it is worthwhile
because it allows a *lot* of good things to subsequently happen. In this
commit, there are many `mut` qualifiers removed in places where
diagnostics are emitted without being modified. In subsequent commits:
- chaining can be used more, making the code more concise;
- more use of chaining also permits the removal of redundant diagnostic
APIs like `struct_err_with_code`, which can be replaced easily with
`struct_err` + `code_mv`;
- `emit_without_diagnostic` can be removed, which simplifies a lot of
machinery, removing the need for `DiagnosticBuilderState`.
2024-01-03 12:17:35 +11:00
|
|
|
.map_err(|err| {
|
2021-08-16 17:29:49 +02:00
|
|
|
err.emit();
|
|
|
|
})
|
|
|
|
.ok();
|
2019-10-11 21:00:09 +02:00
|
|
|
}
|
2021-08-16 17:29:49 +02:00
|
|
|
_ => {}
|
2019-10-11 21:00:09 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-03-04 16:31:49 +11:00
|
|
|
pub fn parse_meta<'a>(psess: &'a ParseSess, attr: &Attribute) -> PResult<'a, MetaItem> {
|
2019-12-07 21:28:29 +03:00
|
|
|
let item = attr.get_normal_item();
|
|
|
|
Ok(MetaItem {
|
|
|
|
span: attr.span,
|
|
|
|
path: item.path.clone(),
|
|
|
|
kind: match &item.args {
|
2022-11-18 11:24:21 +11:00
|
|
|
AttrArgs::Empty => MetaItemKind::Word,
|
|
|
|
AttrArgs::Delimited(DelimArgs { dspan, delim, tokens }) => {
|
2024-03-04 16:31:49 +11:00
|
|
|
check_meta_bad_delim(psess, *dspan, *delim);
|
|
|
|
let nmis =
|
|
|
|
parse_in(psess, tokens.clone(), "meta list", |p| p.parse_meta_seq_top())?;
|
2019-12-07 21:28:29 +03:00
|
|
|
MetaItemKind::List(nmis)
|
|
|
|
}
|
2022-11-18 11:24:21 +11:00
|
|
|
AttrArgs::Eq(_, AttrArgsEq::Ast(expr)) => {
|
2023-12-12 09:55:50 +11:00
|
|
|
if let ast::ExprKind::Lit(token_lit) = expr.kind {
|
|
|
|
let res = ast::MetaItemLit::from_token_lit(token_lit, expr.span);
|
|
|
|
let res = match res {
|
|
|
|
Ok(lit) => {
|
|
|
|
if token_lit.suffix.is_some() {
|
2024-03-04 16:31:49 +11:00
|
|
|
let mut err = psess.dcx.struct_span_err(
|
2023-12-12 09:55:50 +11:00
|
|
|
expr.span,
|
|
|
|
"suffixed literals are not allowed in attributes",
|
|
|
|
);
|
|
|
|
err.help(
|
|
|
|
"instead of using a suffixed literal (`1u8`, `1.0f32`, etc.), \
|
|
|
|
use an unsuffixed version (`1`, `1.0`, etc.)",
|
|
|
|
);
|
|
|
|
return Err(err);
|
|
|
|
} else {
|
|
|
|
MetaItemKind::NameValue(lit)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
Err(err) => {
|
2024-03-04 16:31:49 +11:00
|
|
|
let guar = report_lit_error(psess, err, token_lit, expr.span);
|
2023-12-12 09:55:50 +11:00
|
|
|
let lit = ast::MetaItemLit {
|
|
|
|
symbol: token_lit.symbol,
|
|
|
|
suffix: token_lit.suffix,
|
2024-02-14 20:12:05 +11:00
|
|
|
kind: ast::LitKind::Err(guar),
|
2023-12-12 09:55:50 +11:00
|
|
|
span: expr.span,
|
|
|
|
};
|
|
|
|
MetaItemKind::NameValue(lit)
|
|
|
|
}
|
|
|
|
};
|
|
|
|
res
|
Overhaul `MacArgs::Eq`.
The value in `MacArgs::Eq` is currently represented as a `Token`.
Because of `TokenKind::Interpolated`, `Token` can be either a token or
an arbitrary AST fragment. In practice, a `MacArgs::Eq` starts out as a
literal or macro call AST fragment, and then is later lowered to a
literal token. But this is very non-obvious. `Token` is a much more
general type than what is needed.
This commit restricts things, by introducing a new type `MacArgsEqKind`
that is either an AST expression (pre-lowering) or an AST literal
(post-lowering). The downside is that the code is a bit more verbose in
a few places. The benefit is that makes it much clearer what the
possibilities are (though also shorter in some other places). Also, it
removes one use of `TokenKind::Interpolated`, taking us a step closer to
removing that variant, which will let us make `Token` impl `Copy` and
remove many "handle Interpolated" code paths in the parser.
Things to note:
- Error messages have improved. Messages like this:
```
unexpected token: `"bug" + "found"`
```
now say "unexpected expression", which makes more sense. Although
arbitrary expressions can exist within tokens thanks to
`TokenKind::Interpolated`, that's not obvious to anyone who doesn't
know compiler internals.
- In `parse_mac_args_common`, we no longer need to collect tokens for
the value expression.
2022-04-29 06:52:01 +10:00
|
|
|
} else {
|
2023-12-12 09:55:50 +11:00
|
|
|
// Example cases:
|
|
|
|
// - `#[foo = 1+1]`: results in `ast::ExprKind::BinOp`.
|
|
|
|
// - `#[foo = include_str!("nonexistent-file.rs")]`:
|
|
|
|
// results in `ast::ExprKind::Err`. In that case we delay
|
|
|
|
// the error because an earlier error will have already
|
|
|
|
// been reported.
|
2024-02-23 19:56:35 +01:00
|
|
|
let msg = "attribute value must be a literal";
|
2024-03-04 16:31:49 +11:00
|
|
|
let mut err = psess.dcx.struct_span_err(expr.span, msg);
|
2024-02-25 22:22:11 +01:00
|
|
|
if let ast::ExprKind::Err(_) = expr.kind {
|
Overhaul `MacArgs::Eq`.
The value in `MacArgs::Eq` is currently represented as a `Token`.
Because of `TokenKind::Interpolated`, `Token` can be either a token or
an arbitrary AST fragment. In practice, a `MacArgs::Eq` starts out as a
literal or macro call AST fragment, and then is later lowered to a
literal token. But this is very non-obvious. `Token` is a much more
general type than what is needed.
This commit restricts things, by introducing a new type `MacArgsEqKind`
that is either an AST expression (pre-lowering) or an AST literal
(post-lowering). The downside is that the code is a bit more verbose in
a few places. The benefit is that makes it much clearer what the
possibilities are (though also shorter in some other places). Also, it
removes one use of `TokenKind::Interpolated`, taking us a step closer to
removing that variant, which will let us make `Token` impl `Copy` and
remove many "handle Interpolated" code paths in the parser.
Things to note:
- Error messages have improved. Messages like this:
```
unexpected token: `"bug" + "found"`
```
now say "unexpected expression", which makes more sense. Although
arbitrary expressions can exist within tokens thanks to
`TokenKind::Interpolated`, that's not obvious to anyone who doesn't
know compiler internals.
- In `parse_mac_args_common`, we no longer need to collect tokens for
the value expression.
2022-04-29 06:52:01 +10:00
|
|
|
err.downgrade_to_delayed_bug();
|
|
|
|
}
|
|
|
|
return Err(err);
|
|
|
|
}
|
|
|
|
}
|
2022-11-18 11:24:21 +11:00
|
|
|
AttrArgs::Eq(_, AttrArgsEq::Hir(lit)) => MetaItemKind::NameValue(lit.clone()),
|
2019-10-11 21:00:09 +02:00
|
|
|
},
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2024-03-04 16:31:49 +11:00
|
|
|
pub fn check_meta_bad_delim(psess: &ParseSess, span: DelimSpan, delim: Delimiter) {
|
2023-08-02 09:56:26 +10:00
|
|
|
if let Delimiter::Parenthesis = delim {
|
2019-12-05 14:19:00 +01:00
|
|
|
return;
|
|
|
|
}
|
2024-03-04 16:31:49 +11:00
|
|
|
psess.dcx.emit_err(errors::MetaBadDelim {
|
2023-04-27 01:53:06 +01:00
|
|
|
span: span.entire(),
|
|
|
|
sugg: errors::MetaBadDelimSugg { open: span.open, close: span.close },
|
|
|
|
});
|
|
|
|
}
|
2019-12-05 14:19:00 +01:00
|
|
|
|
2024-03-04 16:31:49 +11:00
|
|
|
pub fn check_cfg_attr_bad_delim(psess: &ParseSess, span: DelimSpan, delim: Delimiter) {
|
2023-08-02 09:56:26 +10:00
|
|
|
if let Delimiter::Parenthesis = delim {
|
2023-04-27 01:53:06 +01:00
|
|
|
return;
|
|
|
|
}
|
2024-03-04 16:31:49 +11:00
|
|
|
psess.dcx.emit_err(errors::CfgAttrBadDelim {
|
2023-04-27 01:53:06 +01:00
|
|
|
span: span.entire(),
|
|
|
|
sugg: errors::MetaBadDelimSugg { open: span.open, close: span.close },
|
|
|
|
});
|
2019-12-05 14:19:00 +01:00
|
|
|
}
|
|
|
|
|
2019-11-30 00:56:46 +01:00
|
|
|
/// Checks that the given meta-item is compatible with this `AttributeTemplate`.
|
|
|
|
fn is_attr_template_compatible(template: &AttributeTemplate, meta: &ast::MetaItemKind) -> bool {
|
|
|
|
match meta {
|
|
|
|
MetaItemKind::Word => template.word,
|
|
|
|
MetaItemKind::List(..) => template.list.is_some(),
|
|
|
|
MetaItemKind::NameValue(lit) if lit.kind.is_str() => template.name_value_str.is_some(),
|
|
|
|
MetaItemKind::NameValue(..) => false,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-10-11 21:00:09 +02:00
|
|
|
pub fn check_builtin_attribute(
|
2024-03-04 16:31:49 +11:00
|
|
|
psess: &ParseSess,
|
2019-10-11 21:00:09 +02:00
|
|
|
attr: &Attribute,
|
|
|
|
name: Symbol,
|
|
|
|
template: AttributeTemplate,
|
|
|
|
) {
|
2024-03-04 16:31:49 +11:00
|
|
|
match parse_meta(psess, attr) {
|
|
|
|
Ok(meta) => check_builtin_meta_item(psess, &meta, attr.style, name, template),
|
Make `DiagnosticBuilder::emit` consuming.
This works for most of its call sites. This is nice, because `emit` very
much makes sense as a consuming operation -- indeed,
`DiagnosticBuilderState` exists to ensure no diagnostic is emitted
twice, but it uses runtime checks.
For the small number of call sites where a consuming emit doesn't work,
the commit adds `DiagnosticBuilder::emit_without_consuming`. (This will
be removed in subsequent commits.)
Likewise, `emit_unless` becomes consuming. And `delay_as_bug` becomes
consuming, while `delay_as_bug_without_consuming` is added (which will
also be removed in subsequent commits.)
All this requires significant changes to `DiagnosticBuilder`'s chaining
methods. Currently `DiagnosticBuilder` method chaining uses a
non-consuming `&mut self -> &mut Self` style, which allows chaining to
be used when the chain ends in `emit()`, like so:
```
struct_err(msg).span(span).emit();
```
But it doesn't work when producing a `DiagnosticBuilder` value,
requiring this:
```
let mut err = self.struct_err(msg);
err.span(span);
err
```
This style of chaining won't work with consuming `emit` though. For
that, we need to use to a `self -> Self` style. That also would allow
`DiagnosticBuilder` production to be chained, e.g.:
```
self.struct_err(msg).span(span)
```
However, removing the `&mut self -> &mut Self` style would require that
individual modifications of a `DiagnosticBuilder` go from this:
```
err.span(span);
```
to this:
```
err = err.span(span);
```
There are *many* such places. I have a high tolerance for tedious
refactorings, but even I gave up after a long time trying to convert
them all.
Instead, this commit has it both ways: the existing `&mut self -> Self`
chaining methods are kept, and new `self -> Self` chaining methods are
added, all of which have a `_mv` suffix (short for "move"). Changes to
the existing `forward!` macro lets this happen with very little
additional boilerplate code. I chose to add the suffix to the new
chaining methods rather than the existing ones, because the number of
changes required is much smaller that way.
This doubled chainging is a bit clumsy, but I think it is worthwhile
because it allows a *lot* of good things to subsequently happen. In this
commit, there are many `mut` qualifiers removed in places where
diagnostics are emitted without being modified. In subsequent commits:
- chaining can be used more, making the code more concise;
- more use of chaining also permits the removal of redundant diagnostic
APIs like `struct_err_with_code`, which can be replaced easily with
`struct_err` + `code_mv`;
- `emit_without_diagnostic` can be removed, which simplifies a lot of
machinery, removing the need for `DiagnosticBuilderState`.
2024-01-03 12:17:35 +11:00
|
|
|
Err(err) => {
|
2020-02-02 09:47:58 +10:00
|
|
|
err.emit();
|
|
|
|
}
|
2019-10-11 21:00:09 +02:00
|
|
|
}
|
|
|
|
}
|
2021-09-16 17:48:06 -07:00
|
|
|
|
2022-11-24 16:00:57 +11:00
|
|
|
pub fn check_builtin_meta_item(
|
2024-03-04 16:31:49 +11:00
|
|
|
psess: &ParseSess,
|
2022-11-24 16:00:57 +11:00
|
|
|
meta: &MetaItem,
|
|
|
|
style: ast::AttrStyle,
|
|
|
|
name: Symbol,
|
|
|
|
template: AttributeTemplate,
|
|
|
|
) {
|
|
|
|
// Some special attributes like `cfg` must be checked
|
|
|
|
// before the generic check, so we skip them here.
|
|
|
|
let should_skip = |name| name == sym::cfg;
|
|
|
|
|
|
|
|
if !should_skip(name) && !is_attr_template_compatible(&template, &meta.kind) {
|
2024-03-04 16:31:49 +11:00
|
|
|
emit_malformed_attribute(psess, style, meta.span, name, template);
|
2022-11-24 16:00:57 +11:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-09-16 17:48:06 -07:00
|
|
|
fn emit_malformed_attribute(
|
2024-03-04 16:31:49 +11:00
|
|
|
psess: &ParseSess,
|
2022-11-24 16:00:57 +11:00
|
|
|
style: ast::AttrStyle,
|
|
|
|
span: Span,
|
2021-09-16 17:48:06 -07:00
|
|
|
name: Symbol,
|
|
|
|
template: AttributeTemplate,
|
|
|
|
) {
|
|
|
|
// Some of previously accepted forms were used in practice,
|
|
|
|
// report them as warnings for now.
|
|
|
|
let should_warn = |name| {
|
|
|
|
matches!(name, sym::doc | sym::ignore | sym::inline | sym::link | sym::test | sym::bench)
|
|
|
|
};
|
|
|
|
|
2023-07-24 00:18:52 -04:00
|
|
|
let error_msg = format!("malformed `{name}` attribute input");
|
2021-09-16 17:48:06 -07:00
|
|
|
let mut suggestions = vec![];
|
2022-11-24 16:00:57 +11:00
|
|
|
let inner = if style == ast::AttrStyle::Inner { "!" } else { "" };
|
2021-09-16 17:48:06 -07:00
|
|
|
if template.word {
|
2024-04-14 20:11:14 +00:00
|
|
|
suggestions.push(format!("#{inner}[{name}]"));
|
2021-09-16 17:48:06 -07:00
|
|
|
}
|
|
|
|
if let Some(descr) = template.list {
|
2024-04-14 20:11:14 +00:00
|
|
|
suggestions.push(format!("#{inner}[{name}({descr})]"));
|
2021-09-16 17:48:06 -07:00
|
|
|
}
|
|
|
|
if let Some(descr) = template.name_value_str {
|
2024-04-14 20:11:14 +00:00
|
|
|
suggestions.push(format!("#{inner}[{name} = \"{descr}\"]"));
|
2021-09-16 17:48:06 -07:00
|
|
|
}
|
|
|
|
if should_warn(name) {
|
2024-05-20 17:47:54 +00:00
|
|
|
psess.buffer_lint(
|
2024-04-14 20:11:14 +00:00
|
|
|
ILL_FORMED_ATTRIBUTE_INPUT,
|
|
|
|
span,
|
|
|
|
ast::CRATE_NODE_ID,
|
|
|
|
BuiltinLintDiag::IllFormedAttributeInput { suggestions: suggestions.clone() },
|
|
|
|
);
|
2021-09-16 17:48:06 -07:00
|
|
|
} else {
|
2024-04-14 20:11:14 +00:00
|
|
|
suggestions.sort();
|
2024-03-04 16:31:49 +11:00
|
|
|
psess
|
|
|
|
.dcx
|
Restrict `From<S>` for `{D,Subd}iagnosticMessage`.
Currently a `{D,Subd}iagnosticMessage` can be created from any type that
impls `Into<String>`. That includes `&str`, `String`, and `Cow<'static,
str>`, which are reasonable. It also includes `&String`, which is pretty
weird, and results in many places making unnecessary allocations for
patterns like this:
```
self.fatal(&format!(...))
```
This creates a string with `format!`, takes a reference, passes the
reference to `fatal`, which does an `into()`, which clones the
reference, doing a second allocation. Two allocations for a single
string, bleh.
This commit changes the `From` impls so that you can only create a
`{D,Subd}iagnosticMessage` from `&str`, `String`, or `Cow<'static,
str>`. This requires changing all the places that currently create one
from a `&String`. Most of these are of the `&format!(...)` form
described above; each one removes an unnecessary static `&`, plus an
allocation when executed. There are also a few places where the existing
use of `&String` was more reasonable; these now just use `clone()` at
the call site.
As well as making the code nicer and more efficient, this is a step
towards possibly using `Cow<'static, str>` in
`{D,Subd}iagnosticMessage::{Str,Eager}`. That would require changing
the `From<&'a str>` impls to `From<&'static str>`, which is doable, but
I'm not yet sure if it's worthwhile.
2023-04-20 13:26:58 +10:00
|
|
|
.struct_span_err(span, error_msg)
|
2024-01-09 09:08:49 +11:00
|
|
|
.with_span_suggestions(
|
2022-11-24 16:00:57 +11:00
|
|
|
span,
|
2021-09-16 17:48:06 -07:00
|
|
|
if suggestions.len() == 1 {
|
|
|
|
"must be of the form"
|
|
|
|
} else {
|
|
|
|
"the following are the possible correct uses"
|
|
|
|
},
|
2023-12-15 23:56:24 +01:00
|
|
|
suggestions,
|
2021-09-16 17:48:06 -07:00
|
|
|
Applicability::HasPlaceholders,
|
|
|
|
)
|
|
|
|
.emit();
|
|
|
|
}
|
|
|
|
}
|
2021-09-17 13:08:56 -07:00
|
|
|
|
|
|
|
pub fn emit_fatal_malformed_builtin_attribute(
|
2024-03-04 16:31:49 +11:00
|
|
|
psess: &ParseSess,
|
2021-09-17 13:08:56 -07:00
|
|
|
attr: &Attribute,
|
|
|
|
name: Symbol,
|
|
|
|
) -> ! {
|
2021-11-12 20:15:14 +08:00
|
|
|
let template = BUILTIN_ATTRIBUTE_MAP.get(&name).expect("builtin attr defined").template;
|
2024-03-04 16:31:49 +11:00
|
|
|
emit_malformed_attribute(psess, attr.style, attr.span, name, template);
|
2021-09-17 13:08:56 -07:00
|
|
|
// This is fatal, otherwise it will likely cause a cascade of other errors
|
|
|
|
// (and an error here is expected to be very rare).
|
|
|
|
FatalError.raise()
|
|
|
|
}
|