1
Fork 0
rust/tests/ui/methods.stderr

743 lines
28 KiB
Text
Raw Normal View History

2017-08-21 10:26:46 +02:00
error: unnecessary structure name repetition
--> $DIR/methods.rs:20:29
2017-08-21 10:26:46 +02:00
|
20 | pub fn add(self, other: T) -> T { self }
| ^ help: use the applicable keyword: `Self`
2017-08-21 10:26:46 +02:00
|
= note: `-D use-self` implied by `-D warnings`
error: unnecessary structure name repetition
--> $DIR/methods.rs:20:35
2017-08-21 10:26:46 +02:00
|
20 | pub fn add(self, other: T) -> T { self }
| ^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
--> $DIR/methods.rs:24:25
|
24 | fn eq(&self, other: T) -> bool { true } // no error, private function
| ^ help: use the applicable keyword: `Self`
2017-08-21 10:26:46 +02:00
error: unnecessary structure name repetition
--> $DIR/methods.rs:26:26
2017-08-21 10:26:46 +02:00
|
26 | fn sub(&self, other: T) -> &T { self } // no error, self is a ref
2017-08-21 10:26:46 +02:00
| ^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
--> $DIR/methods.rs:26:33
2017-08-21 10:26:46 +02:00
|
26 | fn sub(&self, other: T) -> &T { self } // no error, self is a ref
2017-08-21 10:26:46 +02:00
| ^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
--> $DIR/methods.rs:27:21
2017-08-21 10:26:46 +02:00
|
27 | fn div(self) -> T { self } // no error, different #arguments
2017-08-21 10:26:46 +02:00
| ^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
--> $DIR/methods.rs:28:25
2017-08-21 10:26:46 +02:00
|
28 | fn rem(self, other: T) { } // no error, wrong return type
2017-08-21 10:26:46 +02:00
| ^ help: use the applicable keyword: `Self`
error: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name
--> $DIR/methods.rs:20:5
|
20 | pub fn add(self, other: T) -> T { self }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D should-implement-trait` implied by `-D warnings`
error: defining a method called `drop` on this type; consider implementing the `std::ops::Drop` trait or choosing a less ambiguous name
--> $DIR/methods.rs:21:5
|
2017-10-28 13:24:39 -05:00
21 | pub(crate) fn drop(&mut self) { }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
--> $DIR/methods.rs:31:17
|
31 | fn into_u16(&self) -> u16 { 0 }
| ^^^^^
|
= note: `-D wrong-self-convention` implied by `-D warnings`
error: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
--> $DIR/methods.rs:33:21
|
33 | fn to_something(self) -> u32 { 0 }
| ^^^^
error: methods called `new` usually take no self; consider choosing a less ambiguous name
--> $DIR/methods.rs:35:12
|
35 | fn new(self) {}
| ^^^^
error: methods called `new` usually return `Self`
--> $DIR/methods.rs:35:5
|
35 | fn new(self) {}
| ^^^^^^^^^^^^^^^
|
= note: `-D new-ret-no-self` implied by `-D warnings`
2017-08-21 10:26:46 +02:00
error: unnecessary structure name repetition
--> $DIR/methods.rs:79:24
2017-08-21 10:26:46 +02:00
|
79 | fn new() -> Option<V<T>> { None }
2017-08-21 10:26:46 +02:00
| ^^^^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
--> $DIR/methods.rs:83:19
2017-08-21 10:26:46 +02:00
|
83 | type Output = T;
2017-08-21 10:26:46 +02:00
| ^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
--> $DIR/methods.rs:84:25
2017-08-21 10:26:46 +02:00
|
84 | fn mul(self, other: T) -> T { self } // no error, obviously
2017-08-21 10:26:46 +02:00
| ^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
--> $DIR/methods.rs:84:31
2017-08-21 10:26:46 +02:00
|
84 | fn mul(self, other: T) -> T { self } // no error, obviously
2017-08-21 10:26:46 +02:00
| ^ help: use the applicable keyword: `Self`
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
--> $DIR/methods.rs:103:13
|
103 | let _ = opt.map(|x| x + 1)
| _____________^
104 | |
105 | | .unwrap_or(0); // should lint even though this call is on a separate line
| |____________________________^
|
= note: `-D option-map-unwrap-or` implied by `-D warnings`
= note: replace `map(|x| x + 1).unwrap_or(0)` with `map_or(0, |x| x + 1)`
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
--> $DIR/methods.rs:107:13
|
107 | let _ = opt.map(|x| {
| _____________^
108 | | x + 1
109 | | }
110 | | ).unwrap_or(0);
| |____________________________^
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
--> $DIR/methods.rs:111:13
|
111 | let _ = opt.map(|x| x + 1)
| _____________^
112 | | .unwrap_or({
113 | | 0
114 | | });
| |__________________^
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
--> $DIR/methods.rs:116:13
|
116 | let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
--> $DIR/methods.rs:118:13
|
118 | let _ = opt.map(|x| {
| _____________^
119 | | Some(x + 1)
120 | | }
121 | | ).unwrap_or(None);
| |_____________________^
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
--> $DIR/methods.rs:122:13
|
122 | let _ = opt
| _____________^
123 | | .map(|x| Some(x + 1))
124 | | .unwrap_or(None);
| |________________________^
|
= note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
--> $DIR/methods.rs:130:13
|
130 | let _ = opt.map(|x| x + 1)
| _____________^
131 | |
132 | | .unwrap_or_else(|| 0); // should lint even though this call is on a separate line
| |____________________________________^
|
= note: `-D option-map-unwrap-or-else` implied by `-D warnings`
= note: replace `map(|x| x + 1).unwrap_or_else(|| 0)` with `map_or_else(|| 0, |x| x + 1)`
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
--> $DIR/methods.rs:134:13
|
134 | let _ = opt.map(|x| {
| _____________^
135 | | x + 1
136 | | }
137 | | ).unwrap_or_else(|| 0);
| |____________________________________^
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
--> $DIR/methods.rs:138:13
|
138 | let _ = opt.map(|x| x + 1)
| _____________^
139 | | .unwrap_or_else(||
140 | | 0
141 | | );
| |_________________^
error: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
--> $DIR/methods.rs:147:13
|
147 | let _ = opt.map_or(None, |x| Some(x + 1));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `opt.and_then(|x| Some(x + 1))`
|
= note: `-D option-map-or-none` implied by `-D warnings`
error: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
--> $DIR/methods.rs:149:13
|
149 | let _ = opt.map_or(None, |x| {
| _____________^
150 | | Some(x + 1)
151 | | }
152 | | );
| |_________________^
|
help: try using and_then instead
|
149 | let _ = opt.and_then(|x| {
150 | Some(x + 1)
151 | });
|
2017-10-30 14:10:38 +01:00
error: called `map(f).unwrap_or_else(g)` on a Result value. This can be done more directly by calling `ok().map_or_else(g, f)` instead
--> $DIR/methods.rs:159:13
|
159 | let _ = res.map(|x| x + 1)
| _____________^
160 | |
161 | | .unwrap_or_else(|e| 0); // should lint even though this call is on a separate line
| |_____________________________________^
|
= note: `-D result-map-unwrap-or-else` implied by `-D warnings`
= note: replace `map(|x| x + 1).unwrap_or_else(|e| 0)` with `ok().map_or_else(|e| 0, |x| x + 1)`
error: called `map(f).unwrap_or_else(g)` on a Result value. This can be done more directly by calling `ok().map_or_else(g, f)` instead
--> $DIR/methods.rs:163:13
|
163 | let _ = res.map(|x| {
| _____________^
164 | | x + 1
165 | | }
166 | | ).unwrap_or_else(|e| 0);
| |_____________________________________^
error: called `map(f).unwrap_or_else(g)` on a Result value. This can be done more directly by calling `ok().map_or_else(g, f)` instead
--> $DIR/methods.rs:167:13
|
167 | let _ = res.map(|x| x + 1)
| _____________^
168 | | .unwrap_or_else(|e|
169 | | 0
170 | | );
| |_________________^
2017-08-21 10:26:46 +02:00
error: unnecessary structure name repetition
<<<<<<< HEAD
--> $DIR/methods.rs:176:24
2017-08-21 10:26:46 +02:00
|
176 | fn filter(self) -> IteratorFalsePositives {
2017-08-21 10:26:46 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
--> $DIR/methods.rs:180:22
2017-08-21 10:26:46 +02:00
|
180 | fn next(self) -> IteratorFalsePositives {
2017-08-21 10:26:46 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
--> $DIR/methods.rs:200:32
2017-08-21 10:26:46 +02:00
|
200 | fn skip(self, _: usize) -> IteratorFalsePositives {
2017-08-21 10:26:46 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self`
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
--> $DIR/methods.rs:210:13
|
210 | let _ = v.iter().filter(|&x| *x < 0).next();
=======
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:196:24
2017-08-21 10:26:46 +02:00
|
2017-10-30 13:04:26 +01:00
196 | fn filter(self) -> IteratorFalsePositives {
2017-08-21 10:26:46 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:200:22
2017-08-21 10:26:46 +02:00
|
2017-10-30 13:04:26 +01:00
200 | fn next(self) -> IteratorFalsePositives {
2017-08-21 10:26:46 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:220:32
2017-08-21 10:26:46 +02:00
|
2017-10-30 13:04:26 +01:00
220 | fn skip(self, _: usize) -> IteratorFalsePositives {
2017-08-21 10:26:46 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self`
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:230:13
|
2017-10-30 13:04:26 +01:00
230 | let _ = v.iter().filter(|&x| *x < 0).next();
>>>>>>> 47be6927239cc8dabeb59764581fc4ac73327f22
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D filter-next` implied by `-D warnings`
= note: replace `filter(|&x| *x < 0).next()` with `find(|&x| *x < 0)`
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
<<<<<<< HEAD
--> $DIR/methods.rs:213:13
|
213 | let _ = v.iter().filter(|&x| {
| _____________^
214 | | *x < 0
215 | | }
216 | | ).next();
| |___________________________^
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
--> $DIR/methods.rs:228:13
|
228 | let _ = v.iter().find(|&x| *x < 0).is_some();
=======
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:233:13
|
2017-10-30 13:04:26 +01:00
233 | let _ = v.iter().filter(|&x| {
| _____________^
2017-10-30 13:04:26 +01:00
234 | | *x < 0
235 | | }
236 | | ).next();
| |___________________________^
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:248:13
|
2017-10-30 13:04:26 +01:00
248 | let _ = v.iter().find(|&x| *x < 0).is_some();
>>>>>>> 47be6927239cc8dabeb59764581fc4ac73327f22
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D search-is-some` implied by `-D warnings`
= note: replace `find(|&x| *x < 0).is_some()` with `any(|&x| *x < 0)`
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
<<<<<<< HEAD
--> $DIR/methods.rs:231:13
|
231 | let _ = v.iter().find(|&x| {
| _____________^
232 | | *x < 0
233 | | }
234 | | ).is_some();
| |______________________________^
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
--> $DIR/methods.rs:237:13
|
237 | let _ = v.iter().position(|&x| x < 0).is_some();
=======
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:251:13
|
2017-10-30 13:04:26 +01:00
251 | let _ = v.iter().find(|&x| {
| _____________^
2017-10-30 13:04:26 +01:00
252 | | *x < 0
253 | | }
254 | | ).is_some();
| |______________________________^
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:257:13
|
2017-10-30 13:04:26 +01:00
257 | let _ = v.iter().position(|&x| x < 0).is_some();
>>>>>>> 47be6927239cc8dabeb59764581fc4ac73327f22
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: replace `position(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
<<<<<<< HEAD
--> $DIR/methods.rs:240:13
|
240 | let _ = v.iter().position(|&x| {
| _____________^
241 | | x < 0
242 | | }
243 | | ).is_some();
| |______________________________^
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
--> $DIR/methods.rs:246:13
|
246 | let _ = v.iter().rposition(|&x| x < 0).is_some();
=======
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:260:13
|
2017-10-30 13:04:26 +01:00
260 | let _ = v.iter().position(|&x| {
| _____________^
2017-10-30 13:04:26 +01:00
261 | | x < 0
262 | | }
263 | | ).is_some();
| |______________________________^
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:266:13
|
2017-10-30 13:04:26 +01:00
266 | let _ = v.iter().rposition(|&x| x < 0).is_some();
>>>>>>> 47be6927239cc8dabeb59764581fc4ac73327f22
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: replace `rposition(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
<<<<<<< HEAD
--> $DIR/methods.rs:249:13
|
249 | let _ = v.iter().rposition(|&x| {
| _____________^
250 | | x < 0
251 | | }
252 | | ).is_some();
| |______________________________^
2017-08-21 10:26:46 +02:00
error: unnecessary structure name repetition
--> $DIR/methods.rs:266:21
2017-08-21 10:26:46 +02:00
|
266 | fn new() -> Foo { Foo }
2017-08-21 10:26:46 +02:00
| ^^^ help: use the applicable keyword: `Self`
error: use of `unwrap_or` followed by a function call
--> $DIR/methods.rs:284:5
|
284 | with_constructor.unwrap_or(make());
=======
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:269:13
|
2017-10-30 13:04:26 +01:00
269 | let _ = v.iter().rposition(|&x| {
| _____________^
2017-10-30 13:04:26 +01:00
270 | | x < 0
271 | | }
272 | | ).is_some();
| |______________________________^
2017-08-21 10:26:46 +02:00
error: unnecessary structure name repetition
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:286:21
2017-08-21 10:26:46 +02:00
|
2017-10-30 13:04:26 +01:00
286 | fn new() -> Foo { Foo }
2017-08-21 10:26:46 +02:00
| ^^^ help: use the applicable keyword: `Self`
error: use of `unwrap_or` followed by a function call
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:304:5
|
2017-10-30 13:04:26 +01:00
304 | with_constructor.unwrap_or(make());
>>>>>>> 47be6927239cc8dabeb59764581fc4ac73327f22
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_constructor.unwrap_or_else(make)`
|
= note: `-D or-fun-call` implied by `-D warnings`
error: use of `unwrap_or` followed by a call to `new`
<<<<<<< HEAD
--> $DIR/methods.rs:287:5
|
287 | with_new.unwrap_or(Vec::new());
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_new.unwrap_or_default()`
error: use of `unwrap_or` followed by a function call
--> $DIR/methods.rs:290:5
|
290 | with_const_args.unwrap_or(Vec::with_capacity(12));
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_const_args.unwrap_or_else(|| Vec::with_capacity(12))`
error: use of `unwrap_or` followed by a function call
--> $DIR/methods.rs:293:5
|
293 | with_err.unwrap_or(make());
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_err.unwrap_or_else(|_| make())`
error: use of `unwrap_or` followed by a function call
--> $DIR/methods.rs:296:5
|
296 | with_err_args.unwrap_or(Vec::with_capacity(12));
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_err_args.unwrap_or_else(|_| Vec::with_capacity(12))`
error: use of `unwrap_or` followed by a call to `default`
--> $DIR/methods.rs:299:5
|
299 | with_default_trait.unwrap_or(Default::default());
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_trait.unwrap_or_default()`
error: use of `unwrap_or` followed by a call to `default`
--> $DIR/methods.rs:302:5
|
302 | with_default_type.unwrap_or(u64::default());
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_type.unwrap_or_default()`
error: use of `unwrap_or` followed by a function call
--> $DIR/methods.rs:305:5
|
305 | with_vec.unwrap_or(vec![]);
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_vec.unwrap_or_else(|| < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ))`
error: use of `unwrap_or` followed by a function call
--> $DIR/methods.rs:310:5
|
310 | without_default.unwrap_or(Foo::new());
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `without_default.unwrap_or_else(Foo::new)`
error: use of `or_insert` followed by a function call
--> $DIR/methods.rs:313:5
|
313 | map.entry(42).or_insert(String::new());
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `map.entry(42).or_insert_with(String::new)`
error: use of `or_insert` followed by a function call
--> $DIR/methods.rs:316:5
|
316 | btree.entry(42).or_insert(String::new());
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `btree.entry(42).or_insert_with(String::new)`
error: use of `unwrap_or` followed by a function call
--> $DIR/methods.rs:319:13
|
319 | let _ = stringy.unwrap_or("".to_owned());
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `stringy.unwrap_or_else(|| "".to_owned())`
error: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable
--> $DIR/methods.rs:330:23
|
330 | let bad_vec = some_vec.iter().nth(3);
=======
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:307:5
|
2017-10-30 13:04:26 +01:00
307 | with_new.unwrap_or(Vec::new());
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_new.unwrap_or_default()`
error: use of `unwrap_or` followed by a function call
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:310:5
|
2017-10-30 13:04:26 +01:00
310 | with_const_args.unwrap_or(Vec::with_capacity(12));
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_const_args.unwrap_or_else(|| Vec::with_capacity(12))`
error: use of `unwrap_or` followed by a function call
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:313:5
|
2017-10-30 13:04:26 +01:00
313 | with_err.unwrap_or(make());
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_err.unwrap_or_else(|_| make())`
error: use of `unwrap_or` followed by a function call
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:316:5
|
2017-10-30 13:04:26 +01:00
316 | with_err_args.unwrap_or(Vec::with_capacity(12));
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_err_args.unwrap_or_else(|_| Vec::with_capacity(12))`
error: use of `unwrap_or` followed by a call to `default`
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:319:5
|
2017-10-30 13:04:26 +01:00
319 | with_default_trait.unwrap_or(Default::default());
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_trait.unwrap_or_default()`
error: use of `unwrap_or` followed by a call to `default`
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:322:5
|
2017-10-30 13:04:26 +01:00
322 | with_default_type.unwrap_or(u64::default());
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_type.unwrap_or_default()`
error: use of `unwrap_or` followed by a function call
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:325:5
|
2017-10-30 13:04:26 +01:00
325 | with_vec.unwrap_or(vec![]);
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_vec.unwrap_or_else(|| < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ))`
error: use of `unwrap_or` followed by a function call
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:330:5
|
2017-10-30 13:04:26 +01:00
330 | without_default.unwrap_or(Foo::new());
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `without_default.unwrap_or_else(Foo::new)`
error: use of `or_insert` followed by a function call
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:333:5
|
2017-10-30 13:04:26 +01:00
333 | map.entry(42).or_insert(String::new());
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `map.entry(42).or_insert_with(String::new)`
error: use of `or_insert` followed by a function call
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:336:5
|
2017-10-30 13:04:26 +01:00
336 | btree.entry(42).or_insert(String::new());
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `btree.entry(42).or_insert_with(String::new)`
error: use of `unwrap_or` followed by a function call
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:339:13
|
2017-10-30 13:04:26 +01:00
339 | let _ = stringy.unwrap_or("".to_owned());
2017-07-21 10:40:23 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `stringy.unwrap_or_else(|| "".to_owned())`
error: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:350:23
|
2017-10-30 13:04:26 +01:00
350 | let bad_vec = some_vec.iter().nth(3);
>>>>>>> 47be6927239cc8dabeb59764581fc4ac73327f22
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D iter-nth` implied by `-D warnings`
error: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
<<<<<<< HEAD
--> $DIR/methods.rs:331:26
|
331 | let bad_slice = &some_vec[..].iter().nth(3);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
--> $DIR/methods.rs:332:31
|
332 | let bad_boxed_slice = boxed_slice.iter().nth(3);
| ^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter().nth()` on a VecDeque. Calling `.get()` is both faster and more readable
--> $DIR/methods.rs:333:29
|
333 | let bad_vec_deque = some_vec_deque.iter().nth(3);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter_mut().nth()` on a Vec. Calling `.get_mut()` is both faster and more readable
--> $DIR/methods.rs:338:23
|
338 | let bad_vec = some_vec.iter_mut().nth(3);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter_mut().nth()` on a slice. Calling `.get_mut()` is both faster and more readable
--> $DIR/methods.rs:341:26
|
341 | let bad_slice = &some_vec[..].iter_mut().nth(3);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter_mut().nth()` on a VecDeque. Calling `.get_mut()` is both faster and more readable
--> $DIR/methods.rs:344:29
|
344 | let bad_vec_deque = some_vec_deque.iter_mut().nth(3);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
--> $DIR/methods.rs:356:13
|
356 | let _ = some_vec.iter().skip(42).next();
=======
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:351:26
|
2017-10-30 13:04:26 +01:00
351 | let bad_slice = &some_vec[..].iter().nth(3);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:352:31
|
2017-10-30 13:04:26 +01:00
352 | let bad_boxed_slice = boxed_slice.iter().nth(3);
| ^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter().nth()` on a VecDeque. Calling `.get()` is both faster and more readable
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:353:29
|
2017-10-30 13:04:26 +01:00
353 | let bad_vec_deque = some_vec_deque.iter().nth(3);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter_mut().nth()` on a Vec. Calling `.get_mut()` is both faster and more readable
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:358:23
|
2017-10-30 13:04:26 +01:00
358 | let bad_vec = some_vec.iter_mut().nth(3);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter_mut().nth()` on a slice. Calling `.get_mut()` is both faster and more readable
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:361:26
|
2017-10-30 13:04:26 +01:00
361 | let bad_slice = &some_vec[..].iter_mut().nth(3);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter_mut().nth()` on a VecDeque. Calling `.get_mut()` is both faster and more readable
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:364:29
|
2017-10-30 13:04:26 +01:00
364 | let bad_vec_deque = some_vec_deque.iter_mut().nth(3);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:376:13
|
2017-10-30 13:04:26 +01:00
376 | let _ = some_vec.iter().skip(42).next();
>>>>>>> 47be6927239cc8dabeb59764581fc4ac73327f22
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D iter-skip-next` implied by `-D warnings`
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
<<<<<<< HEAD
--> $DIR/methods.rs:357:13
|
357 | let _ = some_vec.iter().cycle().skip(42).next();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
--> $DIR/methods.rs:358:13
|
358 | let _ = (1..10).skip(10).next();
| ^^^^^^^^^^^^^^^^^^^^^^^
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
--> $DIR/methods.rs:359:14
|
359 | let _ = &some_vec[..].iter().skip(3).next();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: used unwrap() on an Option value. If you don't want to handle the None case gracefully, consider using expect() to provide a better panic message
--> $DIR/methods.rs:368:13
|
368 | let _ = opt.unwrap();
=======
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:377:13
|
2017-10-30 13:04:26 +01:00
377 | let _ = some_vec.iter().cycle().skip(42).next();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:378:13
|
2017-10-30 13:04:26 +01:00
378 | let _ = (1..10).skip(10).next();
| ^^^^^^^^^^^^^^^^^^^^^^^
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:379:14
|
2017-10-30 13:04:26 +01:00
379 | let _ = &some_vec[..].iter().skip(3).next();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: used unwrap() on an Option value. If you don't want to handle the None case gracefully, consider using expect() to provide a better panic message
2017-10-30 13:04:26 +01:00
--> $DIR/methods.rs:388:13
|
2017-10-30 13:04:26 +01:00
388 | let _ = opt.unwrap();
>>>>>>> 47be6927239cc8dabeb59764581fc4ac73327f22
| ^^^^^^^^^^^^
|
= note: `-D option-unwrap-used` implied by `-D warnings`