bjoernager/rust
bjoernager/rust
1
Fork 0
Code Issues Pull requests Activity
rust/src/test/rustdoc-ui/intra-doc/private.private.stderr

20 lines
719 B
Text
Raw Normal View History

rustdoc: Always warn when linking from public to private items Change the logic such that linking from a public to a private item always triggers intra_doc_link_resolution_failure. Previously, the warning was not emitted when --document-private-items is passed. Also don't rely anymore on the item's visibility, which would falsely trigger the lint now that the check for --document-private-items is gone.
2020-07-11 19:39:02 +02:00
warning: public documentation for `DocMe` links to private item `DontDocMe`
Move `src/test/rustdoc-ui` intra-doc tests into a subdirectory This also changes the builder to allow using `x.py test src/test/rustdoc-ui/intra-doc`; before, it would panic that no paths were found.
2020-11-28 21:10:37 -05:00
--> $DIR/private.rs:5:11
rustdoc: Always warn when linking from public to private items Change the logic such that linking from a public to a private item always triggers intra_doc_link_resolution_failure. Previously, the warning was not emitted when --document-private-items is passed. Also don't rely anymore on the item's visibility, which would falsely trigger the lint now that the check for --document-private-items is gone.
2020-07-11 19:39:02 +02:00
|
Fix private intra-doc warnings on associated items The issue was that the `kind, id` override was previously only being considered for the disambiguator check, not the privacy check. This uses the same ID for both.
2021-02-11 19:15:16 -05:00
LL | /// docs [DontDocMe] [DontDocMe::f]
rustdoc: Always warn when linking from public to private items Change the logic such that linking from a public to a private item always triggers intra_doc_link_resolution_failure. Previously, the warning was not emitted when --document-private-items is passed. Also don't rely anymore on the item's visibility, which would falsely trigger the lint now that the check for --document-private-items is gone.
2020-07-11 19:39:02 +02:00
| ^^^^^^^^^ this item is private
|
Separate `private_intra_doc_links` and `broken_intra_doc_links` into separate lints This is not ideal because it means `deny(broken_intra_doc_links)` will no longer `deny(private_intra_doc_links)`. However, it can't be fixed with a new lint group, because `broken` is already in the `rustdoc` lint group; there would need to be a way to nest groups somehow. This also removes the early `return` so that the link will be generated even though it gives a warning.
2020-09-26 21:27:55 -04:00
= note: `#[warn(private_intra_doc_links)]` on by default
rustdoc: Add explanation when linting against public to private item links The additional note helps explaining why the lint was triggered and that --document-private-items directly influences the link resolution.
2020-07-22 19:53:43 +02:00
= note: this link resolves only because you passed `--document-private-items`, but will break without
rustdoc: Always warn when linking from public to private items Change the logic such that linking from a public to a private item always triggers intra_doc_link_resolution_failure. Previously, the warning was not emitted when --document-private-items is passed. Also don't rely anymore on the item's visibility, which would falsely trigger the lint now that the check for --document-private-items is gone.
2020-07-11 19:39:02 +02:00
Fix private intra-doc warnings on associated items The issue was that the `kind, id` override was previously only being considered for the disambiguator check, not the privacy check. This uses the same ID for both.
2021-02-11 19:15:16 -05:00
warning: public documentation for `DocMe` links to private item `DontDocMe::f`
--> $DIR/private.rs:5:23
|
LL | /// docs [DontDocMe] [DontDocMe::f]
| ^^^^^^^^^^^^ this item is private
|
= note: this link resolves only because you passed `--document-private-items`, but will break without
warning: 2 warnings emitted
rustdoc: Always warn when linking from public to private items Change the logic such that linking from a public to a private item always triggers intra_doc_link_resolution_failure. Previously, the warning was not emitted when --document-private-items is passed. Also don't rely anymore on the item's visibility, which would falsely trigger the lint now that the check for --document-private-items is gone.
2020-07-11 19:39:02 +02:00
Reference in a new issue Copy permalink