bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity
rust/tests/rustdoc-ui/invalid-keyword.stderr

11 lines
277 B
Text
Raw Normal View History

Remove `rustc::existing_doc_keyword` lint. `CheckAttrVisitor::check_doc_keyword` checks `#[doc(keyword = "..")]` attributes to ensure they are on an empty module, and that the value is a non-empty identifier. The `rustc::existing_doc_keyword` lint checks these attributes to ensure that the value is the name of a keyword. It's silly to have two different checking mechanisms for these attributes. This commit does the following. - Changes `check_doc_keyword` to check that the value is the name of a keyword (avoiding the need for the identifier check, which removes a dependency on `rustc_lexer`). - Removes the lint. - Updates tests accordingly. There is one hack: the `SelfTy` FIXME case used to used to be handled by disabling the lint, but now is handled with a special case in `is_doc_keyword`. That hack will go away if/when the FIXME is fixed. Co-Authored-By: Guillaume Gomez <guillaume1.gomez@gmail.com>
2024-12-12 13:57:46 +11:00
error: nonexistent keyword `foo df` used in `#[doc(keyword = "...")]`
Add tests for doc_keyword feature extension
2020-11-27 14:28:17 +01:00
--> $DIR/invalid-keyword.rs:3:17
|
LL | #[doc(keyword = "foo df")]
| ^^^^^^^^
Remove `rustc::existing_doc_keyword` lint. `CheckAttrVisitor::check_doc_keyword` checks `#[doc(keyword = "..")]` attributes to ensure they are on an empty module, and that the value is a non-empty identifier. The `rustc::existing_doc_keyword` lint checks these attributes to ensure that the value is the name of a keyword. It's silly to have two different checking mechanisms for these attributes. This commit does the following. - Changes `check_doc_keyword` to check that the value is the name of a keyword (avoiding the need for the identifier check, which removes a dependency on `rustc_lexer`). - Removes the lint. - Updates tests accordingly. There is one hack: the `SelfTy` FIXME case used to used to be handled by disabling the lint, but now is handled with a special case in `is_doc_keyword`. That hack will go away if/when the FIXME is fixed. Co-Authored-By: Guillaume Gomez <guillaume1.gomez@gmail.com>
2024-12-12 13:57:46 +11:00
|
= help: only existing keywords are allowed in core/std
Add tests for doc_keyword feature extension
2020-11-27 14:28:17 +01:00
Bless rustdoc-ui tests Co-authored-by: Adrian <adrian.iosdev@gmail.com>
2023-11-21 16:44:51 +00:00
error: aborting due to 1 previous error
Add tests for doc_keyword feature extension
2020-11-27 14:28:17 +01:00
Copy permalink