bjoernager/forgejo
bjoernager/forgejo
1
Fork 0
Code Issues Pull requests Activity

chore(ui): remove fomantic's dimmer module (#7416)

Browse source 
- Fomantic's dimmer module is responsible for dimming the page and make some element the primary focus on the page (e.g. modal). This module is only used by Fomantic's modal module.
- Remove it and replace the javascript with our own `Dimmer` class that is able to provide Fomantic's modal module with everything it needs.
- Replace the CSS with our own bare minimum CSS.
- No functionality or visual is affected by this replacement.
- E2E test added.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7416
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Gusted <postmaster@gusted.xyz>
Co-committed-by: Gusted <postmaster@gusted.xyz>
This commit is contained in:
Gusted 2025-04-02 12:54:54 +00:00 • committed by Gusted
parent d656978818
commit f691f03741
9 changed files with 109 additions and 1116 deletions
Download patch file Download diff file Expand all files Collapse all files

4
web_src/css/base.css
View file

@ -757,10 +757,6 @@ img.ui.avatar,
box-shadow: 0 6px 18px var(--color-shadow) !important;
}
.ui.dimmer {
background: var(--color-overlay-backdrop);
}
/* Override semantic selector '.ui.menu:not(.vertical) .item > .button' */
/* This fixes the commit graph button on the commits page */
/* modal svg icons, copied from fomantic except width and height */