bjoernager/forgejo
bjoernager/forgejo
1
Fork 0
Code Activity

render plain text file if the LFS object doesn't exist (#31812)

Browse source 
We had an issue where a repo was using LFS to store a file, but the user
did not push the file. When trying to view the file, Gitea returned a
500 HTTP status code referencing `ErrLFSObjectNotExist`. It appears the
intent was the render this file as plain text, but the conditional was
flipped. I've also added a test to verify that the file is rendered as
plain text.

(cherry picked from commit 1310649331648d747c57a52ea3bc92da85e7d4d1)

Conflicts:
	tests/integration/lfs_view_test.go
  trivial context conflict
This commit is contained in:
Rowan Bohde 2024-08-14 16:50:09 -05:00 • committed by Earl Warren
parent 7f1db1df3e
commit ebfdc659d8
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
7 changed files with 18 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/gitea-repositories-meta/user2/lfs.git/objects/30/77e1c4c8964613df72c37d14275c1eda5228a9 Normal file
View file

@ -0,0 +1,2 @@
xKÊÉOR0´0`pö÷ òt
ñôs×ËMQHËÌ)I-²ÍI+VHÉLK3rS‹ÒSÁ,Ý’ÔŠ.-½¬‚t"U&eæ¥23¯,1'“8ûØæAÅ

BIN
tests/gitea-repositories-meta/user2/lfs.git/objects/6b/bc79965141058b0026f2064dfb6d2eae3c4540 Normal file
View file

Binary file not shown.

BIN
tests/gitea-repositories-meta/user2/lfs.git/objects/b0/89e97ee59224e8c5676673c096ee4b6a8b9342 Normal file
View file

Binary file not shown.

BIN
tests/gitea-repositories-meta/user2/lfs.git/objects/e9/c32647bab825977942598c0efa415de300304b Normal file
View file

Binary file not shown.

2
tests/gitea-repositories-meta/user2/lfs.git/refs/heads/master
View file

@ -1 +1 @@
73cf03db6ece34e12bf91e8853dc58f678f2f82d
e9c32647bab825977942598c0efa415de300304b