1
Fork 0

Generate go-licenses during tidy again (#21108)

We can not have the `frontend` target depend on golang because of they
way drone is set up. Move the `go-licenses` generation back into `tidy`
where it will now also be checked for consistency during `tidy-check`.

(I assume all `main` branch builds should currently fail [like
this](https://drone.gitea.io/go-gitea/gitea/60244/1/11)).

The reasony why it shouldn't be treated the same as for example `go
generate` is because output files are checked in. tidy is imho the
optimal target to run this after.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This commit is contained in:
silverwind 2022-09-09 17:33:01 +02:00 committed by GitHub
parent 86ed47e622
commit b5d21c0adf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 32 additions and 18 deletions

View file

@ -102,11 +102,16 @@ steps:
- make test-frontend
depends_on: [lint-frontend]
- name: generate-frontend
image: golang:1.19
commands:
- make generate-frontend
- name: build-frontend
image: node:18
commands:
- make frontend
depends_on: [test-frontend]
depends_on: [deps-frontend, generate-frontend]
- name: build-backend-no-gcc
image: golang:1.18 # this step is kept as the lowest version of golang that we support
@ -529,16 +534,21 @@ services:
steps:
- name: deps-frontend
image: node:16
image: node:18
pull: always
commands:
- make deps-frontend
- name: generate-frontend
image: golang:1.18
commands:
- make generate-frontend
- name: build-frontend
image: node:16
image: node:18
commands:
- make frontend
depends_on: [deps-frontend]
depends_on: [deps-frontend, generate-frontend]
- name: deps-backend
image: golang:1.18